Dashboard

[IDL]

Add the Netlogon service interface definition.

    • -0
    • +6
    /trunk/reactos/sdk/include/reactos/idl/netlogon.acf
    • -0
    • +1500
    /trunk/reactos/sdk/include/reactos/idl/netlogon.idl
[NETAPI32]

Implement I_BrowserrDebugTrace and I_BrowserServerEnum. This functions calls their counterpart in the computer browser service.

    • -2
    • +2
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
    • -0
    • +81
    /trunk/reactos/dll/win32/netapi32/browser.c
[RXCE]

- Implemented RxCompleteSrvOpenKeyAssociation(), RxInitiateSrvOpenKeyAssociation(), RxProcessChangeBufferingStateRequests()

- Implemented RxFinalizeFcbTable(), RxFinalizeNetFobx(), RxFinalizeNetRoot(), RxFinalizeSrvCall(), RxFinalizeVNetRoot(), RxFreeObject(), RxpDestroySrvCall(), RxRemovePrefixTableEntry(), RxRemoveVirtualNetRootFromNetRoot(), RxScavengeRelatedFobxs(), RxTearDownBufferingManager(), RxUndoScavengerFinalizationMarking()

- Implemented RxPostToWorkerThread()

- Implemented RxFlushFcbInSystemCache(), RxPurgeFcb(), RxPurgeFcbInSystemCache()

- Stubbed RxOrphanSrvOpens(), RxpDiscardChangeBufferingStateRequests(), RxpDispatchChangeBufferingStateRequests(), RxpProcessChangeBufferingStateRequests()

- Continued implementation of RxDereference() so that it supports more objects than just SRV_CALL

- Reworked RxInsertWorkQueueItem() implementation so that it accepts any work item, and not just dispatch work items

- Finished implementation of RxTableLookupName() so that it properly returns a V_NET_ROOT on NET_ROOT match

Notable effects of this commit are:

- RXCE/RDBSS leak less memory; now objects without references are properly deleted from the system

- This means that stale objects are also deleted; this fixes CORE-13483 were same stale SRV_CALL was used again and again

- Because in prefix table NET_ROOT are correctly handled, it's now possible to mount several path from the same prefix; this fixes CORE-13482

CORE-8204

CORE-11327

CORE-13482

CORE-13483

    • -0
    • +16
    /trunk/reactos/sdk/include/ddk/fcb.h
    • -0
    • +32
    /trunk/reactos/sdk/include/ddk/buffring.h
    • -30
    • +943
    /trunk/reactos/sdk/lib/drivers/rxce/rxce.c
    • -0
    • +1
    /trunk/reactos/sdk/include/ddk/mrxfcb.h
    • -0
    • +21
    /trunk/reactos/sdk/include/ddk/rxprocs.h
    • -0
    • +4
    /trunk/reactos/sdk/include/ddk/fcbtable.h
    • -0
    • +5
    /trunk/reactos/sdk/include/ddk/prefix.h
    • -0
    • +9
    /trunk/reactos/sdk/include/ddk/rxworkq.h
[USBPORT]

- Fix setting the direction in USBPORT_OpenPipe. Patch by Vadim Galyant.

    • -1
    • +1
    /trunk/reactos/drivers/usb/usbport/endpoint.c
[NTFS] - Fix creation of files with long filenames.
[NTFS] - In the NtfsAddFilenameToDirectory() function, rename DirectoryContext parameter to the more descriptive, and accurate, IndexRootContext (to simplify the next commit).
[NTFS] - Fix a mistake with AddFileName() from my last commit. Also, move CaseSensitive parameter before output parameters in the parameter list of several functions.
[RAPPS]

* available.cpp: Replaced macros with inline functions.

* gui.cpp: Fixed typo.

- update EDD_DIRECTDRAW_LOCAL, EDD_SURFACE and EDD_DIRECTDRAW_GLOBAL structures

- initial implementation of DxDdCreateD3DBuffer and DxDdCreateSurfaceObject CORE-4490

    • -30
    • +0
    /trunk/reactos/win32ss/reactx/dxg/dxg_driver.h
    • -6
    • +98
    /trunk/reactos/win32ss/reactx/dxg/ddraw.c
    • -0
    • +86
    /trunk/reactos/win32ss/reactx/dxg/d3d.c
    • -0
    • +1
    /trunk/reactos/win32ss/reactx/dxg/tags.h
[NTOBJSHEX]

Fix registration.

[NETAPI32]

Implement NetBrowserStatisticsGet().

    • -2
    • +76
    /trunk/reactos/dll/win32/netapi32/browser.c
    • -1
    • +1
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
[AHK]

Fix process enumeration in TerminateTmpProcesses():

-Check for actual functions results

-Close a leaked access token

-Don't skip the first process entry

-Skip the System and Idle processes, they were giving a false reading of failure.

CORE-6939 #resolve

-YEEEEAAAAAAAAHH

    • -26
    • +21
    /trunk/ahk_tests/helper_functions.ahk
[NETAPI32]

Move the functions NetGetDCName, NetGetAnyDCName and NetEnumerateTrustedDomains into a separate file for the Netlogon service interface code.

    • -0
    • +57
    /trunk/reactos/dll/win32/netapi32/netlogon.c
    • -42
    • +0
    /trunk/reactos/dll/win32/netapi32/access.c
[DXG]

Fix GCC build

[NETAPI32]

Implement I_BrowserQueryOtherDomains, I_BrowserQueryStatistics and I_BrowserResetNetlogonState. This functions calls their counterpart in the computer browser service.

    • -0
    • +91
    /trunk/reactos/dll/win32/netapi32/browser.c
    • -3
    • +3
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
[MMIXER] Cleanup mixer notifications opened by an application when it is closed.

CORE-10735 #comment Please retest.

[DXG] Initial implementation of DxDdLock and better stub for DxDdUnlock
    • -0
    • +100
    /trunk/reactos/win32ss/reactx/dxg/ddsurf.c
    • -18
    • +0
    /trunk/reactos/win32ss/reactx/dxg/dxg_driver.h
    • -0
    • +1
    /trunk/reactos/win32ss/reactx/dxg/CMakeLists.txt
[WIN32SS][NTDDRAW] Remove debug dump. Forgot about this.
    • -25
    • +0
    /trunk/reactos/win32ss/reactx/ntddraw/intddraw.h
[WIN32SS][NTDDRAW] Remove debug dump of structures during ReactX initialisation. It's not needed and shouldn't be commited.
    • -722
    • +0
    /trunk/reactos/win32ss/reactx/ntddraw/ddraw.c
[DXG] Replace wrong PLONG with PBYTE as it was in original development. CORE-13392
    • -5
    • +5
    /trunk/reactos/win32ss/reactx/dxg/ddhmg.c
[NTFS] - Fix POSIX rules. Fix accessing long filenames created in Windows when 8dot3 name creation is disabled.

Whether or not a filename should be interpreted as case-sensitive is dependent on a flag passed to the driver when a file is created (opened); it's separate from the namespace associated with the file being accessed.

[NTOBJSHEX]

Make nt object symlinks work more like shortcuts. Fixes the addressbar not quite knowing what to show when you click on a symlink.

[NTOBJSHEX]

Make GCC happy.

[NTOBJSHEX]

* Added a common superclass for the ntobj and registry folders.

* Refactored the ntobj and registry folders to make use of this superclass.

* Removed the concept of a "pidl helper", since it works best to just have the methods be part of the folders.

* Cleaned up the ItemID comparison logic.

    • -95
    • +55
    /trunk/reactos/dll/shellext/ntobjshex/regfolder.h
    • -0
    • +676
    /trunk/reactos/dll/shellext/ntobjshex/foldercommon.h
    • -0
    • +10
    /trunk/reactos/dll/shellext/ntobjshex/foldercommon.cpp
    • -716
    • +198
    /trunk/reactos/dll/shellext/ntobjshex/ntobjfolder.cpp
[QCKLNCH]

-Added Browse Folder Interface (under test).

-Now buttons can show respective icons.

-Minor code cleanup.

[MPR]

Import Wine commit:

- 8d461c1f42b0b667b2aa6a235d007eea1dd6f561, Don't stop enumeration on the first failing network provider.

This fixes 'net use' stoping connections enumeration when a network returns an error or no connection.

CORE-13475

[MPR]

Import Wine commit:

- 51b4a42969366cc409808aded23d3602a34206e2, Properly handle the count set to -1 when enumerating connections.

This fixes 'net use' not being able to enumerate multiple connections served by multiple network providers.

CORE-13475

    • -5
    • +10
    /trunk/reactos/dll/win32/mpr/wnet.c
[NTOS]: Improve a bit CmpDeepCopyKeyInternal():

- Normally getting the SrcNode and DestNode must succeed (checked with assert);

- Set the DestNode Flags member, in particular when this is the new root node of the saved registry hive;

- Copy the key class cell (OK), and the key security cell (currently done in a hackish way; proper way: call the CmpAssignSecurity* function);

- Add more clean-up on failure;

- Warn in code about the fact that CmpDeepCopyKeyInternal is recursive, and will easily exhaust kernel stack. This function will need to be reworked later...

CORE-10793 CORE-10796

    • -11
    • +81
    /trunk/reactos/ntoskrnl/config/cmapi.c
[NTFS] - Fix IncreaseMftSize(); check IrpContext to see if waiting for exclusive access to the MFT is allowed. As pointed out by Pierre.
[QCKLNCH]

-Added IShellFolderBand and stubbed its methods.

-Implemented InitializeSFB.

-Tested enumeration of IShellFolder within CISFBand.