All Activity

[NFS]

Huge "hack" for ReactOS.

In case we're asked to unmount a NFS share, and there are still active FCBs, browse the prefix table for active NET_ROOT, and then, dump their associated FCBs (prefix + refcount).

It seems we only leak the root FCB.

CORE-8204

CORE-11327

CORE-13581

[DDK]

Define RxIsFcbTableLockAcquired

CORE-8204

CORE-11327

CORE-13581

    • -0
    • +3
    /trunk/reactos/sdk/include/ddk/fcbtable.h
[RAPPS]

- A quick fix for counter - used a list that is not updated prior to the message

[ACPICA]

- Update to version 20170629

CORE-13538 #resolve

  1. … 6 more files in changeset.
[RAPPS] Making checkboxes useful WIP

- Added selection counter

*NOTE: This requires changes in lang files*

- Added Sellect/Desellect button functionality

- Fixed some typos and macros-to-wide-functions

[COPYSUP]

Remove leftovers from some attempted ugly things.

Should fix MSVC build

[RDBSS]

- Implement RxFastIoWrite()

- Finish implementation of RxFastIoCheckIfPossible()

[COPYSUP]

- Implement FsRtlCopyWrite2()

This brings (in link with r75398 fast IO writes to RDBSS, and thus NFS!

CORE-8204

CORE-11327

    • -0
    • +1
    /trunk/reactos/sdk/include/ddk/mrxfcb.h
[USBXHCI]

- Changed the ring structure to a segment model.

- some unnecessary parts of the code removed.

- added a function to write 64bit reg.

CORE-13344

[NtUser]

- Broadcast the appropriate messages to notify a change in display parameters and color. This should fix rollback issues from setting display modes. See CORE-12571 and CORE-13212.

    • -16
    • +35
    /trunk/reactos/win32ss/user/ntuser/display.c
    • -0
    • +5
    /trunk/reactos/win32ss/user/ntuser/monitor.c
[COMCTL32] -Implement taking into account the contents margins from the theme when calculating the size of the toolbar button. Using it while painting the button will be implemented in a later commit as it caused me some problems.
    • -15
    • +39
    /trunk/reactos/dll/win32/comctl32/toolbar.c
[STOBJECT]

-Fixed bugs related to strings and localization (needs further improvement).

-Fixed ContextMenu Position bug (for both power and volume).

-Now battery tooltip is as dynamic as its icon.

[FREELDR]

Fix compilation on ARM.

[BOOTLIB]

[BOOTMGR]

Disabled x86-specific code when building ARM.

[LIBSUPP]

Use a hack to replace inline asm which is not supported by MSVC ARM.

[DBGHELP]

Fix ARM register access from context struct.

[MSVCRT]

Fix typo in spec file.

[NTOSKRNL]

[WIN32SS]

Add asm dependency to *sys modules.

[CPPRT]

Add one of the missing constructor aliases. There's more, but my brain is fried at this point.

[BTRFS]

Define-away an include for x86-specific intrinsics.

This is the first batch of fixes for building reactos using the MSVC ARM toolchain. A lot more work is needed to get a full build including rostests and rosapps.

    • -0
    • +3
    /trunk/reactos/sdk/lib/delayimp/delayimp.c
    • -1
    • +5
    /trunk/reactos/boot/environ/CMakeLists.txt
    • -0
    • +3
    /trunk/reactos/sdk/lib/cpprt/arm/cpprt.s
    • -0
    • +5
    /trunk/reactos/dll/ntdll/rtl/libsupp.c
    • -0
    • +1
    /trunk/reactos/ntoskrnl/CMakeLists.txt
    • -0
    • +15
    /trunk/reactos/boot/environ/lib/platform/time.c
[RDBSS]

- Implement RxCommonSetInformation(), RxpSetInfoMiniRdr(), RxSetBasicInfo()

- Stub RxSetAllocationInfo(), RxSetDispositionInfo(), RxSetEndOfFileInfo(), RxSetPipeInfo(), RxSetPositionInfo(), RxSetRenameInfo(), RxSetSimpleInfo()

CORE-8204

CORE-11327

[XDK]

Define FILE_ATTRIBUTE_INTEGRITY_STREAM

    • -0
    • +1
    /trunk/reactos/sdk/include/xdk/iotypes.h
[NtUser]

- Initialize rectangle to all zero's. See CORE-13582.

    • -1
    • +1
    /trunk/reactos/win32ss/user/ntuser/windc.c
[CABMAN]

Fix pointer math ('unsigned long' will truncate the pointer).

[MKISOFS/SCHILY TOOLS]

Fix the invalid assumption that a 'long' variable can hold pointers. Will be sent upstream.

With this the whole of reactos and rostests builds on x64. Rosapps still has issues.

    • -2
    • +2
    /trunk/reactos/sdk/tools/cabman/mszip.cxx
[RDBSS]

- Implement __RxWriteReleaseResources(), RxCommonWrite(), RxCompleteMdl(), RxGetTopIrpIfRdbssIrp(), RxLowIoWriteShell(), RxLowIoWriteShellCompletion()

- Finish implementation of RxCommonCleanup() so that it handles setting EOF on a file

- Finish implementation of RxCommonCreate() so that it handles sharing violations and attempts to scavenge open files

[RXCE]

- Implement RxpScavengeFobxs(), RxpTrackDereference(), RxpTrackReference(), RxPurgeFobx(), RxPurgeRelatedFobxs(), RxReinitializeContext(), RxSetFileSizeWithLock(), RxScavengeFobxsForNetRoot()

- Fix a bug in RxPrefixTableLookupName() where it was badly handling nodes in scavenger

This commits brings several improvments to the NFS driver.

First of all, now, the driver handles creating, extending and writing to files!

It also handles purging dormant opened files when a file opening fails because of a sharing violation

Finally, it also brings something to look at our references issues in RDBSS to help finding out why our FCB are never (or nearly) dereferenced

CORE-8204

CORE-11327

CORE-13581

    • -0
    • +47
    /trunk/reactos/sdk/include/ddk/rxprocs.h
    • -0
    • +16
    /trunk/reactos/sdk/include/ddk/scavengr.h
    • -0
    • +18
    /trunk/reactos/sdk/include/ddk/fcb.h
    • -6
    • +470
    /trunk/reactos/sdk/lib/drivers/rxce/rxce.c
    • -110
    • +1434
    /trunk/reactos/sdk/lib/drivers/rdbsslib/rdbss.c
    • -0
    • +34
    /trunk/reactos/sdk/include/ddk/rxcontx.h
[APITESTS]

MSVCRT_CRT_APITEST: Remove getmainargs tests from X64 build.

DELAYIMP: Fix callback prototype.

CComHeapPtr: Fix implementation of IMallocSpy to match the actual interface.

[WINETESTS]

ntdll: Disable 'generated' tests when not i386 platform, since they were generated for x86 and not x64 or ARM.

Fixes x64 compilation for tests.

    • -0
    • +2
    /trunk/rostests/apitests/crt/testlist.c
    • -1
    • +1
    /trunk/rostests/apitests/sdk/delayimp.cpp
[BOOTLIB]

Stub out some arch-specific functions (fixes x64 build).

[USBPORT]

Actually fix x64 build. The old code was not working at all, but the bootlib errors cancelled the build earlier than I thought.

The X64 compilation now succeeds, but cabman crashes trying to generate the bootcd.

    • -0
    • +27
    /trunk/reactos/boot/environ/lib/mm/stub/mm.c
    • -1
    • +7
    /trunk/reactos/drivers/usb/usbport/usbport.h
Sync branch with trunk r75394.
  1. … 127 more files in changeset.
[EXPLORER]

[RSHELL]

[NTOBJSHEX]

[BROWSEUI]

[SHELL32]

Get rid of the unused "placement new" operators.

    • -5
    • +0
    /trunk/reactos/dll/win32/shell32/shell32.cpp
    • -5
    • +0
    /trunk/reactos/base/shell/explorer/explorer.cpp
    • -5
    • +0
    /trunk/reactos/dll/win32/browseui/browseui.cpp
    • -5
    • +0
    /trunk/reactos/base/shell/rshell/misc.cpp
[USBPORT]

Oops, brainfart (Fixes 32bit build).

[MSPAINT]

Correct callback return type (Fixes X64 build).

[USETUP]

Correct definition of the struct (fixes X64 build).

[USBPORT]

Improve struct size checks so they are X64-compatible (fixes X64 build).

The build as a whole still fails due to bootlib, but implementing those is beyond my expertise.

    • -2
    • +7
    /trunk/reactos/drivers/usb/usbport/usbport.h
[SHORTCUTS.INF] Move the shortcut creation for screenshot.exe to the new rosapps_shortcuts.inf. Patch by Joachim Henze (reactosfanboy)

CORE-13426 #resolve #comment Thanks!

    • -0
    • +47
    /trunk/rosapps/rosapps_shortcuts.inf
    • -47
    • +0
    /trunk/reactos/media/inf/shortcuts.inf
[WIN32SS][SHELL32] Fix the location and repaint of the version info shown on the desktop. Patch by Katayama Hirofumi MZ.

CORE-13567 #resolve #comment Thanks!

    • -0
    • +5
    /trunk/reactos/win32ss/user/ntuser/desktop.c
[EXPLORER] -Restore a call to RegLoadSettings while handling WM_DISPLAYCHANGE which was removed in r74221. This is not really correct since it resets the size and position of the taskbar but I add it back since it updates the cached rects for all four positions.
    • -0
    • +3
    /trunk/reactos/base/shell/explorer/traywnd.cpp
[SYSSETUP][SHORTCUTS.INF] Add FontSub program shortcut to Start Menu. Patch by Katayama Hirofumi MZ.

CORE-13428 #resolve #comment Thanks!

    • -0
    • +294
    /trunk/rosapps/rosapps_shortcuts.inf
    • -0
    • +14
    /trunk/reactos/dll/win32/syssetup/install.c
[UNATTEND]: Move a comment sign ';' to a better place.
[EXPLORER] -Implement the minimum taskbar size for the vertical position.
    • -1
    • +7
    /trunk/reactos/base/shell/explorer/traywnd.cpp
    • -19
    • +11
    /trunk/reactos/base/shell/explorer/taskband.cpp