Checkout Tools
  • last updated 7 hours ago
Constraints: committers
Constraints: files
Constraints: dates

Add exports for RtlOemStringToUnicodeSize, RtlUnicodeStringToAnsiSize and RtlUnicodeStringToOemSize as redirections to suitable Rtlx*** functions, as done in our ntoskrnl (and as on Windows either).

This should fix MSYS2 start on ReactOS.

CORE-10459 #comment Please retest!

    • -4
    • +4
[CRT] Partially sync strtoi64 with Wine Staging 1.9.9. Patch by Samuel Serapión CORE-11174 #resolve #comment Thanks!
    • -0
    • +1
    • -7
    • +35
    • -78
    • +2

Add test for ExSetResourceOwnerPointer() and ExReleaseResourceForThreadLite()



- RChangeServiceConfigA/W: Modify or delete password secrets.


- ChangeServiceConfigA, CreateServiceA: Convert passwords to Unicode before passing them to the remote functions.

    • -6
    • +54
    • -2
    • +45

Fix misleading comment


- The usual second forgotten file


- Implement MmProbeAndLockProcessPages


- The usual forgotten file


- Create section object when creating the file shared cache map

- Map the said section PsInitialSystemProcess address space and map it in kernel space using MmProbeAndLockProcessPages

- Implement CcSetFileSizes on top of MmExtendSection

    • -102
    • +58

- "Convert" to PSEH2 + unix compilation friendliness

- Use

  1. … 15 more files in changeset.

In Cc, replace the Vacb mutex by a Bcb resource.

Note that the resource is still placed in the Vacb by it belongs to the Bcb.

This is required to really implement CcSetBcbOwnerPointer().


    • -0
    • +12
    • -31
    • +14

RCreateServiceW: Store a given password as a secret.

    • -5
    • +13
    • -0
    • +55

Implement LogonUserEx[A/W].

    • -0
    • +32
    • -2
    • +2
    • -20
    • +91
[ADVAPI32]: Implement all the Elf*** event log APIs as wrappers around the corresponding RPC calls, and the Win32 APIs just become calls to the Elf*** APIs.
    • -19
    • +19
[IDL]: Whitespace fixes only.

- Return the ACE pointer from RtlFirstFreeAce also if it is at the end of the ACL buffer.

CORE-11304 #resolve

    • -0
    • +234
    • -0
    • +4
    • -0
    • +260
[APPHELP][APPHELP_APITEST] Add more db tests and implement SdbGetDatabaseVersion. CORE-10367

    • -15
    • +521
    • -0
    • +212
[APPHELP][APPHELP_APITEST] Implement most of sdbread and sdbwrite, mainly the work of Mislav Blaževic, with some small additions from me. CORE-10367
    • -0
    • +328
    • -0
    • +439
    • -0
    • +283

- Fix Buffer overflow in FixupServiceBinaryPath


- Fix the flags used in LoadLibraryEx calls for loading DLLs as resource files.

- Use a nice flag (FORMAT_MESSAGE_MAX_WIDTH_MASK) in FormatMessage calls so that no useless extra newlines are appended to the message strings that are recovered.

This is especially useful when some strings as localized event log names are retrieved to be displayed in the menu (amongst other things)...

This fixes CORE-8915 and fixes also the presentation of some event descriptions.

- Fix BuildLogList.


- Set window parent for different MessageBox calls.

- Add a notice in ShowStatusMessageThread concerning a potential bug.

- Rename strings "Save Protocol" into "Save Event Log"; adjust translations in this regard.

  1. … 10 more files in changeset.

- Fix a typo in the "loading, wait" dialog.

- Use a RichEdit control for the detailed event description text, so that we can have for free clickable URLs.

- Use "Courier New" as the font for the event data text, so that we can have finer grained control over the font size...

  1. … 10 more files in changeset.




Display event data properly.


- Set received length to zero when the receive result is MBEDTLS_ERR_SSL_PEER_CLOSE_NOTIFY instead of pretending we got data

CORE-11285 #resolve


- Correctly check for ROS_SCHAN_IS_BLOCKING



- When handling CD READ_CAPACITY requests in AtapiInterrupt__, fully rewind the DataBuffer instead of relying on the last read length. Fixes crash on first stage boot in KVM.

CORE-11286 #resolve



Update the amount of FAT entries taking into account that the first two are reserved and thus not usable.

Patch by Wim Hueskes

CORE-11283 #resolve #comment Committed in r71370, thanks for your patch!

    • -0
    • +17

Update acknowledgements regarding imported FSDs in ReactOS.

Thanks Matt Wu and Mark Harmstone for your great work!

    • -1
    • +1

- Fix the window styles of the edit boxes in the event details dialog.

- Refactor some parts of the code to reduce the level of code indentation.

- Replace malloc/free by their Win32 counterparts HeapAlloc/HeapFree.

- When caching the full contents of a given event log, don't load at this point the event text/data. Only load those when opening the event details dialog.

  1. … 10 more files in changeset.