reactos

Checkout Tools
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[SHELL32] - CDefView: Remove some todo comments that are done.
    • -10
    • +0
    /trunk/reactos/dll/win32/shell32/CDefView.cpp
ReactOS 0.4.3 was released! Tag its repo.
  1. … 26778 more files in changeset.
[SHELL32] - Initialize the shell icon cache only when needed or when FileIconInit is called (and not in the DllMain of shell32)
    • -5
    • +18
    /trunk/reactos/dll/win32/shell32/iconcache.cpp
    • -1
    • +0
    /trunk/reactos/dll/win32/shell32/shell32.cpp
[SERVICES]: Addendum to r73433 for ScmStartUserModeService:

- Use the correct capitalization for the desktop name (to be consistent with all the rest of our code);

- Fix DPRINT1 order of arguments;

- Reorganize a bit the code to avoid the memory leak if ImpersonateLoggedOnUser fails and the environment block was already allocated (caught by Ged Murphy).

CORE-12414

    • -26
    • +35
    /trunk/reactos/base/system/services/database.c
[SHELL32] Don't call CoInitialize in DllMain, bad things happen when calling into dll's that are being loaded! CORE-12443 #comment Please retest!
    • -1
    • +3
    /trunk/reactos/dll/win32/shell32/folders.cpp
    • -1
    • +1
    /trunk/reactos/dll/win32/shell32/shell32.cpp
[SERVICES]

Create a new environment block when a service process is started.

Patch by Hermès BÉLUSCA - MAÏTO.

CORE-12414

    • -12
    • +69
    /trunk/reactos/base/system/services/database.c
Fix for source code file header, sorry for commit noise.
[ADVAPI32_APITEST]: Test for a (correctly initialized) service process environment block, that should contain both ALLUSERSPROFILE and USERPROFILE environment variables.

CORE-12414

    • -0
    • +259
    /trunk/rostests/apitests/advapi32/ServiceEnv.c
[ADVAPI32_APITEST]: Add a small helper lib 'svchlp' for common routines for test-services embedded in api tests. Taken & heavily adapted from Jacek Caban's services_service test and Thomas Faber's ServiceArgs.c (the latter will be able to use 'svchlp' when it'll be ready).

CORE-12414

    • -0
    • +73
    /trunk/rostests/apitests/advapi32/svchlp.h
[BROWSEUI]

Fix CShellBrowser window class name,

shown by shell32:progman_dde and AHK_Diablo_1.0:1.install

[NTDLL]: Export _wcstoui64 (as done in Win2k3). Prototype from msvcrt. CORE-12534
    • -1
    • +1
    /trunk/reactos/dll/ntdll/def/ntdll.spec
[NTDLL]: Add proper stubs for EtwpGetTraceBuffer and EtwpSetHWConfigFunction, needed for CORE-12534.

[NTDLL][ADVAPI32]: Improve the prototypes for EtwReceiveNotificationsA/WmiReceiveNotificationsA and EtwReceiveNotificationsW/WmiReceiveNotificationsW.

    • -2
    • +2
    /trunk/reactos/dll/win32/advapi32/advapi32.spec
    • -4
    • +4
    /trunk/reactos/dll/ntdll/def/ntdll.spec
[ADVAPI32_APITEST]: Rename the 'LockDatabase' test to 'LockServiceDatabase' to better match the name of the API.
    • -761
    • +0
    /trunk/rostests/apitests/advapi32/LockDatabase.c
[USERENV]: Use ARRAYSIZE instead of hardcoding the sizes of the static buffers.
    • -25
    • +25
    /trunk/reactos/dll/win32/userenv/setup.c
[DESK] Fix theme preview for Win7. Patch by Carlo Bramini. CORE-10076 #resolve #comment Thanks!
    • -0
    • +17
    /trunk/reactos/dll/cpl/desk/theme.c
[INCLUDE]

Add CreateUserProfileExA and CreateUserProfileExW prototypes to userenv.h.

    • -0
    • +4
    /trunk/reactos/sdk/include/psdk/userenv.h
[APPSHIM_APITEST] Add tests for the DisableThemes shim. CORE-11927
[APPSHIM_APITEST] Add tests for display mode shims. CORE-11927
    • -0
    • +301
    /trunk/rostests/apitests/appshim/dispmode.c
[SERVICES]

- Code cleanup.

- ScmCreateOrReferenceServiceImage() and ScmDereferenceServiceImage(): Close the logon token and service process handles properly.

- ScmStartUserModeService(): Store the service process handle in the SERVICE_IMAGE struct.

Patch by Hermès BÉLUSCA - MAÏTO.

    • -19
    • +31
    /trunk/reactos/base/system/services/database.c
[SERVICES]

Tiny fixes.

One fix found by Serge Gautherie.

    • -2
    • +2
    /trunk/reactos/base/system/services/rpcserver.c
[SERVICES]

Add more parameter checks to RChangeServiceConfigW().

    • -0
    • +34
    /trunk/reactos/base/system/services/rpcserver.c
[SERVICES]

Implement large parts of RI_ScGetCurrentGroupStateW.

    • -0
    • +35
    /trunk/reactos/base/system/services/groupdb.c
    • -3
    • +47
    /trunk/reactos/base/system/services/rpcserver.c
[SERVICES]

- Get rid of the obsolete USE_SERVICE_START_PENDING option.

- Services do not accept any command when they are in SERVICE_START_PENDING state.

Patch by Hermès BÉLUSCA - MAÏTO.

    • -11
    • +2
    /trunk/reactos/base/system/services/database.c
[TIMEDATE] Update/Fix German and French resource files. Patch by Joachim Henze and Kyle Katarn. CORE-12369
    • -1
    • +1
    /trunk/reactos/dll/cpl/timedate/lang/de-DE.rc
    • -1
    • +1
    /trunk/reactos/dll/cpl/timedate/lang/fr-FR.rc
[RAPPS][USERINIT][HIVECLS] Add/Update Italian translation. Patches by Carlo Bramini. Thanks. CORE-9725 #comment rapps_new and usrmgr were not appliable, please check your patches. The others were committed in r73414
    • -0
    • +22
    /trunk/reactos/boot/bootdata/hivecls.inf
[ROSTESTS]: advapi32_apitest: Add a test to extensively test services command-line arguments. By Thomas Faber.

[ADVAPI32]: Correctly set up both the ANSI and UNICODE service command-line arguments. Adapted from a patch by Thomas Faber. Thanks!

[SERVICES]

- Correctly pack the service command-line arguments in the control packet structure. In particular, the offsets stored in the vector are relative to the beginning of the vector (and not relative to the previous offset ^^). Improve comments...

- Fix the definition of the SCM_CONTROL_PACKET control packet structure to make it Win2k3-compatible, so that we can use Win2k3' advapi32.dll or services.exe on ReactOS and vice-versa.

CORE-9235 CORE-9838

    • -23
    • +28
    /trunk/reactos/base/system/services/database.c
    • -0
    • +475
    /trunk/rostests/apitests/advapi32/ServiceArgs.c
[NETSHELL]Add Japanese translation. Patch by Katayama Hirofumi MZ. Thanks. CORE-12514
    • -32
    • +31
    /trunk/reactos/dll/shellext/netshell/lang/ja-JP.rc
[RUNONCE] Add Italian translation. Patch by Carlo Bramini. Thanks. CORE-12488
    • -0
    • +11
    /trunk/reactos/base/system/runonce/lang/it-IT.rc
This does not belong here.
[NETSHELL] Implement NcIsValidConnectionName + tests. Patch by Jared Smudde, modified by me. CORE-11320 #resolve
    • -0
    • +1
    /trunk/rostests/apitests/CMakeLists.txt
    • -0
    • +121
    /trunk/rostests/apitests/netshell/NcIsValidConnectionName.c
    • -0
    • +11
    /trunk/rostests/apitests/netshell/testlist.c
    • -0
    • +5
    /trunk/rostests/apitests/netshell/CMakeLists.txt