• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Bye SHA1 @utorrent and bittorrent. Still no nice direct links for the broken ones found.
    • -2
    • +1
    /trunk/reactos/media/rapps/utorrent.txt
    • -1
    • +0
    /trunk/reactos/media/rapps/bittorrent.txt
[CMAKE] Update baseaddress.cmake for the GCC build.
    • -338
    • +338
    /trunk/reactos/sdk/cmake/baseaddress.cmake
[Win32SS]

- Fix regression from 62529, striped all the MF_POPUP from the code, no way to know if the submenu is a drop menu. See CORE-9269.

    • -1
    • +1
    /trunk/reactos/win32ss/user/ntuser/menu.c
[LSASRV]

Implement LsarEnumerateAccountsWithUserRight.

    • -2
    • +268
    /trunk/reactos/dll/win32/lsasrv/lsarpc.c
[ROSTESTS]: Add an interactive test that tests some parts of the event log service.

CORE-11843 CORE-11838

    • -0
    • +21
    /trunk/rostests/win32/advapi32/eventlog/CMakeLists.txt
    • -0
    • +468
    /trunk/rostests/win32/advapi32/eventlog/EvtLogTest.c
    • -0
    • +102
    /trunk/rostests/win32/advapi32/eventlog/MyEventProvider.mc
    • -0
    • +1
    /trunk/rostests/win32/advapi32/CMakeLists.txt
[ROSTESTS]: Update the code file header.
[SDK:MC]: Ensure the EOL style of MC files is *always* CR-LF in *all* platforms.
[LSASRV]

Add missing TRACE messages.

    • -14
    • +47
    /trunk/reactos/dll/win32/lsasrv/lsarpc.c
[SHELL32]

- Fix a bug in CStartMenu_Constructor and add some comments to explain what this part does.

[LSASRV]

LsarQuerySecurityObject: Build a new SD that conatains requested information only and return it to the caller.

    • -8
    • +48
    /trunk/reactos/dll/win32/lsasrv/lsarpc.c
Added Port Reset for non Idle ports

FIXED missing VendorId, RevisionId and SerialNo

[LSASRV]

Implement LsaIFree_LSAPR_CR_CIPHER_VALUE, LsaIFree_LSAPR_PRIVILEGE_ENUM_BUFFER and LsaIFree_LSAPR_REFERENCED_DOMAIN_LIST.

    • -0
    • +61
    /trunk/reactos/dll/win32/lsasrv/lsasrv.c
[SYSSETUP]

InstallPrivileges:

- Use LsaAddAccountRights instead of LsaAddPrivilegesToAccount. This enables us to add privileges and user rights to a given account.

- Identify SIDs by a leading asterisk. Account names do not start with an asterisk.

defltws.inf:

- Add user rights.

- Add an asterisk before all SIDs.

    • binary
    /trunk/reactos/media/inf/defltws.inf
    • -32
    • +37
    /trunk/reactos/dll/win32/syssetup/security.c
[LSASRV]

Implement LsaIFree_LSAPR_ACCOUNT_ENUM_BUFFER and fix a typo.

    • -0
    • +22
    /trunk/reactos/dll/win32/lsasrv/lsasrv.c
[LSASRV]

- LsapRegQueryKeyInfo: Return the maximum sub key name length too.

- LsarEnumerateAccounts: User the maximum sub key name length to allocate a large enough buffer instead of using a fixed size one.

- LsarAddAccountRights: Use the proper value size to retrieve the system access attribute.

    • -10
    • +31
    /trunk/reactos/dll/win32/lsasrv/lsarpc.c
    • -0
    • +1
    /trunk/reactos/dll/win32/lsasrv/lsasrv.h
[CRT][CRT_APITEST] Fix __getmainargs and __wgetmainargs parsing, verified with apitests. Patch by Yaroslav Veremenko. CORE-11673 #resolve #comment Thanks!
    • -69
    • +146
    /trunk/reactos/sdk/lib/crt/misc/getargs.c
    • -0
    • +2
    /trunk/rostests/apitests/crt/testlist.c
    • -0
    • +100
    /trunk/rostests/apitests/crt/__getmainargs.c
[EVENTLOG]

- Use NT functions to retrieve timestamps for events.

- Log kernel events with the current computer name.

- Don't hardcode variables types for sizeofs.

- Add type-checks for the data to be retrieved from the registry, and use default values in case the values do not exist or are invalid.

- Use ULONG_PTR to perform pointer arithmetics.

- Use string-safe functions for copy/concatenation.

- Cache EventLog source for eventlog service self-logging.

- Unlock the LogFile in LogfClearFile.

- Fix rounding in LogfAllocAndBuildNewRecord.

- Verify ELF handle validity in ElfrGetLogInformation.

- Implement IELF_HANDLE_rundown to correctly cleanup ELF handles when client apps shut down. Adapt also the parameter of ElfDeleteEventLogHandle for reusing it there.

- Update some code formatting.

CORE-11842 #resolve

I don't completely touch file.c as it contains most of my upcoming eventlog fixes...

    • -127
    • +169
    /trunk/reactos/base/services/eventlog/eventlog.c
    • -153
    • +185
    /trunk/reactos/base/services/eventlog/rpc.c
    • -71
    • +61
    /trunk/reactos/base/services/eventlog/eventlog.h
    • -274
    • +310
    /trunk/reactos/base/services/eventlog/file.c
    • -17
    • +26
    /trunk/reactos/base/services/eventlog/logport.c
[EVENTLOG]: Fix also ElfrChangeNotify here. Addendum to r72211. Must fix the build.

CORE-11839

[SDK:IDL]: Fix the event log RPC IDL file definitions:

- ElfrChangeNotify takes a IELF_HANDLE handle as its first parameter, not a pointer to it.

- Since we already use NT-like types (especially for USHORT variables), do the same for the other parameters (DWORD -> ULONG), and also use the Pxxx for pointers to xxx.

- Use Windows 2003 maximum size (0x3FFFF) for the event data to be written, instead of the Vista+ limit that is much smaller (0xF000). See also revisions r72207 and r72209.

CORE-11839 #resolve

[SDK]: Move some event log flags to the correct header (from winbase.h to winnt.h).

CORE-11839

    • -10
    • +1
    /trunk/reactos/sdk/include/psdk/winbase.h
[ADVAPI32_APITEST]: Addendum to r72207:

- Fix the tests so that they test what they have to test, on ReactOS & Windows 2k3/XP. (Note that here, ReactOS used the more restrained event size limitations of Vista+ compared to those of Win2k3. I choose to test, and will implement, the size limitations of Win2k3.)

- Choose a different name for the test such that it doesn't collide with the 'eventlog' test from advapi32_winetest.

CORE-11838 CORE-11839

[SHELL32]

- Get rid of the functions that handle guid pidls and move their implementation in CRegFolder.cpp.

    • -82
    • +0
    /trunk/reactos/dll/win32/shell32/folders.cpp
    • -291
    • +0
    /trunk/reactos/dll/win32/shell32/shlfolder.cpp
    • -26
    • +0
    /trunk/reactos/dll/win32/shell32/shfldr.h
[ADVAPI32_APITEST]: Add some supplemental tests for Winetests' Event Logging functions, testing different RPC limits related to the maximum size of the data buffer in events.

CORE-11838 CORE-11839

    • -0
    • +91
    /trunk/rostests/apitests/advapi32/eventlog.c
[SHELL32]

- Move CFSDropTarget to its own file.

    • -0
    • +1
    /trunk/reactos/dll/win32/shell32/CMakeLists.txt
[RAPPS}

Fix structural errors, fix some dead links, fix wrong lang inclusions, fix trailing spaces etcetc

Some entries are dead, like nirlauncher, watercolor, tahoma and audacity. Feel free to fix em. (@holiday till monday now, cya)

    • -2
    • +2
    /trunk/reactos/media/rapps/wordview.txt
    • -1
    • +1
    /trunk/reactos/media/rapps/winemono.txt
    • -1
    • +1
    /trunk/reactos/media/rapps/ccleaner.txt
    • -1
    • +1
    /trunk/reactos/media/rapps/kmeleon.txt
    • -1
    • +2
    /trunk/reactos/media/rapps/farmanager.txt
    • -2
    • +2
    /trunk/reactos/media/rapps/winmerge.txt
    • -3
    • +3
    /trunk/reactos/media/rapps/officeformatpack.txt
    • -2
    • +2
    /trunk/reactos/media/rapps/pptview.txt
    • -2
    • +2
    /trunk/reactos/media/rapps/unxutils.txt
    • -4
    • +6
    /trunk/reactos/media/rapps/audacity.txt
    • -2
    • +3
    /trunk/reactos/media/rapps/freemat.txt
  1. … 162 more files in changeset.
[NtUser]

- Get the right shift to pass through the keyboard subsystem. (WIP)

    • -0
    • +9
    /trunk/reactos/win32ss/user/ntuser/keyboard.c
[NtUser]

- Send Input Language Change System Character flag if font signature and system character is set.

    • -4
    • +13
    /trunk/reactos/win32ss/user/ntuser/msgqueue.c
[NtUser]

- If focus window null use active.

    • -1
    • +7
    /trunk/reactos/win32ss/user/ntuser/kbdlayout.c
[NtUser]

- Fix registry update when turning on/off keyboard layout hotkey and selecting. VK_RSHIFT (WIP).

    • -0
    • +1
    /trunk/reactos/win32ss/user/ntuser/sysparams.c
    • -1
    • +1
    /trunk/reactos/win32ss/user/ntuser/misc.c
    • -2
    • +0
    /trunk/reactos/win32ss/user/ntuser/main.c
Rewrite of many address.c functions to simplify locking and resolve deadlocks, special attention paid to whether AFD and lwIP have pointers to my data or not. Added deadlock resolution to MTSerialMutex acquisition macros. Better organization of TCP functions in source code. Removed unnecessary helper functions.

Reduced number of types of pending requests and the number of possible TCP states. Removed uselessly flawed IRPSP debugging array.