• last updated 16 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[RAPPS]

Fix Audacity/NIRLauncher/Tahoma and Watercolor entries.

    • -11
    • +9
    /trunk/reactos/media/rapps/nirlauncher.txt
    • -13
    • +6
    /trunk/reactos/media/rapps/tahoma.txt
    • -7
    • +5
    /trunk/reactos/media/rapps/audacity.txt
    • -6
    • +5
    /trunk/reactos/media/rapps/watercolor.txt
[TRANSLATIONS] Japanese translation of control panel applets by Katayama Hirofumi MZ. CORE-11882
    • -0
    • +3
    /trunk/reactos/dll/cpl/console/console.rc
    • -0
    • +216
    /trunk/reactos/dll/cpl/intl/lang/ja-JP.rc
    • -0
    • +154
    /trunk/reactos/dll/cpl/console/lang/ja-JP.rc
    • -0
    • +213
    /trunk/reactos/dll/cpl/usrmgr/lang/ja-JP.rc
    • -0
    • +3
    /trunk/reactos/dll/cpl/appwiz/appwiz.rc
    • -0
    • +267
    /trunk/reactos/dll/cpl/mmsys/lang/ja-JP.rc
    • -0
    • +3
    /trunk/reactos/dll/cpl/usrmgr/usrmgr.rc
    • -0
    • +37
    /trunk/reactos/dll/cpl/wined3dcfg/lang/ja-JP.rc
    • -0
    • +81
    /trunk/reactos/dll/cpl/appwiz/lang/ja-JP.rc
    • -0
    • +251
    /trunk/reactos/dll/cpl/input/lang/ja-JP.rc
[SHELL32]

- CMenuBand: Do not open the context menu on mouse down but on mouse up.

- Patch by Joachim Henze (reactosfanboy)

CORE-10830

[WIN32NT_APITEST] Add additional tests for NtUserCreateWindowEx by Sylvain Deverre. ROSTESTS-237 #resolve #comment Thanks!
[SHELL32]

- Use ExpandEnvironmentStringsW instead of PathUnExpandEnvStringsW in the pick icon dialog.

- Patch by Jared Smudde.

CORE-10962

[SHELL32]

- Fail to delete any file if one is invalid.

- Patch by andy-123

CORE-9959

    • -1
    • +14
    /trunk/reactos/dll/win32/shell32/shlfileop.cpp
[SHELL32]

- Show an error message when creating a directory fails.

- Patch by Jared Smudde

CORE-11661

    • -2
    • +2
    /trunk/reactos/dll/win32/shell32/lang/tr-TR.rc
    • -2
    • +2
    /trunk/reactos/dll/win32/shell32/lang/ko-KR.rc
    • -2
    • +2
    /trunk/reactos/dll/win32/shell32/lang/zh-TW.rc
    • -2
    • +2
    /trunk/reactos/dll/win32/shell32/lang/hu-HU.rc
    • -2
    • +2
    /trunk/reactos/dll/win32/shell32/lang/no-NO.rc
    • -2
    • +2
    /trunk/reactos/dll/win32/shell32/lang/sl-SI.rc
    • -2
    • +2
    /trunk/reactos/dll/win32/shell32/lang/he-IL.rc
    • -2
    • +2
    /trunk/reactos/dll/win32/shell32/lang/nl-NL.rc
    • -2
    • +2
    /trunk/reactos/dll/win32/shell32/lang/ro-RO.rc
    • -2
    • +2
    /trunk/reactos/dll/win32/shell32/lang/fi-FI.rc
    • -2
    • +2
    /trunk/reactos/dll/win32/shell32/lang/el-GR.rc
    • -2
    • +2
    /trunk/reactos/dll/win32/shell32/lang/ca-ES.rc
    • -2
    • +2
    /trunk/reactos/dll/win32/shell32/lang/de-DE.rc
    • -2
    • +2
    /trunk/reactos/dll/win32/shell32/lang/ru-RU.rc
    • -2
    • +2
    /trunk/reactos/dll/win32/shell32/lang/sv-SE.rc
  1. … 17 more files in changeset.
[SERVICES]

- Properly invalidate service handles when closing/freeing them

Dedicated to Hermès and any regression chaser. FalsePositives--

    • -2
    • +5
    /trunk/reactos/base/system/services/rpcserver.c
[NTOS/MM]

- Implement copy on write support in ARM3 page fault handler

CORE-8541 #resolve #comment committed in r72395

    • -0
    • +21
    /trunk/reactos/ntoskrnl/mm/ARM3/miarm.h
    • -21
    • +182
    /trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c
hid: hidparser: Fix for CORE-11538.

This commit fixes issue https://jira.reactos.org/browse/CORE-11538.

There were mistakes in buffer manipulation loops.

usb: hub: PDO: InternalDeviceControl can be called in DPC

As InternalDeviceControl can be called in DPC, we should avoid scanning

of parent's child list because it uses guarded mutex for

synchronization. So here we just adding new checking for safety and

removing isValidPDO() call.

usb: HUB: Fix DV's enhanced I/O validation issues

Added USBHUB_DispatchSystemControl stub

usb: HUB: Refactor power dispatcher, add remove synch

Refactored power dispatcher, added remove sychronization to avoid early

remove or call on removed device.

usb: HUB: FDO: Add IRP_MN_REMOVE_DEVICE handler

Added remove handler for usbhub FDO. When FDO is being removed, it

should delete all it's child PDOs. Because when PnP sends removes to

child devices they are still presented on the bus, so their handler will

not delete PDO.

    • -3
    • +59
    /branches/GSoC_2016/USB/drivers/usb/usbhub/fdo.c
usb: hub: Add remove synchronization

Added PDO/FDO remove synchronization to prevent device removal while

another IRP is in process.

As guidelines used ch6 of Walter Oney's "Programming the Microsoft

Windows Driver Model 2ed"

    • -1
    • +35
    /branches/GSoC_2016/USB/drivers/usb/usbhub/fdo.c
    • -2
    • +31
    /branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c
usb: HUB: Add PnP state tracking

Added PDO/FDO PnP state tracking, which is done according MSDN's

"State Transitions for PnP Devices" topic.

    • -7
    • +16
    /branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c
    • -1
    • +16
    /branches/GSoC_2016/USB/drivers/usb/usbhub/fdo.c
usb: hub: FDO: Handle surprise removal, fail stop request.

    • -2
    • +43
    /branches/GSoC_2016/USB/drivers/usb/usbhub/fdo.c
usb: hub: Add sychronization for FDO's child list access.

As FDO's child list is getting changed not from PnP dispatcher but

from DeviceStatusChangeThread(), we need to sychronize access for it.

    • -21
    • +41
    /branches/GSoC_2016/USB/drivers/usb/usbhub/fdo.c
Change CMakLists to use GuardedMutexes

usb: hub: PDO: Refernce interface before passing up

usb: hub: PDO: Added query-remove and query-cancel-remove handlers

On IRP_MN_QUERY_REMOVE_DEVICE we are freeing interface obtained from

bottom according MSDN we should check interfaces provided to top, but

here we are not checking. All checking will be performed in roothub

driver's IRP_MN_QUERY_REMOVE_DEVICE handler. This will make problems

when buggy driver is loaded on top of us. But we decided to keep source

simpler, because in any case buggy driver will prevent removing of

whole stack.

    • -2
    • +22
    /branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c
usb: hub: FDO: Removed dublicated functions and fields

FDO_QueryInterface() is unuseful beacuse we have more generic

QueryInterface() function which is able to replace all functionality

which provides FDO_QueryInterface().

Also we do not need to have two "USB_BUS_INTERFACE_USBDI_V2" fields in

"HUB_DEVICE_EXTENSION".

FDO_QueryInterface() was added in svn-rev 55983, and on review of that

commit I have found some copypasta issues and also tricks which was not

documented and marked by me as wrong. For example changing if

buscontext which was fixed in previous commits of this commit set.

    • -81
    • +0
    /branches/GSoC_2016/USB/drivers/usb/usbhub/misc.c
usb: hub: FDO: Fix USBHUB_FdoStartDevice()

Done fixes in cleanup also refactored code to be more readable and error

safe.

    • -38
    • +52
    /branches/GSoC_2016/USB/drivers/usb/usbhub/fdo.c
usb: libusb: hub: Refernce interface before passing up

Added InterfaceReference() calls before passing interface to upper

layer.

usb: hub: FDO: Fix CreateUsbChildDeviceObject()

There were code dublication on copy device interface, also after

copying interface, we should call InterfaceReference() routine of

interface, to prevent interface provider deleiton.

I have moved RtlCopyMemory() and InterfaceReference() to the end

of this function to siplify cleanup part, because otherwise we should

call InterfaceDereference() in cleanup part.

The changing of interface context seems wrong for me, let me give just

one example. When we are changing only buscontext, then when upper

layer calls interfaceDereference(), which is "thinking" that works with

it's buscontext, and tries to work with it using it's buscontext

pointer. So changing of buscontext is completely wrong.

    • -10
    • +4
    /branches/GSoC_2016/USB/drivers/usb/usbhub/fdo.c
usb: libusb: hub_controller: Fix PnP handler

In some cases our driver was changing IRP status in places where it

shouldn't.

usb: hub: Fix in USBHUB_DispatchPower

In case of FDO it should pass IRP down.

usb: hub: PDO: Fix in IRP_MN_QUERY_DEVICE_RELATIONS handler

I don't see the reason for allocation from NonPagedPool, also

the information field writing was wrong.

usb: hub: FDO: Fix PnP handling issues.

There is many cases where we should forward IRP instead of complete it.

    • -9
    • +17
    /branches/GSoC_2016/USB/drivers/usb/usbhub/fdo.c
usb: hub: FDO: Fix QueryInterface()

The status block of an IRP must be initialized before calling driver.