• last updated 13 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[WIN32K]

- Clean up after myself. Thanks, Giannis and Thomas.

    • -1
    • +0
    /trunk/reactos/win32ss/user/ntuser/class.c
    • -1
    • +1
    /trunk/reactos/win32ss/gdi/ntgdi/region.c
[WIN32K]: Replace some checks against UserGetDesktopWindow() and UserGetMessageWindow() by checks against FNID_xxx flags.

Fixes some FIXMEs in the code encountered while investigating the origin of "err: NtUserSetWindowPos bad window handle!" messages.

Reviewed by James Tabor.

CORE-12819

    • -6
    • +4
    /trunk/reactos/win32ss/user/ntuser/scrollbar.c
    • -1
    • +26
    /trunk/reactos/win32ss/user/ntuser/desktop.h
    • -12
    • +11
    /trunk/reactos/win32ss/user/ntuser/painting.c
    • -1
    • +1
    /trunk/reactos/win32ss/user/ntuser/scrollex.c
    • -7
    • +6
    /trunk/reactos/win32ss/user/ntuser/window.c
    • -2
    • +2
    /trunk/reactos/win32ss/user/ntuser/nonclient.c
    • -1
    • +1
    /trunk/reactos/win32ss/user/ntuser/desktop.c
    • -43
    • +31
    /trunk/reactos/win32ss/user/ntuser/winpos.c
    • -3
    • +1
    /trunk/reactos/win32ss/user/ntuser/message.c
[Win32SS]

- Implement Exclude Update Region, for testing. See CORE-12649.

    • -2
    • +2
    /trunk/reactos/win32ss/include/ntuser.h
    • -0
    • +75
    /trunk/reactos/win32ss/user/ntuser/painting.c
    • -11
    • +0
    /trunk/reactos/win32ss/user/ntuser/ntstubs.c
[Win32SS]

- Implement Fill Window, for testing.

    • -17
    • +0
    /trunk/reactos/win32ss/user/ntuser/ntstubs.c
    • -1
    • +2
    /trunk/reactos/win32ss/user/ntuser/userfuncs.h
    • -0
    • +88
    /trunk/reactos/win32ss/user/ntuser/painting.c
[NtGDI]

- Add function for NtUser.

    • -0
    • +25
    /trunk/reactos/win32ss/gdi/ntgdi/dcutil.c
[COMCTL32] -Fix several tests for the v6 button when themes are enabled.
[COMCTL32] -Fix a couple more button tests.
[COMCTL32_WINETEST] -Do not take into account the wine todos for the button tests.
[WIN32k] -Remove overzealous assertion that prevents boot.
    • -1
    • +1
    /trunk/reactos/win32ss/user/ntuser/class.c
[NTGDI]

- Check for zero rectangles in REGION_bXformRgn.

CORE-12204

    • -0
    • +4
    /trunk/reactos/win32ss/gdi/ntgdi/region.c
[COMCTL32]: Fix a few button tests.
[NTUSER]

- Prevent a null to be passed to UserDereferenceObject in UserSetCursorIconData. CID 1321971

- Make the status check in co_IntCallSentMessageCallback less useless. CID 1322014

- Prevent a null pointer dereference in a trace in IntCreateClass. CID 514617

    • -1
    • +3
    /trunk/reactos/win32ss/user/ntuser/class.c
    • -0
    • +1
    /trunk/reactos/win32ss/user/ntuser/callback.c
    • -3
    • +3
    /trunk/reactos/win32ss/user/ntuser/callproc.c
[NTGDI]

- Consider the return value from IntFillArc in IntArc. CID 1237076

- Remove an useless check in ENTRY_ReferenceEntryByHandle CID 731587

- Prevent an unlikely memory leak in PATH_WidenPath. CID 716634

- Minor cleanup.

    • -8
    • +0
    /trunk/reactos/win32ss/gdi/ntgdi/drawing.c
    • -0
    • +4
    /trunk/reactos/win32ss/gdi/ntgdi/path.c
    • -1
    • +0
    /trunk/reactos/win32ss/gdi/ntgdi/gdiobj.c
    • -9
    • +12
    /trunk/reactos/win32ss/gdi/ntgdi/arc.c
[GDI32]

- Fix a possible null pointer dereference in GetGlyphOutlineA. CID 513747

- SetDIBits should not accept null bitmap info at all. CID 513425

- Don't set the pdwResult pointer itself to null in TADC_GetAndSetDCDWord. CID 1321970

[NtUser]

- If an appication hangs other than suspended use Hung test to prevent locking the whole system. Quick fix for CORE-10078.

    • -1
    • +1
    /trunk/reactos/win32ss/user/ntuser/painting.c
[NtUser]

- Fix : Allow controls to receive non-client messages. See CORE-12771.

- See also https://bugs.winehq.org/show_bug.cgi?id=42503 .

    • -0
    • +2
    /trunk/reactos/win32ss/user/ntuser/nonclient.c
    • -0
    • +3
    /trunk/reactos/win32ss/user/ntuser/window.h
Fix build.
[COMCTL32] -Rename BUTTON_Paint to BUTTON_PaintWithTheme and use it in the newly added code for the v6 button.
    • -1
    • +70
    /trunk/reactos/dll/win32/comctl32/button.c
[COMCTL32] -Add a comment to clarify that there is no need to backport the #ifdef _USER32_ defines back to user32 (although they will work fine in user32).
[COMCTL32]: Copy button.c from user32, make the needed changes to make it compile and register it. This is the beginning of the v6 button. Remove the subclassing of the builtin button.
    • -0
    • +2
    /trunk/reactos/dll/win32/comctl32/commctrl.c
    • -0
    • +1403
    /trunk/reactos/dll/win32/comctl32/button.c
    • -1
    • +2
    /trunk/reactos/dll/win32/comctl32/comctl32.h
* Revert r73869 because wmi was mentioned nowhere in CORE-9111, nor in our tree restructure wiki, nor any developers discussions. This is the ReactOS trunk, not a branch.
    • -0
    • +7
    /trunk/reactos/boot/bootdata/hivesft.inf
    • -0
    • +1
    /trunk/reactos/base/services/CMakeLists.txt
    • -0
    • +12
    /trunk/reactos/boot/bootdata/hivesys.inf
    • -0
    • +5
    /trunk/reactos/dll/win32/CMakeLists.txt
  1. … 69 more files in changeset.
[WMI]: Gather all the user-mode components of WMI inside base/wmi/, as part of the ReactOS source code tree restructure. This gives an idea how this can be done for other ReactOS components.

CORE-9111

    • -0
    • +7
    /trunk/reactos/base/wmi/wbem_reg.inf
    • -0
    • +11
    /trunk/reactos/base/wmi/CMakeLists.txt
    • -12
    • +0
    /trunk/reactos/boot/bootdata/hivesys.inf
    • -5
    • +0
    /trunk/reactos/dll/win32/CMakeLists.txt
    • -0
    • +12
    /trunk/reactos/base/wmi/wmisvc/wmisvc_reg.inf
    • -7
    • +0
    /trunk/reactos/boot/bootdata/hivesft.inf
    • -1
    • +0
    /trunk/reactos/base/services/CMakeLists.txt
  1. … 150 more files in changeset.
[SECUR32]: As an interim step towards a proper NTLM implementation that is done by Samuel Serapion, I temporarily commit Wine's NTLM code layer around Samba's "ntlm_auth" utility. In addition I add the kerberos & negotiate stubs too.

This is not a problem on Wine, because they run on Linux distributions, most of which have Samba available. But this is not the case on Windows / ReactOS, so few adaptations were needed: in the dispatcher.c code, the fork_helper function was partially rewritten around CreateProcess to start the ntlm_auth utility (I try to use maximally the CRT to not have to rewrite other functions). This works great.

But then, to make this NTLM layer working on ReactOS, one has to find a Windows build of Samba. Here is one: http://smithii.com/samba . This is a Samba 3.0.23c build. You need to follow *exactly* the manual installation steps to make it work (actually, everything up to "Step 6" included, i.e. running smbsetup.cmd). This means in particular to copy Samba into C:\Program Files\samba, as this path is also hardcoded into the executables.

As the Wine's NTLM layer expects Samba 3.0.25+, I manually downgraded the expected version, which appears to still work nice for the needs of Office 2010 installation.

You can now play with it and try to install Office 2010.

CORE-12601 #comment Wine's NTLM layer committed in r73868 as an interim step towards a proper implementation.

CORE-12279

    • -0
    • +190
    /trunk/reactos/dll/win32/secur32/wine/base64_codec.c
    • -0
    • +14
    /trunk/reactos/dll/win32/secur32/wine/util.h
    • -0
    • +77
    /trunk/reactos/dll/win32/secur32/wine/hmac_md5.c
    • -3
    • +60
    /trunk/reactos/dll/win32/secur32/sspi.c
    • -0
    • +16
    /trunk/reactos/dll/win32/secur32/wine/dispatcher.h
    • -0
    • +9
    /trunk/reactos/dll/win32/secur32/wine/wine_supp.h
    • -0
    • +525
    /trunk/reactos/dll/win32/secur32/wine/negotiate.c
    • -0
    • +315
    /trunk/reactos/dll/win32/secur32/wine/kerberos.c
    • -0
    • +7
    /trunk/reactos/dll/win32/secur32/wine/kerberos.h
    • -0
    • +116
    /trunk/reactos/dll/win32/secur32/wine/ntlm.h
    • -0
    • +2064
    /trunk/reactos/dll/win32/secur32/wine/ntlm.c
    • -1
    • +8
    /trunk/reactos/dll/win32/secur32/CMakeLists.txt
    • -0
    • +7
    /trunk/reactos/dll/win32/secur32/wine/negotiate.h
  1. … 5 more files in changeset.
[MOFCOMP]: Add the MOF compiler stub from Wine, which allows fixing the very last step in the installation of Office 2010.

CORE-12811 #resolve

CORE-12279

    • -0
    • +29
    /trunk/reactos/base/applications/cmdutils/mofcomp/mofcomp.c
[SHLWAPI]: Stub SHPropertyBag_WriteLONG and SHPropertyBag_WriteStr. Patch by Jared Smudde. CORE-12805
    • -0
    • +40
    /trunk/reactos/dll/win32/shlwapi/ordinal.c
    • -2
    • +2
    /trunk/reactos/dll/win32/shlwapi/shlwapi.spec
[SHELL32] -Cleanup CFSFolder::_LoadDynamicDropTargetHandlerForKey. Inspired by patch by Victor Martinez Calvo. CORE-12799. CID 1401249
[MSGINA] -Make ShellIsFriendlyUIActive export a non fatal stub. CORE-12805
[MSWSOCK]

- Eliminate dead code in NSP_LookupServiceNextW. Patch by Víctor Martínez Calvo. CID 1400942

CORE-12806 #resolve

    • -1
    • +1
    /trunk/reactos/dll/win32/mswsock/CMakeLists.txt
    • -6
    • +5
    /trunk/reactos/dll/win32/mswsock/nsplookup.c
[USER32][UXTHEME]

- Make API hooks type-safe. Fixes stack pointer corruption when calling ThemeGetScrollInfo. Powered by /RTC1

    • -2
    • +2
    /trunk/reactos/dll/win32/uxtheme/themehooks.c
    • -12
    • +24
    /trunk/reactos/sdk/include/reactos/undocuser.h
[WS2_32]

- Re-apply null termination fix in GetProtoGetNextEnt, which was lost in ws2_32_new work. CID 716700

CORE-11218

    • -3
    • +4
    /trunk/reactos/dll/win32/ws2_32/src/getproto.c