• last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[CABMAN]

- Fix leaks in ExtractFile and avoid double frees from failure cases of AddFile. Patch by Serge Gautherie.

CORE-7307 #resolve

    • -3
    • +22
    /trunk/reactos/sdk/tools/cabman/cabinet.cxx
[ACPI]

- Ensure null termination of the method name passed to AcpiEvaluateObject in Bus_PDO_EvalMethod. Spotted by ReactCoder.

CORE-13068 #resolve

    • -1
    • +6
    /trunk/reactos/drivers/bus/acpi/eval.c
[CRT] remove a self assignment. CORE-8215 #resolve
    • -1
    • +0
    /trunk/reactos/sdk/lib/crt/stdlib/qsort.c
[UXTHEME] DrawNCPreview(): Fix copypasta
    • -1
    • +1
    /trunk/reactos/dll/win32/uxtheme/nonclient.c
[SPOOLSS]

Implement the undocumented AlignRpcPtr and UndoAlignRpcPtr functions used by many Rpc* functions in spoolsv according to traced callchains.

I could reverse engineer them entirely using rohitab.com's API Monitor and black-box testing.

I also add documented tests covering all cases I found out. We now pass 17/17 tests on Windows Server 2003 and ReactOS.

Also const-ify a parameter in PackStrings.

    • -0
    • +84
    /trunk/rostests/apitests/spoolss/AlignRpcPtr.c
[NTOS:OB]

- Move device map code into a separate file.

- Create and inherit device maps instead of using a single global device map.

    • -0
    • +227
    /trunk/reactos/ntoskrnl/ob/devicemap.c
    • -101
    • +5
    /trunk/reactos/ntoskrnl/ob/obname.c
[SETUPAPI]

Implement CMP_GetServerSideDeviceInstallFlags().

    • -18
    • +80
    /trunk/reactos/dll/win32/setupapi/cfgmgr.c
    • -1
    • +1
    /trunk/reactos/dll/win32/setupapi/setupapi.spec
[UMPNPMGR]

Implement most of PNP_GetServerSideDeviceInstallFlags().

[RSHELL] -Link to shellbars and export CBandSite_CreateInstance and CBandSiteMenu_CreateInstance.

[SHELLMENU] -Remove second copy of CBandSite. It was originally added here to be tested in windows but now it is hosted in a proper static link.

    • -2
    • +2
    /trunk/reactos/base/shell/rshell/CMakeLists.txt
    • -4
    • +46
    /trunk/reactos/base/shell/rshell/misc.cpp
    • -0
    • +2
    /trunk/reactos/base/shell/rshell/rshell.spec
    • -1
    • +0
    /trunk/reactos/dll/win32/shell32/shell32.cpp
[BROWSEUI] -Move the following classes to a new static lib called shellbars: CBandSite, CBandSiteMenu, CBaseBar, CSHEnumClassesOfCategories.

- This will be linked to rshell in order to implement support for additional toolbars in the taskbar as well as floating toolbars.

- In the future more classes will be added in this static lib including: CISFBand (which implements a dockable toolbar that shows the contents of a shell folder), CQuickLinks (a special CISFBand), CDeskBarApp (a special CBaseBar that implements the floating host for toolbars) and perhaps more.

    • -558
    • +0
    /trunk/reactos/dll/win32/browseui/basebar.cpp
    • -150
    • +0
    /trunk/reactos/dll/win32/browseui/bandsite.h
  1. /trunk/reactos/dll/win32/browseui/shellbars
    • -335
    • +0
    /trunk/reactos/dll/win32/browseui/comcat.cpp
    • -107
    • +8
    /trunk/reactos/dll/win32/browseui/browseui.h
    • -831
    • +0
    /trunk/reactos/dll/win32/browseui/bandsite.cpp
    • -0
    • +100
    /trunk/reactos/dll/win32/browseui/browseui.cpp
  2. … 4 more files in changeset.
[NTOS:MM]

Addendum to r74263:

- Really only warn once in MmLockPageableDataSection/MmUnlockPageableImageSection, not on every 256th call

    • -2
    • +2
    /trunk/reactos/ntoskrnl/mm/ARM3/drvmgmt.c
[SCHEDSVC]

Add missing file. Sorry!

    • -0
    • +347
    /trunk/reactos/base/services/schedsvc/job.c
[UMPNPMGR]

Use SendMessageW() to broadcast WM_DEVICECHANGE messages because BroadcastSystemMessageW() does not seem to work.

    • -21
    • +24
    /trunk/reactos/base/services/umpnpmgr/umpnpmgr.c
[SCHEDSVC]

Implement storing and loading of jobs in the registry.

    • -24
    • +25
    /trunk/reactos/base/services/schedsvc/rpcserver.c
[GDI32_APITEST] Add test for AddFontMemResourceEx. Uses PanosePitchTest.ttf from Katayama Hirofumi MZ. CORE-13046 CORE-13038 CORE-13053
    • binary
    /trunk/rostests/apitests/gdi32/PanosePitchTest.ttf
    • -0
    • +2
    /trunk/rostests/apitests/gdi32/testlist.c
    • -0
    • +191
    /trunk/rostests/apitests/gdi32/AddFontMemResourceEx.c
[WIN32SS] Addendum to r74285, actually leak the pointer used by Freetype, so that when it is accessed later, we have not freed it.
    • -1
    • +9
    /trunk/reactos/win32ss/gdi/ntgdi/freetype.c
[WIN32SS] Implement NtGdiAddFontMemResourceEx and NtGdiRemoveFontMemResourceEx. CORE-13046
    • -0
    • +65
    /trunk/reactos/win32ss/gdi/ntgdi/font.c
    • -0
    • +64
    /trunk/reactos/win32ss/gdi/ntgdi/font.h
    • -0
    • +2
    /trunk/reactos/win32ss/gdi/ntgdi/init.c
    • -0
    • +2
    /trunk/reactos/win32ss/gdi/ntgdi/text.h
    • -0
    • +3
    /trunk/reactos/win32ss/user/ntuser/win32.h
    • -55
    • +149
    /trunk/reactos/win32ss/gdi/ntgdi/freetype.c
    • -28
    • +0
    /trunk/reactos/win32ss/gdi/eng/stubs.c
[LIBUSB]

- Silence some debug prints

[NTOS:IO]

- Make debug prints about IopOpenRegistryKeyEx failure consistent

    • -6
    • +10
    /trunk/reactos/ntoskrnl/io/iomgr/driver.c
    • -5
    • +10
    /trunk/reactos/ntoskrnl/io/pnpmgr/pnpinit.c
    • -2
    • +4
    /trunk/reactos/ntoskrnl/io/pnpmgr/pnproot.c
[WIN32SS] Use Panose info from freetype. Patch by Katayama Hirofumi MZ. CORE-13038
    • -1
    • +9
    /trunk/reactos/win32ss/gdi/ntgdi/freetype.c
[USETUP] Improve CJK Font Substitutes settings. Patch by Katayama Hirofumi MZ. CORE-12956
    • -0
    • +11
    /trunk/reactos/base/setup/usetup/muifonts.h
[GDI32] -Implement GdiDrawStream.

- This is based on the prototype I found in a sample app on codeproject. I don't really know what the unknown parameters are for but I haven't found anything yet passing different values. Almost all of the code is from the drawing code from uxtheme with the only difference that in uxtheme UXTHEME_DrawImageBackground reads several values from the theme but his takes them as parameters. I don't see any reason to spend time understanding what these are for. I found what the draw flags are for by passing different values in the test application and trying to replicate the parameters that UXTHEME_DrawImageBackground need. I decided to keep the naming like that since it is almost verbatim wine code. At some point it should be moved to win32k however.

CORE-4420

    • -3
    • +428
    /trunk/reactos/win32ss/gdi/gdi32/misc/misc.c
[SHSVCS] -Add the module that should host the theme service. Implement ThemeWaitForServiceReady and ThemeWatchForStart. These are already called by our msgina and are responsible for starting themes in the session.
    • -0
    • +177
    /trunk/reactos/base/services/shsvcs/thmserver.c
    • -0
    • +16
    /trunk/reactos/base/services/shsvcs/shsvcs.spec
    • -1
    • +1
    /trunk/reactos/boot/bootdata/hivesft.inf
    • -1
    • +3
    /trunk/reactos/boot/bootdata/hivesys.inf
    • -0
    • +5
    /trunk/reactos/base/services/shsvcs/shsvcs.rc
    • -0
    • +60
    /trunk/reactos/base/services/shsvcs/shsvcs.c
    • -0
    • +15
    /trunk/reactos/base/services/shsvcs/CMakeLists.txt
    • -1
    • +1
    /trunk/reactos/base/services/CMakeLists.txt
[WIN32K] -Implement NtUserCalcMenuBar.
    • -14
    • +0
    /trunk/reactos/win32ss/user/ntuser/ntstubs.c
    • -0
    • +48
    /trunk/reactos/win32ss/user/ntuser/menu.c
[NTOS:IO]

- Remove broken casts

    • -4
    • +5
    /trunk/reactos/ntoskrnl/io/iomgr/rawfs.c
    • -1
    • +1
    /trunk/reactos/ntoskrnl/io/iomgr/irp.c
[WIN32K] -MENU_TrackMouseMenuBar: Use IntGetSystemMenu instead of get_win_sys_menu because the system menu have not been initialized yet (it is delay initialized). CORE-12801
    • -1
    • +1
    /trunk/reactos/win32ss/user/ntuser/menu.c
[WIN32K] -NtGdiGetRegionData: prgn->rdh.nRgnSize is the size of kernel mode buffer for the region. After copying it to the caller we should set lpRgnData->rdh.nRgnSize to cjRects.
    • -0
    • +1
    /trunk/reactos/win32ss/gdi/ntgdi/region.c
[EXPLORER] Add modern start menu bitmap by Jared Smudde
    • binary
    /trunk/reactos/base/shell/explorer/res/bmp/170.bmp
    • -1
    • +1
    /trunk/reactos/base/shell/explorer/explorer.rc
[NTOS]

- Silence some more debug prints

    • -1
    • +0
    /trunk/reactos/ntoskrnl/io/pnpmgr/pnpinit.c
    • -1
    • +1
    /trunk/reactos/ntoskrnl/config/cmsysini.c
    • -2
    • +5
    /trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c
[SCHEDSVC]

Implement NetsJobEnum.

    • -2
    • +119
    /trunk/reactos/base/services/schedsvc/rpcserver.c