• last updated 33 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[RTL]

- In Wait_thread_proc, prioritize the cancel event over the wait object. This avoids executing the callback again after RtlDeregisterWait has been called.

Fixes ThemeStartCallback being called twice, causing a double free.

CORE-13074 #resolve

[SCHEDSVC]

Insert a job into the start list when it is loaded or added. Remove it from the start list when it gets deleted. The start list is sorted by start time.

[WIN32SS] Addendum to r74312 and r74309, fix some bad memory leaks. CORE-10876

Thanks Giannis and Thomas :)

    • -1
    • +3
    /trunk/reactos/win32ss/gdi/ntgdi/freetype.c
[SCHEDSVC]

Calculate the next start time of a job and store it in the job object. DaysOfMonth and DaysOfWeek are not taken into account yet.

[SHELLUTILS.H]

- Remove the ShellObjectCreator templates that allowed the caller to pass an arbitrary interface pointer. Leaving only the templates that take an void ** ppv parameter means that the callers are forced to use IID_PPV_ARG. This makes it less likely to have a pointer to an wrong interface.

- Fix the callers to always use IID_PPV_ARG.

- Rewrite the ShellObjectCreator templates to create the objects using the ATL CreateInstance thus allowing internal ATL methods to be called.

[BROWSEUI]

-Let CBandSite_CreateInstance take an additional parameter for the outer object since CBandSite is aggregatable. Create the object using the ATL creator class.

    • -1
    • +1
    /trunk/reactos/dll/win32/shell32/shell32.cpp
    • -202
    • +62
    /trunk/reactos/sdk/include/reactos/shellutils.h
    • -1
    • +1
    /trunk/reactos/dll/win32/shell32/CDefView.cpp
    • -1
    • +1
    /trunk/reactos/base/shell/rshell/rshell.spec
    • -2
    • +0
    /trunk/reactos/base/shell/rshell/misc.cpp
[WIN32SS] Fix charset in font enumeration. Patch by Katayama Hirofumi MZ. CORE-10876
    • -2
    • +0
    /trunk/reactos/win32ss/gdi/ntgdi/freetype.c
[WIN32SS] Initial fixes for localized font enumeration. Patch by Katayama Hirofumi MZ. CORE-10876
    • -61
    • +96
    /trunk/reactos/win32ss/gdi/ntgdi/freetype.c
[EXPLORER] Addendum to r74307: Fix copypasta CORE-11498
    • -7
    • +7
    /trunk/reactos/base/shell/explorer/trayprop.cpp
[WIN32SS] Count number of faces added instead of fonts in IntGdiLoadFontsFromMemory.

This fixes displaying embedded fonts in firefox.

CORE-13046 CORE-13056

    • -9
    • +10
    /trunk/reactos/win32ss/gdi/ntgdi/freetype.c
[WIN32SS] Cleanup fonts at process destruction + implement font memory reference counting.

Thanks to everyone involved in reviewing this code! (See CR-112)

CORE-13056

    • -0
    • +2
    /trunk/reactos/win32ss/gdi/ntgdi/init.c
    • binary
    /trunk/rostests/apitests/gdi32/Shadows_Into_Light.ttf
    • -0
    • +1
    /trunk/reactos/win32ss/gdi/ntgdi/text.h
    • -2
    • +1
    /trunk/reactos/win32ss/gdi/ntgdi/font.h
    • -61
    • +250
    /trunk/reactos/win32ss/gdi/ntgdi/freetype.c
    • -2
    • +10
    /trunk/reactos/win32ss/gdi/eng/engobjects.h
    • binary
    /trunk/rostests/apitests/gdi32/TTCTestV.ttc
[WIN32SS] Add missing \n to DPRINT1 Spotted by Thomas Schneider.
    • -1
    • +1
    /trunk/reactos/win32ss/gdi/eng/pdevobj.c
[EXPLORER] start reworking some code for loading/saving settings implementation CORE-11498

- Rename the settings structure to something more meaningful for using it for all taskbar related settings

- define some default settings

- check checkboxes with settings values in the properties window

- move saving the settings to an own function which will be implemented later

    • -3
    • +3
    /trunk/reactos/base/shell/explorer/trayntfy.cpp
    • -5
    • +14
    /trunk/reactos/base/shell/explorer/precomp.h
    • -1
    • +1
    /trunk/reactos/base/shell/explorer/explorer.cpp
    • -4
    • +17
    /trunk/reactos/base/shell/explorer/settings.cpp
    • -4
    • +10
    /trunk/reactos/base/shell/explorer/trayprop.cpp
[AT]

Improve the time parser to handle 12-hour and 24-hour formats correctly.

[NTOS:KE]

- Gracefully handle page faults during V86 code execution. This is a bit of a hack because with our limited use of V86 code it is unclear how a page fault can even occur.

CORE-12993 #resolve

    • -3
    • +44
    /trunk/reactos/ntoskrnl/vdm/vdmexec.c
    • -1
    • +13
    /trunk/reactos/ntoskrnl/ke/i386/traphdlr.c
[NTOS:KE]

- Make decoding of the error code more obvious in KiTrap0EHandler

- Avoid or make explicit some signed/unsigned conversions

    • -17
    • +24
    /trunk/reactos/ntoskrnl/ke/i386/traphdlr.c
[USBSTOR]

- Avoid MDL leak in USBSTOR_SendIrp. Patch by Lesan Ilie.

CORE-13061 #resolve

    • -0
    • +1
    /trunk/reactos/drivers/usb/usbstor/pdo.c
[HIDCLASS]

Patch by Lesan Ilie:

- Avoid over-allocating the DEVICE_RELATIONS structure in HidClassPDO_CreatePDO

- Allocate device relations from paged pool

CORE-13052 #resolve

    • -2
    • +2
    /trunk/reactos/drivers/hid/hidclass/pdo.c
[CABMAN]

- Fix leaks in ExtractFile and avoid double frees from failure cases of AddFile. Patch by Serge Gautherie.

CORE-7307 #resolve

    • -3
    • +22
    /trunk/reactos/sdk/tools/cabman/cabinet.cxx
[ACPI]

- Ensure null termination of the method name passed to AcpiEvaluateObject in Bus_PDO_EvalMethod. Spotted by ReactCoder.

CORE-13068 #resolve

    • -1
    • +6
    /trunk/reactos/drivers/bus/acpi/eval.c
[CRT] remove a self assignment. CORE-8215 #resolve
    • -1
    • +0
    /trunk/reactos/sdk/lib/crt/stdlib/qsort.c
[UXTHEME] DrawNCPreview(): Fix copypasta
    • -1
    • +1
    /trunk/reactos/dll/win32/uxtheme/nonclient.c
[SPOOLSS]

Implement the undocumented AlignRpcPtr and UndoAlignRpcPtr functions used by many Rpc* functions in spoolsv according to traced callchains.

I could reverse engineer them entirely using rohitab.com's API Monitor and black-box testing.

I also add documented tests covering all cases I found out. We now pass 17/17 tests on Windows Server 2003 and ReactOS.

Also const-ify a parameter in PackStrings.

    • -0
    • +84
    /trunk/rostests/apitests/spoolss/AlignRpcPtr.c
[NTOS:OB]

- Move device map code into a separate file.

- Create and inherit device maps instead of using a single global device map.

    • -0
    • +227
    /trunk/reactos/ntoskrnl/ob/devicemap.c
    • -101
    • +5
    /trunk/reactos/ntoskrnl/ob/obname.c
[SETUPAPI]

Implement CMP_GetServerSideDeviceInstallFlags().

    • -18
    • +80
    /trunk/reactos/dll/win32/setupapi/cfgmgr.c
    • -1
    • +1
    /trunk/reactos/dll/win32/setupapi/setupapi.spec
[UMPNPMGR]

Implement most of PNP_GetServerSideDeviceInstallFlags().

[RSHELL] -Link to shellbars and export CBandSite_CreateInstance and CBandSiteMenu_CreateInstance.

[SHELLMENU] -Remove second copy of CBandSite. It was originally added here to be tested in windows but now it is hosted in a proper static link.

    • -2
    • +2
    /trunk/reactos/base/shell/rshell/CMakeLists.txt
    • -4
    • +46
    /trunk/reactos/base/shell/rshell/misc.cpp
    • -0
    • +2
    /trunk/reactos/base/shell/rshell/rshell.spec
    • -1
    • +0
    /trunk/reactos/dll/win32/shell32/shell32.cpp
[BROWSEUI] -Move the following classes to a new static lib called shellbars: CBandSite, CBandSiteMenu, CBaseBar, CSHEnumClassesOfCategories.

- This will be linked to rshell in order to implement support for additional toolbars in the taskbar as well as floating toolbars.

- In the future more classes will be added in this static lib including: CISFBand (which implements a dockable toolbar that shows the contents of a shell folder), CQuickLinks (a special CISFBand), CDeskBarApp (a special CBaseBar that implements the floating host for toolbars) and perhaps more.

    • -558
    • +0
    /trunk/reactos/dll/win32/browseui/basebar.cpp
    • -150
    • +0
    /trunk/reactos/dll/win32/browseui/bandsite.h
  1. /trunk/reactos/dll/win32/browseui/shellbars
    • -335
    • +0
    /trunk/reactos/dll/win32/browseui/comcat.cpp
    • -107
    • +8
    /trunk/reactos/dll/win32/browseui/browseui.h
    • -831
    • +0
    /trunk/reactos/dll/win32/browseui/bandsite.cpp
    • -0
    • +100
    /trunk/reactos/dll/win32/browseui/browseui.cpp
  2. … 4 more files in changeset.
[NTOS:MM]

Addendum to r74263:

- Really only warn once in MmLockPageableDataSection/MmUnlockPageableImageSection, not on every 256th call

    • -2
    • +2
    /trunk/reactos/ntoskrnl/mm/ARM3/drvmgmt.c
[SCHEDSVC]

Add missing file. Sorry!

    • -0
    • +347
    /trunk/reactos/base/services/schedsvc/job.c
[UMPNPMGR]

Use SendMessageW() to broadcast WM_DEVICECHANGE messages because BroadcastSystemMessageW() does not seem to work.

    • -21
    • +24
    /trunk/reactos/base/services/umpnpmgr/umpnpmgr.c