• last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
More build fixes.
Fix build.
[DESK.CPL] -Implement opening msstyles files.
    • -0
    • +1
    /trunk/reactos/dll/cpl/desk/appearance.h
    • -10
    • +57
    /trunk/reactos/dll/cpl/desk/desk.c
    • -10
    • +18
    /trunk/reactos/dll/cpl/desk/theme.c
    • -2
    • +42
    /trunk/reactos/dll/cpl/desk/appearance.c
[EXPLORER] Some style suggestions by Mark Jansen. Thanks
    • -12
    • +12
    /trunk/reactos/base/shell/explorer/settings.cpp
[CONSOLE.CPL]: Fix the console window preview:

- turn it into a custom control;

- supports dynamic preview area depending on the actual current monitor screen resolution;

(note that on ReactOS, the WM_DISPLAYCHANGE is not correctly sent, see CORE-13212, therefore this functionality won't show up yet)

- supports correct rescaling of the console preview drawn in the preview area;

- supports dependence of the console preview with respect to the chosen font character dimensions.

The code is there, it may be a little bit improved in the future.

CORE-13196 #resolve

Other additions:

- Add a few space between the console preview text window border and the text sample;

- PaintText and PaintStaticControls do not need to return anything.

    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/ro-RO.rc
    • -12
    • +9
    /trunk/reactos/dll/cpl/console/colors.c
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/id-ID.rc
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/cs-CZ.rc
    • -4
    • +9
    /trunk/reactos/dll/cpl/console/console.h
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/bg-BG.rc
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/ja-JP.rc
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/ru-RU.rc
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/de-DE.rc
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/tr-TR.rc
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/zh-CN.rc
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/no-NO.rc
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/pt-BR.rc
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/es-ES.rc
  1. … 11 more files in changeset.
[CONSOLE.CPL]: Minor modifications:

- Use "hDlg" (as done in the rest of the code) instead of "hwndDlg";

- Refresh the console window preview whenever a dimension or a position was changed.

    • -62
    • +77
    /trunk/reactos/dll/cpl/console/layout.c
[CONSOLE.CPL]: Simplify the color selection code by factorizing common parts.
    • -114
    • +49
    /trunk/reactos/dll/cpl/console/colors.c
[EXPLORER] Addendum to r74500. Those 2 commits belong to CORE-11498
    • -2
    • +2
    /trunk/reactos/base/shell/explorer/settings.cpp
[EXPLORER]

- Load and save "Lock Taskbar", "Hide inactive icons", and "Group similar taskbar buttons". Verified on Win2k3 via "Nirsoft RegFromApp".

- use a loader function for registry values.

- save the "show seconds" setting together with the other explorer settings instead of a ROS specific key.

- Add some documentation comments.

    • -0
    • +4
    /trunk/reactos/base/shell/explorer/precomp.h
    • -0
    • +7
    /trunk/reactos/base/shell/explorer/trayprop.cpp
    • -21
    • +47
    /trunk/reactos/base/shell/explorer/settings.cpp
[WIN32SS] Fix font names not including style info (Bold etc). Patch by Katayama Hirofumi MZ. CORE-12179 #comment Thanks!
    • -59
    • +57
    /trunk/reactos/win32ss/gdi/ntgdi/freetype.c
[SHELL32]

- Avoid leaking the list items on destruction of CEnumIDListBase

CORE-13194

[USER32]

- Avoid a memory leak in User32EnumWindows in case the window count is zero.

CORE-13194

[NTOS:IO]

- Use pool tagging

    • -5
    • +9
    /trunk/reactos/ntoskrnl/io/iomgr/driver.c
[NTOS]: Addendums to r74491 and r74493:

- Free the FullServiceName buffer if PnpRootCreateDevice failed (erroneously committed in r74494, see pnpmgr.c line 1080);

- No need to close InstanceHandle if the IopCreateDeviceKeyPath call failed, since in this case the registry handle wasn't opened. CORE-13207

- Don't assert on Buffer allocation but return a proper failure code in case of failure. CORE-13208

These are suggestions from Serge Gautherie + Lesan Ilie.

- Add a forgotten ZwClose call in the success code path of IopCreateDeviceKeyPath in IopQueryDeviceCapabilities (by me).

    • -1
    • +4
    /trunk/reactos/ntoskrnl/io/iomgr/driver.c
    • -1
    • +2
    /trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c
[NTOS]: Code formatting + free the memory in the reverse order from how it was allocated.
    • -9
    • +10
    /trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c
[NTOS]: Capture the counted BaseDllName unicode string into a local NULL-terminated buffer before calling wcsrchr on it (actually I think it would be better to create & use a similar function that takes counted strings in input).

Also use 'L' prefix for wide characters and UNICODE_NULL for string terminator.

Patch by Lesan Ilie.

CORE-13208 #resolve

    • -4
    • +11
    /trunk/reactos/ntoskrnl/io/iomgr/driver.c
[NTOS]: Code formatting changes only.
    • -14
    • +8
    /trunk/reactos/ntoskrnl/io/iomgr/driver.c
[NTOS]: Fix a potential memory leak.

- If one of the ZwSetValueKey function fails, 'Node->ServiceName.Buffer' is leaked.

- Also use 'L' prefix for wide characters.

Patch by Lesan Ilie, thanks!

- Use "P(C)WSTR" instead of win32 "LP(C)WSTR" string pointer types (by me).

CORE-13207 #resolve

    • -4
    • +5
    /trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c
[NTDLL]

- Implement user-mode version of RtlWalkFrameChain (mostly as a copy of the kernel version). Now RtlCaptureStackBackTrace actually, you know, captures stack back-traces.

    • -16
    • +107
    /trunk/reactos/dll/ntdll/rtl/libsupp.c
[KMTESTS:RTL]

- Add a test for RtlWalkFrameChain and RtlCaptureStackBackTrace

    • -0
    • +2
    /trunk/rostests/kmtests/kmtest/testlist.c
    • -0
    • +1
    /trunk/rostests/kmtests/CMakeLists.txt
    • -0
    • +136
    /trunk/rostests/kmtests/rtl/RtlStack.c
[INTL]

- Get rid of the individual getter funtions. Use GetSelectedComboBoxIndex for all CBS_DROPDOWNLIST comboboxes and GetSelectedComboBoxText for all CBS_DROPDOWN comboboxes.

- Check the relevant settings only!

- Rename SetXxxSettings to GetXxxSettings because it is a getter function.

- Handle the bogus WM_COMMAND/EN_CHANGE message that is sent when the IDC_SECONDYEAR_EDIT edit control is initialized. Controls should NEVER send notifications when they are modified programmatically! :-/

    • -55
    • +42
    /trunk/reactos/dll/cpl/intl/time.c
    • -23
    • +26
    /trunk/reactos/dll/cpl/intl/date.c
    • -163
    • +72
    /trunk/reactos/dll/cpl/intl/numbers.c
    • -123
    • +59
    /trunk/reactos/dll/cpl/intl/currency.c
[INTL]

Changed locale options doesn't reload correctly before next reboot.

- Added SetNumberSetting, SetCurrencySetting, SetDateSetting and SetTimeSetting functions to get and check values.

- Don't directly change pGlobalData.

- Post WM_WININICHANGE after all changes have been applied.

Based on a patch by Katayama Hirofumi MZ.

CORE-10170

    • -25
    • +40
    /trunk/reactos/dll/cpl/intl/time.c
    • -48
    • +57
    /trunk/reactos/dll/cpl/intl/date.c
    • -45
    • +62
    /trunk/reactos/dll/cpl/intl/currency.c
    • -50
    • +68
    /trunk/reactos/dll/cpl/intl/numbers.c
    • -0
    • +3
    /trunk/reactos/dll/cpl/intl/generalp.c
[WIN32K:NTGDI]

- Avoid using floating point operations in kernel mode.

CORE-10893

    • -1
    • +1
    /trunk/reactos/win32ss/gdi/ntgdi/brush.h
    • -1
    • +1
    /trunk/reactos/win32ss/gdi/ntgdi/pen.c
    • -1
    • +1
    /trunk/reactos/win32ss/gdi/ntgdi/stockobj.c
[MMSYS]

- Simplify code by using windowsx.h. Patch by Katayama Hirofumi MZ.

CORE-12903

    • -20
    • +25
    /trunk/reactos/dll/cpl/mmsys/sounds.c
[MMSYS]

- Make browse dialog title and filter localizable. Based on a patch by Katayama Hirofumi MZ.

CORE-12903

    • -2
    • +4
    /trunk/reactos/dll/cpl/mmsys/lang/ru-RU.rc
    • -2
    • +4
    /trunk/reactos/dll/cpl/mmsys/lang/cs-CZ.rc
    • -2
    • +4
    /trunk/reactos/dll/cpl/mmsys/lang/sq-AL.rc
    • -2
    • +4
    /trunk/reactos/dll/cpl/mmsys/lang/no-NO.rc
    • -0
    • +2
    /trunk/reactos/dll/cpl/mmsys/resource.h
    • -2
    • +4
    /trunk/reactos/dll/cpl/mmsys/lang/ja-JP.rc
    • -2
    • +4
    /trunk/reactos/dll/cpl/mmsys/lang/pt-BR.rc
    • -2
    • +4
    /trunk/reactos/dll/cpl/mmsys/lang/nl-NL.rc
    • -2
    • +4
    /trunk/reactos/dll/cpl/mmsys/lang/de-DE.rc
    • -2
    • +4
    /trunk/reactos/dll/cpl/mmsys/lang/sk-SK.rc
    • -2
    • +4
    /trunk/reactos/dll/cpl/mmsys/lang/he-IL.rc
    • -2
    • +4
    /trunk/reactos/dll/cpl/mmsys/lang/tr-TR.rc
    • -2
    • +4
    /trunk/reactos/dll/cpl/mmsys/lang/pl-PL.rc
    • -2
    • +4
    /trunk/reactos/dll/cpl/mmsys/lang/es-ES.rc
    • -2
    • +4
    /trunk/reactos/dll/cpl/mmsys/lang/fr-FR.rc
  1. … 10 more files in changeset.
[MMSYS]

- Pass byte counts to RegQueryValueEx instead of character counts. Based on a patch by Katayama Hirofumi MZ.

CORE-12903

    • -21
    • +21
    /trunk/reactos/dll/cpl/mmsys/sounds.c
[MMSYS]

Patch by Katayama Hirofumi MZ:

- Use _countof where appropriate

- Prefer sizeof(variable) to sizeof(TYPE)

CORE-12903

    • -16
    • +16
    /trunk/reactos/dll/cpl/mmsys/sounds.c
[COMCTL32]

- Fix heap memory leak in BUTTON_DrawTextCallback

CORE-13190

[COMCTL32] Toolbar: Use DrawThemeText when themes are enabled. CORE-12789
    • -0
    • +22
    /trunk/reactos/dll/win32/comctl32/toolbar.c
[SHELL32] -CMenuDeskBar: Handle WM_NCPAINT and paint the border with the correct color when it has the flat style.