• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[SHELL32_APITEST] -Add tests for Control_RunDLLW.
    • -0
    • +160
    /trunk/rostests/apitests/shell32/Control_RunDLLW.cpp
    • -0
    • +1
    /trunk/rostests/apitests/shell32/shell32_apitest.spec
[USETUP]: Fix the primary/extended partitions creation checks introduced in r63392 : indeed this is if there are *already* 4 (primary) partitions in the table that we cannot create new primary/extended partitions.

Otherwise with the old (broken) checks, we allowed creating more than 4 partitions, and then we overflowed over memory and corrupted the partition list structures.

[FREELDR]: Report the correct number of BIOS (hard) disk drives detected, that is, without any possible extra boot drive that went enumerated afterwards.

This fixes the list of disks enumerated in HKEY_LOCAL_MACHINE\HARDWARE\DESCRIPTION\System\MultifunctionAdapter\0\DiskController\0\DiskPeripheral\

and we now behave in this regards similarly to Windows 2003 & co.

I thank Lesan Ilie for reporting & testing, and Serge Gautherie and Peter Hater for reviewing.

This fixes a bug introduced in commit r59079.

CORE-13131

[SDK] Add enum for PEB.AppCompatFlagsUser
    • -0
    • +55
    /trunk/reactos/sdk/include/ndk/pstypes.h
[PRINTING]

- Implement GetDefaultPrinterA/W and SetDefaultPrinterA/W in winspool.drv. Also add tests for these functions.

- Set our "Dummy Printer on LPT1" as the default printer in the user registry.

- Return meaningful values for DeviceNotSelectedTimeout and TransmissionRetryTimeout in PRINTER_INFO_5 in localspl.

The Print dialog now preselects "Dummy Printer on LPT1" in all applications.

One more task done from the list at https://reactos.org/wiki/Printing :)

    • -3
    • +3
    /trunk/reactos/boot/bootdata/hivedef.inf
    • -0
    • +49
    /trunk/rostests/apitests/winspool/GetDefaultPrinter.c
[USETUP]: Improve the bootsector validity check performed in IsThereAValidBootSector:

- Check for the first 3 bytes (and not 4) of the bootsector to not be zero (that's our criterium for a "valid instruction"). Therefore, a bootsector starting with "00 00 00 xx" (with xx the first byte of a volume identifier) is detected as invalid (because the BIOS won't be able to run it anyways) and therefore, needs to be overwritten.

- Check that its last 2 bytes are the valid 0xAA55 signature.

These improvements were suggested by Serge Gautherie and Peter Hater.

CORE-4870 CORE-12672 CORE-13188

- Move a DPRINT1 around.

    • -15
    • +20
    /trunk/reactos/base/setup/usetup/bootsup.c
[DESK.CPL] -Addendum to 74506 which was a bit rushed. Make it possible to apply a theme that was opened by double click. Also add the active theme in the list of themes if it was not enumerated in the themes directory.
    • -0
    • +1
    /trunk/reactos/dll/cpl/desk/appearance.h
    • -21
    • +56
    /trunk/reactos/dll/cpl/desk/theme.c
    • -27
    • +14
    /trunk/reactos/dll/cpl/desk/appearance.c
[SHELL32]

- Fix AddCommasW

    • -4
    • +3
    /trunk/reactos/dll/win32/shell32/shell32.cpp
    • -0
    • +76
    /trunk/rostests/apitests/shell32/AddCommas.c
[DISK]: Small fixes:

- Check for malformed disk identifier, which must be at least 9 WCHARs long (as done by disk_new);

- Prevent possible memory leaks (missing ExFreePool's) + closing registry key.

Investigated by Lesan Ilie during tests; as part of CORE-13131.

- Make one of our hacks more readable (by me).

(We also note that this driver uses the ExAllocate/FreePool functions in the old-school way).

    • -1
    • +14
    /trunk/reactos/drivers/storage/class/disk/disk.c
More build fixes.
Fix build.
[DESK.CPL] -Implement opening msstyles files.
    • -0
    • +1
    /trunk/reactos/dll/cpl/desk/appearance.h
    • -10
    • +57
    /trunk/reactos/dll/cpl/desk/desk.c
    • -10
    • +18
    /trunk/reactos/dll/cpl/desk/theme.c
    • -2
    • +42
    /trunk/reactos/dll/cpl/desk/appearance.c
[EXPLORER] Some style suggestions by Mark Jansen. Thanks
    • -12
    • +12
    /trunk/reactos/base/shell/explorer/settings.cpp
[CONSOLE.CPL]: Fix the console window preview:

- turn it into a custom control;

- supports dynamic preview area depending on the actual current monitor screen resolution;

(note that on ReactOS, the WM_DISPLAYCHANGE is not correctly sent, see CORE-13212, therefore this functionality won't show up yet)

- supports correct rescaling of the console preview drawn in the preview area;

- supports dependence of the console preview with respect to the chosen font character dimensions.

The code is there, it may be a little bit improved in the future.

CORE-13196 #resolve

Other additions:

- Add a few space between the console preview text window border and the text sample;

- PaintText and PaintStaticControls do not need to return anything.

    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/ro-RO.rc
    • -12
    • +9
    /trunk/reactos/dll/cpl/console/colors.c
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/id-ID.rc
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/cs-CZ.rc
    • -4
    • +9
    /trunk/reactos/dll/cpl/console/console.h
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/bg-BG.rc
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/ja-JP.rc
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/ru-RU.rc
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/de-DE.rc
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/tr-TR.rc
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/zh-CN.rc
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/no-NO.rc
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/pt-BR.rc
    • -2
    • +2
    /trunk/reactos/dll/cpl/console/lang/es-ES.rc
  1. … 11 more files in changeset.
[CONSOLE.CPL]: Minor modifications:

- Use "hDlg" (as done in the rest of the code) instead of "hwndDlg";

- Refresh the console window preview whenever a dimension or a position was changed.

    • -62
    • +77
    /trunk/reactos/dll/cpl/console/layout.c
[CONSOLE.CPL]: Simplify the color selection code by factorizing common parts.
    • -114
    • +49
    /trunk/reactos/dll/cpl/console/colors.c
[EXPLORER] Addendum to r74500. Those 2 commits belong to CORE-11498
    • -2
    • +2
    /trunk/reactos/base/shell/explorer/settings.cpp
[EXPLORER]

- Load and save "Lock Taskbar", "Hide inactive icons", and "Group similar taskbar buttons". Verified on Win2k3 via "Nirsoft RegFromApp".

- use a loader function for registry values.

- save the "show seconds" setting together with the other explorer settings instead of a ROS specific key.

- Add some documentation comments.

    • -0
    • +4
    /trunk/reactos/base/shell/explorer/precomp.h
    • -0
    • +7
    /trunk/reactos/base/shell/explorer/trayprop.cpp
    • -21
    • +47
    /trunk/reactos/base/shell/explorer/settings.cpp
[WIN32SS] Fix font names not including style info (Bold etc). Patch by Katayama Hirofumi MZ. CORE-12179 #comment Thanks!
    • -59
    • +57
    /trunk/reactos/win32ss/gdi/ntgdi/freetype.c
[SHELL32]

- Avoid leaking the list items on destruction of CEnumIDListBase

CORE-13194

[USER32]

- Avoid a memory leak in User32EnumWindows in case the window count is zero.

CORE-13194

[NTOS:IO]

- Use pool tagging

    • -5
    • +9
    /trunk/reactos/ntoskrnl/io/iomgr/driver.c
[NTOS]: Addendums to r74491 and r74493:

- Free the FullServiceName buffer if PnpRootCreateDevice failed (erroneously committed in r74494, see pnpmgr.c line 1080);

- No need to close InstanceHandle if the IopCreateDeviceKeyPath call failed, since in this case the registry handle wasn't opened. CORE-13207

- Don't assert on Buffer allocation but return a proper failure code in case of failure. CORE-13208

These are suggestions from Serge Gautherie + Lesan Ilie.

- Add a forgotten ZwClose call in the success code path of IopCreateDeviceKeyPath in IopQueryDeviceCapabilities (by me).

    • -1
    • +4
    /trunk/reactos/ntoskrnl/io/iomgr/driver.c
    • -1
    • +2
    /trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c
[NTOS]: Code formatting + free the memory in the reverse order from how it was allocated.
    • -9
    • +10
    /trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c
[NTOS]: Capture the counted BaseDllName unicode string into a local NULL-terminated buffer before calling wcsrchr on it (actually I think it would be better to create & use a similar function that takes counted strings in input).

Also use 'L' prefix for wide characters and UNICODE_NULL for string terminator.

Patch by Lesan Ilie.

CORE-13208 #resolve

    • -4
    • +11
    /trunk/reactos/ntoskrnl/io/iomgr/driver.c
[NTOS]: Code formatting changes only.
    • -14
    • +8
    /trunk/reactos/ntoskrnl/io/iomgr/driver.c
[NTOS]: Fix a potential memory leak.

- If one of the ZwSetValueKey function fails, 'Node->ServiceName.Buffer' is leaked.

- Also use 'L' prefix for wide characters.

Patch by Lesan Ilie, thanks!

- Use "P(C)WSTR" instead of win32 "LP(C)WSTR" string pointer types (by me).

CORE-13207 #resolve

    • -4
    • +5
    /trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c
[NTDLL]

- Implement user-mode version of RtlWalkFrameChain (mostly as a copy of the kernel version). Now RtlCaptureStackBackTrace actually, you know, captures stack back-traces.

    • -16
    • +107
    /trunk/reactos/dll/ntdll/rtl/libsupp.c
[KMTESTS:RTL]

- Add a test for RtlWalkFrameChain and RtlCaptureStackBackTrace

    • -0
    • +2
    /trunk/rostests/kmtests/kmtest/testlist.c
    • -0
    • +1
    /trunk/rostests/kmtests/CMakeLists.txt
    • -0
    • +136
    /trunk/rostests/kmtests/rtl/RtlStack.c
[INTL]

- Get rid of the individual getter funtions. Use GetSelectedComboBoxIndex for all CBS_DROPDOWNLIST comboboxes and GetSelectedComboBoxText for all CBS_DROPDOWN comboboxes.

- Check the relevant settings only!

- Rename SetXxxSettings to GetXxxSettings because it is a getter function.

- Handle the bogus WM_COMMAND/EN_CHANGE message that is sent when the IDC_SECONDYEAR_EDIT edit control is initialized. Controls should NEVER send notifications when they are modified programmatically! :-/

    • -55
    • +42
    /trunk/reactos/dll/cpl/intl/time.c
    • -23
    • +26
    /trunk/reactos/dll/cpl/intl/date.c
    • -163
    • +72
    /trunk/reactos/dll/cpl/intl/numbers.c
    • -123
    • +59
    /trunk/reactos/dll/cpl/intl/currency.c