• last updated 1 hour ago
Constraints: committers
Constraints: files
Constraints: dates
[UXTHEME] -Remove a debug print that was never meant to be committed.
    • -2
    • +0
[UXTHEME] -Apply some suggestions by Thomas.
    • -3
    • +3
[MSTSC] Addendum to r74577. CORE-13263
[MSTSC] Fix BSOD when we can't acquire context from CryptoAPI. CORE-13263 #resolve
[USETUP]: Implement most of the "upgrade" page (where existing NTOS installations are listed).

- Modify a bit the page flow so that the upgrade page is inserted before the Device-settings page, and after the Install-Intro page.

- Insert some extra 'RepairUpdateFlag' checks in SelectPartitionPage() and InstallDirectoryPage() to take specific actions in case the flag is TRUE.

- As overviewed in r74573, move 'TempPartition' and 'FormatState' back to USETUP.

    • -0
    • +15
[USETUP]: Massage the USETUP interface code:

- The "intro" page is renamed into the "Welcome" page, because its corresponding resource indeed is the welcome screen;

- Because the "setup start" page can only be displayed once, move it out of the while-loop, and use its result as the initial value of the 'Page' variable.

- Remove unneeded _PAGE_NUMBER_DEFINED guards;

- Add a DPRINT in the RepairUpdateFlag case of RegistryPage() (because we don't implement yet a correct upgrading or repairing of the registry.

- Use the previously-introduced 'PreparePartitionForFormatting()' function; set the FormatState of the newly-formatted partition to Formatted.

- In InstallIntroPage(), display the page itself only if needed (i.e. after all the validation checks & repair/update or unattended checks are done). Similar modifications are done also in DeviceSettingsPage(), SelectPartitionPage()

- Remove the hackish call to CreateFileSystemList() in SelectFileSystemPage().

- Turn both CheckUnattendedSetup() and UpdateKBLayout() into static functions.

- Put large "case"-blocks into brackets.

- Fix the code of ScsiControllerPage() so that it can be compiled if needed, and add a dummy OemDriverPage().

[USETUP]: Fix some spacings in the french translation.
[USETUP]: Consolidate the PartList module of the setuplib.

- The 'FORMATMACHINESTATE FormatState' machine-state and the 'TempPartition' members of the partition list structure is purely a USETUP convenience, so remove them from the PARTLIST structure and move them back into USETUP.

- Attempt to recognize the filesystem (set the 'FileSystem' member of PARTENTRY) of partitions we are adding into the PARTLIST list.

- Fix the return value of the SelectPartition function, which is by the way completely broken (it doesn't do what it is supposed to do; alternatively its naming is completely wrong...).

[USETUP]: Consolidate the FsUtil module of the setuplib.

- Add a PreparePartitionForFormatting routine that sets the partition ID depending on the chosen filesystem.


- Avoid uninitialized ComputeHash variable in BlImgLoadImageWithProgress2

CORE-13265 #resolve

[USETUP]: Introduce "setuplib".

- Add a "setuplib" library (not yet complete), whose aim is to be shared between the (currently existing) 1st-stage text-mode installer, and the (future) 1st-stage GUI installer.

- Finish to split the GenList and PartList codes into their UI part, which remain in usetup, and their algorithmic part, which go into setuplib.

- Move SetMountedDeviceValue into the PartList module.

- Split the FileSystem list code into its UI and the algorithmic part (which goes into setuplib under the name fsutil.c).

* The algo part is meant to be able to manage the filesystems available on the running system, similarly to what is mostly done (in scattered form) in fmifs, format, chkdsk / autochk codes...

It also manages the partition filesystem recognition, using OS routines.

* The UI part manages the FS list as it appears on screen, showing only the possible FSes that can be used to format the selected partition (a bit similar to what we do in the shell32's drive.c, etc...).

- Adapt the calling code to these changes.

- Remove some "host" code that was dating back from the dark old times.

    • -0
    • +18
    • -0
    • +10
  1. /branches/setup_improvements/base/setup/lib
    • -0
    • +36
    • -0
    • +35
  2. … 16 more files in changeset.

- Tag the release

  1. … 27279 more files in changeset.
[MSTSC] Fix parsing of settings. Patch by Stas'M. Thanks. CORE-13223
[MSTSC] Send computer name as client name when available. Patch by Stas'M. Thanks. CORE-13237
[FORMAT]: Use a better variable type for the media flag.
[SHELL32]: Fix a FIXME: Recognize the media type for formatting, by calling GetDriveTypeW(). Based on what format.com does too.
[MSTSC] Fix unwanted change
[MSTSC] Fix adding module name and IP to logon packet. Patch by Stas'M. Minor modification by me. Thanks. CORE-13234
Addendum to r74559: specify 'void' function aka. doesn't take any parameter. In C, a function whose prototype is () means "take an arbitrary number of args".
[MSTSC] Enable taking settings folder using SHGetFolderLocation instead of using "c:\". Patch by Stas'M. Thanks CORE-13225
[MSTSC] Fix image corruption in 24bpp mode CORE-13224
[ACPI] Implement creating volatile registry keys for ACPI tables CORE-12942
[MSTSC] Switch most MSTSC from internal "ssl" functions to CryptoAPI and implement/enable certificate functions CORE-13259
[MSTSC] Fix build
[MSTSC] Bring MSTSC closer to latest rdesktop (1.83) CORE-13258

Advanced page: Show code pages again.

- Use SetupFindFirstLine and SetupFindNextLine to enumerate all code pages.

- Use heap memory functions instead of global memory functions.

- Get rid of TCHAR.


- Hack: Do not fail if EnumSystemCodePages returns FALSE.

    • -59
    • +74
[USETUP]: Similarly to what was done for GenLists, factor out the UI code from the partition list code. This will allow to reuse it for the 1st-stage GUI setup too, while using another UI representation.

- Add also two partition iterator functions: GetNextPartition and GetPrevPartition.

[USETUP]: Factor out the UI-specific code from the GenList code, and wrap it inside a GENERIC_LIST_UI structure.

The aim here is to decouple the UI-specific code from code that can be used by both the text-mode USETUP and a future 1st-stage GUI setup.

Indeed, the GenLists can actually be used in the 1st-stage GUI; and their contents be displayed inside ListBoxes/ListViews... (this is just one example amongst others).

Additionally (in usetup.c):

- Make both FormatPartitionPage and CheckFileSystemPage return PAGE_NUMBERs.

- Improve a couple of comments.

[UXTHEME] -ThemeDrawCaptionText: Try to avoid a heap allocation when getting the window caption.
    • -20
    • +27
[UXTHEME] -Simplify ThemeDrawCaptionText.
    • -33
    • +22