• last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[NTOS]: Employ the simple CMP_ASSERT_KCB_LOCK() macro to perform these asserts.
    • -19
    • +12
    /trunk/reactos/ntoskrnl/config/cmkcbncb.c
[NTOS]: Whitespace fixes only.
    • -17
    • +17
    /trunk/reactos/ntoskrnl/config/cmkcbncb.c
[User32]

- Based on patch by Nikolay Sivov : Fix static control id. Fixes dialog tests, see CORE-13362.

[User32]

- Skip desktop for positive index. See CORE-13362.

[NTOS]: Fix a bit the CmUnloadKey() function:

- When a hive is unloaded, we *must* set the HIVE_IS_UNLOADING flag before doing anything else (as other code in Cm depends on this);

- If we don't force a hive unload, we *must* check whether there are other opened handles to keys inside this hive, and if so, we must fail.

If this is a force-unload however, we *must* invalidate/close all the opened handles to keys inside this hive, BUT this is left UNIMPLEMENTED at the moment (and therefore expect the already existing problems linked to this to still happen).

- Move the HvFree(Hive); call at the very end, just before deleting the Cm hive, and as is done in CmpDestroyHive().

    • -5
    • +25
    /trunk/reactos/ntoskrnl/config/cmapi.c
[NTOS]: Reorder the destruction code in CmpDestroyHive() to make it similar to the one in CmUnloadKey(). Same remark for a comment in NtUnloadKey2() too.
    • -1
    • +1
    /trunk/reactos/ntoskrnl/config/ntapi.c
    • -6
    • +6
    /trunk/reactos/ntoskrnl/config/cminit.c
[NTOS]: Few improvements:

- Remove few unneeded PCMHIVE "backwards"-casts, and in particular the 1st parameter of CmpUnlinkHiveFromMaster().

- Improve the dprints in CmCountOpenSubKeys().

    • -16
    • +10
    /trunk/reactos/ntoskrnl/config/cmapi.c
[NTOS]: Remove trailing whitespace ; Use a correct pool tag in the CmpFree() call in CmpFreeDelayItem().
    • -42
    • +42
    /trunk/reactos/ntoskrnl/config/cmalloc.c
[USBPORT] Bring-in the usbport driver created by Vadim Galyant. CR-111 GitHub PR #27. This is the first module out of many to come, so stay tuned! Many thanks to everyone involved in the code review. Very special thanks for Thomas as his help, insight and reviews helped tremendously.
    • -0
    • +2775
    /trunk/reactos/drivers/usb/usbport/usbport.c
    • -0
    • +1389
    /trunk/reactos/drivers/usb/usbport/queue.c
    • -0
    • +1019
    /trunk/reactos/drivers/usb/usbport/roothub.c
    • -0
    • +9
    /trunk/reactos/drivers/usb/usbport/guid.c
    • -0
    • +270
    /trunk/reactos/drivers/usb/usbport/debug.c
    • -0
    • +653
    /trunk/reactos/sdk/include/reactos/drivers/usbport/usbmport.h
    • -0
    • +1821
    /trunk/reactos/drivers/usb/usbport/device.c
    • -0
    • +1
    /trunk/reactos/drivers/usb/CMakeLists.txt
    • -0
    • +1121
    /trunk/reactos/drivers/usb/usbport/usbport.h
    • -0
    • +1792
    /trunk/reactos/drivers/usb/usbport/pnp.c
    • -0
    • +1560
    /trunk/reactos/drivers/usb/usbport/endpoint.c
    • -0
    • +451
    /trunk/reactos/drivers/usb/usbport/ioctl.c
    • -0
    • +703
    /trunk/reactos/drivers/usb/usbport/power.c
    • -0
    • +28
    /trunk/reactos/drivers/usb/usbport/CMakeLists.txt
  1. … 7 more files in changeset.
[D3D8][D3D9][DDRAW][WINED3D] Sync with Wine Staging 2.9. This work couldn't have been committed without Sebastian Gasiorek's work on CORE-11331 so thanks again! Dedicated to Daniel. CORE-13362
    • -17
    • +41
    /trunk/reactos/dll/directx/wine/d3d8/surface.c
    • -51
    • +24
    /trunk/reactos/dll/directx/wine/d3d8/texture.c
    • -5504
    • +5626
    /trunk/reactos/sdk/include/reactos/wine/wgl.h
    • -383
    • +527
    /trunk/reactos/dll/directx/wine/wined3d/state.c
    • -177
    • +416
    /trunk/reactos/dll/directx/wine/d3d9/device.c
  1. … 55 more files in changeset.
[PSDK] Update D3DCOLOR_ARGB and D3DQUERYTYPE. [DXSDK] Add missing D3DDEVICEDESC1, D3DDEVICEDESC2, D3DFINDDEVICERESULT1 and D3DFINDDEVICERESULT2.
[WIN32SS] Implement D3DKMT{Create,Destroy}DCFromMemory. Brought to you by Sebastian Gasiorek. CORE-11331 CORE-13362
    • -0
    • +1
    /trunk/reactos/win32ss/reactx/ntddraw/intddraw.h
    • -0
    • +12
    /trunk/reactos/win32ss/gdi/gdi32/objects/dc.c
    • -0
    • +112
    /trunk/reactos/win32ss/reactx/ntddraw/d3dkmt.c
    • -0
    • +55
    /trunk/reactos/sdk/include/ddk/d3dkmthk.h
    • -0
    • +139
    /trunk/reactos/sdk/include/psdk/d3dukmdt.h
    • -0
    • +14
    /trunk/reactos/sdk/include/psdk/ntgdi.h
    • -0
    • +3
    /trunk/reactos/win32ss/gdi/gdi32/gdi32.spec
[SHELL32] -CMenuBand: When the flat menus style is enabled, shell menu bars should not look like toolbars.
[KMTESTS:MM]

- In the MmMapLockedPagesSpecifyCache test, try to allocate & free memory or unmap a section view in the mapped buffer space

CORE-13444

[NTFS] - Add support for expanding the master file table. Fix a bug with BrowseIndexEntries(). Improve diagnostic output.

-AddNewMftEntry() - Increase size of MFT as needed. Fix math for bitmap length. Don't assign file records to MFT indices 0x10 - 0x17; In Windows, these records aren't used unless they have to be, even though they are marked as unused in the bitmap.

+IncreaseMftSize() - Adds room for additional file records in the master file table.

-BrowseIndexEntries() - allow for the rare situation when a non-system file has an MFT index of 0x10.

[NTFS] - Restructure some code in preparation for the next commit:

-SetAttributeDataLength() has been split into two functions, SetNonResidentAttributeDataLength() and SetResidentAttributeDataLength(). This should improve code readibility and allows for resizing an attribute when there's no FileObject associated with it.

-Added "MftDataOffset" member to DEVICE_EXTENSION, which stores the offset of the Mft's $DATA attribute. (I'm starting to think it's better to add a member for offset to NTFS_ATTR_CONTEXT directly, but I'll save that level of restructuring for a future commit.)

[NTFS] - Add some improvements to the previous commit, as suggested by Thomas.
[ADVAPI32]

ScmRpcStatusToWinError: Convert STATUS_ACCESS_VIOLATION to ERROR_INVALID_HANDLE.

UnlockServiceDatabase returns ERROR_INVALID_SERVICE_LOCK instead of ERROR_INVALID_HANDLE.

    • -0
    • +4
    /trunk/reactos/dll/win32/advapi32/service/scm.c
[ADVAPI32]

CreateServiceA/W: Call SetLastError() in case of success too.

    • -2
    • +2
    /trunk/reactos/dll/win32/advapi32/service/scm.c
[NTOS:IO]

- Pass the class key handle as a parameter to IopAttachFilterDrivers, since we already opened it in PipCallDriverAddDevice.

CORE-13336 #resolve

    • -7
    • +9
    /trunk/reactos/ntoskrnl/io/pnpmgr/pnpinit.c
    • -59
    • +6
    /trunk/reactos/ntoskrnl/io/iomgr/driver.c
{QCKLNCH]

-Successfully added CISFBand to CQuickLaunchBand.

-Forwarded methods exported by CISFBand to CQuickLaunchBand.

[NTOS:IO]

- Consistently treat class filters as optional in IopAttachFilterDrivers

CORE-13336

    • -1
    • +1
    /trunk/reactos/ntoskrnl/io/iomgr/driver.c
[NTOS:IO]

- Simplify logic in PipCallDriverAddDevice.

CORE-13336

    • -8
    • +11
    /trunk/reactos/ntoskrnl/io/pnpmgr/pnpinit.c
[NTOS:IO]

- Addendum to r75046: add missing header change.

CORE-13336

[NTOS:IO]

- Pass Enum subkey handle to IopAttachFilterDrivers, since we've already opened it in PipCallDriverAddDevice.

CORE-13336

    • -33
    • +3
    /trunk/reactos/ntoskrnl/io/iomgr/driver.c
    • -6
    • +7
    /trunk/reactos/ntoskrnl/io/pnpmgr/pnpinit.c
[WIN32K:NTUSER]

- Fix clipboard lock check in UserSetClipboardData. Fixes 24 user32:clipboard tests.

CORE-13414 #resolve

    • -10
    • +1
    /trunk/reactos/win32ss/user/ntuser/clipboard.c
[ADVAPI32]

OpenServiceA/W: Call SetLastError() in case of success too.

    • -2
    • +2
    /trunk/reactos/dll/win32/advapi32/service/scm.c
[RTL]

- Implement RtlIsCriticalSectionLocked and RtlIsCriticalSectionLockedByThread

CORE-13436 #resolve

    • -0
    • +15
    /trunk/reactos/sdk/lib/rtl/critical.c
    • -2
    • +2
    /trunk/reactos/dll/ntdll/def/ntdll.spec
    • -0
    • +14
    /trunk/reactos/sdk/include/ndk/rtlfuncs.h
[NETAPI32]

Add obsolete NetRepl functions.

    • -1
    • +178
    /trunk/reactos/dll/win32/netapi32/obsolete.c
    • -15
    • +15
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
[APITEST] Move RedirectIat into it's own header so that it can be used from multiple tests.
    • -0
    • +64
    /trunk/rostests/apitests/include/apitest_iathook.h