• last updated 10 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[NTOS]: Minor fixes:

- Use NULL instead of 'zero' for setting a handle / pointer to NULL;

- Don't hardcode an array size; fix a comment;

- Use ExFreePoolWithTag();

- Whitespace fix.

[SHELL32]

-Rename constructors from Class_Creator to Class_CreateInstance. Prepend the ones that are exported from rshell with RSHELL_. The reasoning is that rshell will always use our code but whether or not internal classes will be used in shellmenu lib will be controlled by preprocessor definitions in shellmenu.h

[BROWSEUI]

-Rename more constructors to use the _CreateInstance suffix.

[RSHELL]

- The functions that let rshell export some objects have the RSHELL_ postfix but they are not exported as such.

[EXPLORER]

- Rename _CStartMenu_Constructor to _CStartMenu_CreateInstance.

    • -7
    • +7
    /trunk/reactos/base/shell/rshell/rshell.spec
    • -7
    • +7
    /trunk/reactos/dll/win32/browseui/browseui.cpp
    • -1
    • +1
    /trunk/reactos/base/shell/explorer/precomp.h
    • -3
    • +3
    /trunk/reactos/base/shell/explorer/rshell.cpp
    • -10
    • +10
    /trunk/reactos/base/shell/rshell/misc.cpp
    • -9
    • +1
    /trunk/reactos/base/shell/explorer/startmnu.cpp
  1. … 3 more files in changeset.
[USER.EXE]: Add a *stub* user.exe to make the DirectX 9.0 installer happy (it searches user.exe for existence for no reason, and if it cannot find it, the installer bails out). (WARNING: This is in NO WAY our implementation of WoW16!!)

Reported on https://www.reactos.org/forum/viewtopic.php?f=4&t=15576 , http://reactos.org/forum/viewtopic.php?f=4&t=16498 .

This is not a ReactOS problem per se, because it also happens on Windows, as reported here:

https://xpetips.wordpress.com/2009/09/18/installing-directx-9-0c-on-xpe/ and http://www.xpembedded.info/DirectX_v9_0c_and_finding_missing_components_.html .

  1. /trunk/reactos/subsystems/mvdm/wow16/user
    • -0
    • +2
    /trunk/reactos/subsystems/mvdm/wow16/CMakeLists.txt
    • -0
    • +25
    /trunk/reactos/subsystems/mvdm/wow16/user/user.c
    • -0
    • +5
    /trunk/reactos/subsystems/mvdm/wow16/user/CMakeLists.txt
[PRINTING]

- Implement GetPrinterDataA, GetPrinterDataExA, GetPrinterDataExW, GetPrinterDataW, SetPrinterDataA, SetPrinterDataExA, SetPrinterDataExW, SetPrinterDataW.

They support all features for Print Server and Printer Handles (minus security checks!)

I've also added tests for them.

- Store Printer data in SOFTWARE\Microsoft\Windows NT\CurrentVersion\Print\Printers instead of SYSTEM\CurrentControlSet\Control\Print\Printers and create a registry symlink from the former path to the new one just like Windows does.

According to https://social.technet.microsoft.com/Forums/windowsserver/en-US/a683ab54-c43c-4ebe-af8f-1f7a65af2a51, this is needed when having >900 printers to work around a size limit of the SYSTEM registry hive. And if Windows has both locations, we need both for compatibility anyway.

- Add several settings which are queried by the new Printer Data APIs when working with Print Server Handles.

- Store the job directory in the Windows-compatible "DefaultSpoolDirectory" setting and make use of it.

- Revert the ASSERTs in LocalEnumPrinters again to let us verify the NULL pointer exceptions in localspl_apitest (thanks Serge! CORE-13433)

- Translate ERROR_INVALID_NAME to ERROR_INVALID_PRINTER_NAME in all cases in OpenPrinterW (thanks Victor! CORE-13412)

- Make EnumMonitorsW and EnumPortsW in spoolss more robust against failing Print Monitors.

- Remove the wrong !phPrinter check in OpenPrinterW to make Print Server Handles work for real.

- Fix error handling when memory allocation fails: HeapAlloc doesn't set last error, so it's just wrong to query or return it.

One more item done from https://reactos.org/wiki/Printing !

This is all still a big Work-in-Progress, with many subtle bugs deep down in ReactOS, for which I need to open additional tickets. But I didn't want to make this commit even bigger..

    • -0
    • +188
    /trunk/rostests/apitests/winspool/GetPrinterData.c
    • -0
    • +62
    /trunk/reactos/win32ss/printing/base/spoolss/printerdata.c
    • -0
    • +478
    /trunk/reactos/win32ss/printing/providers/localspl/printerdata.c
  1. … 14 more files in changeset.
[NETAPI32]

Implement I_BrowserQueryEmulatedDomains, I_BrowserResetStatistics and I_BrowserSetNetlogonState. This functions calls their counterpart in the computer browser service.

    • -1
    • +1
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
    • -4
    • +66
    /trunk/reactos/dll/win32/netapi32/browser.c
[INCLUDE]

Replace the lmbrowsr.h form wine by a more complete psdk version.

Lmbrowsr.h was a part of Visual Studio 6 but Microsoft removed it from the PSDK later.

    • -0
    • +78
    /trunk/reactos/sdk/include/psdk/lmbrowsr.h
[MSPAINT]

- clicking the blank dark gray area will now reset the selection -- patch by Katayama Hirofumi MZ

CORE-13452 #resolve

[NFSD]

Misc. fixes by Thomas

[NFS]

Add the missing pieces for the NFS filesystem: registry information.

Register the pnfs service (nfsd) as manual, so that it only gets started when user wants/needs it.

Same goes to the nfs41_driver service (driver). nfsd as a code modification specific to ReactOS so that it loads the driver

as soon as it gets started.

That means, in order to use NFS in ReactOS, you need to start the nfsd service: net start nfsd

Then, you can mount your remote share: net use * \\IP\path (you can replace * by a letter, e.g. z:)

There's no GUI stuff implemented yet for this in MPR.

If you want to access the share without mounting it in ReactOS (like, in Explorer), you've to be aware of a small detail:

after you start pnfs service, in explorer bar, type \\IP\nfs4\path. This is required so that NFS driver can claim the path

without troubles.

Something else you've to know: so far, tests where conducted with a remote share being 777, read-only and anonymously mounted.

Other scenarii are likely to fail (auth, rw, server?!, etc.).

Also note that if you attempt to mount a share on which you don't have traverse right, mounting will succeed but any later

operation will fail, refused by the remote NFS server. This is a bit different than the behavior on Linux where mount is denied

if traverse is not granted.

Final thing: this is highly experimental and not fully implemented yet: expect not working stuff, broken asserts, deadlocks, etc.

CORE-8204

    • -1
    • +19
    /trunk/reactos/boot/bootdata/hivesys.inf
[NFSD]

Fix build?

[LIBTIRPC]

Add a spec file

[NFS]

More properly fix build for GCC/MSVC. By Thomas.

[NFSD]

Fix MSVC build by Thomas.

[PDSK]

Complete iptypes.h

    • -1
    • +16
    /trunk/reactos/sdk/include/psdk/iptypes.h
[NFSD]

Import the nfsd deamon from the nfs41 project.

CORE-8204

    • -0
    • +280
    /trunk/reactos/base/services/nfsd/from_kernel.h
    • -0
    • +532
    /trunk/reactos/base/services/nfsd/nfs41.h
    • -0
    • +295
    /trunk/reactos/base/services/nfsd/nfs41_callback.h
    • -0
    • +1399
    /trunk/reactos/base/services/nfsd/name_cache.c
    • -0
    • +1289
    /trunk/reactos/base/services/nfsd/pnfs_layout.c
    • -0
    • +368
    /trunk/reactos/base/services/nfsd/pnfs.h
    • -0
    • +4
    /trunk/reactos/base/services/nfsd/nfsd.rc
    • -0
    • +32
    /trunk/reactos/base/services/nfsd/sources
    • -0
    • +365
    /trunk/reactos/base/services/nfsd/pnfs_device.c
    • -0
    • +501
    /trunk/reactos/base/services/nfsd/nfs41_daemon.c
    • -0
    • +80
    /trunk/reactos/base/services/nfsd/nfs41_compound.h
    • -0
    • +114
    /trunk/reactos/base/services/nfsd/list.h
    • -0
    • +20
    /trunk/reactos/base/services/nfsd/ms-nfs41-idmap.conf
    • -0
    • +547
    /trunk/reactos/base/services/nfsd/callback_server.c
    • -0
    • +871
    /trunk/reactos/base/services/nfsd/pnfs_io.c
  1. … 48 more files in changeset.
[LIBTIRPC]

As suggested, move to 3rdparty

    • -0
    • +103
    /trunk/reactos/dll/3rdparty/libtirpc/CMakeLists.txt
    • -1
    • +0
    /trunk/reactos/dll/win32/CMakeLists.txt
    • -0
    • +1
    /trunk/reactos/dll/3rdparty/CMakeLists.txt
    • -0
    • +253
    /trunk/reactos/dll/3rdparty/libtirpc/src/xdr_mem.c
    • -0
    • +856
    /trunk/reactos/dll/3rdparty/libtirpc/src/svc_vc.c
  1. … 351 more files in changeset.
[NETAPI32]

NetEnumerateComputerNames: Convert the returned array of strings.

    • -2
    • +26
    /trunk/reactos/dll/win32/netapi32/wksta_new.c
[NETAPI32]

Implement NetConnectionEnum(). This function calls its counterpart in the server service.

    • -1
    • +1
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
    • -0
    • +74
    /trunk/reactos/dll/win32/netapi32/srvsvc.c
[RXCE]

lolfix build

[NFS][RXCE]: Fix MSVC build (definitively?)
[NTOS:SE]

Add the CmpAssignSecurityDescriptor() stub and improve some comments.

    • -6
    • +16
    /trunk/reactos/ntoskrnl/config/cmse.c
[NFS]

Remove dependency already brought in by rxce

[RDBSS]

Clean up CMake files, based on suggestions by Hermès.

Might fix MSVC build.

    • -2
    • +2
    /trunk/reactos/sdk/lib/drivers/rxce/rxce.c
[NFS]

Import the NFS file system mini-redirector and the associated network provider.

Not all the pieces are in place to make it working.

CORE-8204

    • -0
    • +7140
    /trunk/reactos/drivers/filesystems/nfs/nfs41_driver.c
    • -0
    • +17
    /trunk/reactos/dll/np/nfs/CMakeLists.txt
    • -0
    • +74
    /trunk/reactos/dll/np/nfs/dllmain.c
    • -0
    • +50
    /trunk/reactos/dll/np/nfs/nfs41_np.h
    • -0
    • +102
    /trunk/reactos/dll/np/nfs/options.c
    • -0
    • +1
    /trunk/reactos/dll/np/CMakeLists.txt
    • -0
    • +82
    /trunk/reactos/dll/np/nfs/options.h
    • -0
    • +102
    /trunk/reactos/drivers/filesystems/nfs/nfs41_debug.h
    • -0
    • +21
    /trunk/reactos/drivers/filesystems/nfs/CMakeLists.txt
    • -0
    • +5
    /trunk/reactos/dll/np/nfs/nfsnp.rc
    • -0
    • +749
    /trunk/reactos/drivers/filesystems/nfs/nfs41_debug.c
    • -0
    • +13
    /trunk/reactos/dll/np/nfs/nfs41_np.spec
  1. … 5 more files in changeset.
[NTOS:MM]

- Directly pass the file object to MmCreateDataFileSection

    • -22
    • +3
    /trunk/reactos/ntoskrnl/mm/section.c
[NTOS:PNP]

- If PFN tracing is enabled, create a device object that allows the user to trigger a PFN dump (e.g. via "type \\.\Global\GLOBALROOT\Device\PfnDump")

    • -0
    • +56
    /trunk/reactos/ntoskrnl/io/pnpmgr/pnproot.c
[NPFS]

- Misc changes to improve code clarity

[LIBTIFF]

- Update to version 4.0.8

CORE-13451

    • -10
    • +30
    /trunk/reactos/dll/3rdparty/libtiff/tif_color.c
    • -17
    • +45
    /trunk/reactos/dll/3rdparty/libtiff/tif_dirread.c
    • -15
    • +45
    /trunk/reactos/dll/3rdparty/libtiff/tif_pixarlog.c
    • -25
    • +70
    /trunk/reactos/dll/3rdparty/libtiff/tif_getimage.c
  1. … 10 more files in changeset.
[MBEDTLS]

- Update to version 2.4.2

CORE-13451

    • -10
    • +12
    /trunk/reactos/dll/3rdparty/mbedtls/pem.c
    • -1
    • +1
    /trunk/reactos/dll/3rdparty/mbedtls/md2.c
  1. … 12 more files in changeset.
[LIBTIRPC]

- Try to fix VC2010 build as well

CORE-8204

    • -3
    • +3
    /trunk/reactos/dll/win32/libtirpc/src/clnt_dg.c