• last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[RDBSS]

Fix broken assignment.

Spotted by cppcheck.

[NETAPI32]

- Add DsAddressToSiteNamesExA stub.

- Implement DsAddressToSiteNamesExW.

    • -2
    • +2
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
    • -0
    • +116
    /trunk/reactos/dll/win32/netapi32/netlogon.c
[RXCE]

- Define RxShouldPostCompletion() and use it

- Define RxIsResourceOwnershipStateExclusive() and use it

- Define some magic values

[RDBSS]

- Implement CheckForLoudOperations(), RxAdjustFileTimesAndSize(), RxIsOkToPurgeFcb()

- Continue implementation of RxCommonCleanup()

- Fix bugs in the RxCommonCleanup() implementation and make it more explicit when in the delete on close path

- Stub RxCleanupPipeQueues(), RxLowIoLockControlShell()

- Silent a few DPRINTs

CORE-8204

CORE-11327

    • -7
    • +8
    /trunk/reactos/sdk/lib/drivers/rxce/rxce.c
    • -0
    • +15
    /trunk/reactos/sdk/include/ddk/rxprocs.h
    • -0
    • +4
    /trunk/reactos/sdk/include/ddk/ntrxdef.h
[NETAPI32]

- Add DsValidateSubnetNameA/W stubs.

- Move DsRoleFreeMemory to a better location.

[SDK/INCLUDE]

Add DsValidateSubnetNameA/W prototypes to dsgetdc.h.

    • -2
    • +2
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
    • -5
    • +17
    /trunk/reactos/dll/win32/netapi32/netlogon.c
    • -0
    • +10
    /trunk/reactos/dll/win32/netapi32/dssetup.c
    • -0
    • +10
    /trunk/reactos/sdk/include/psdk/dsgetdc.h
[NETAPI32]

- Add DsDeregisterDnsHostRecordsA stub.

- Implement DsDeregisterDnsHostRecordsW.

[SDK/INCLUDE]

Add DsDeregisterDnsHostRecordsA/W prototypes to dsgetdc.h.

    • -2
    • +2
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
    • -0
    • +49
    /trunk/reactos/dll/win32/netapi32/netlogon.c
    • -12
    • +22
    /trunk/reactos/sdk/include/psdk/dsgetdc.h
Integrate the USERINIT changes r75295, r75302 and r75303 from the setup_improvements branch back to trunk.
    • -8
    • +51
    /trunk/reactos/base/system/userinit/userinit.c
    • binary
    /trunk/reactos/base/system/userinit/res/rosbitmap_old.bmp
    • -4
    • +6
    /trunk/reactos/base/system/userinit/userinit.rc
  1. … 20 more files in changeset.
[USERINIT]: Paint the ReactOS logo transparently (with alpha channel), much like it's done in dll/cpl/sysdm/general.c . CORE-13527 #resolve

This also fixes the drawing mismatch problem reported at CORE-11323 #resolve

Finally, add a standard comctl32 manifest.

[USERINIT]: Add the possibility to quit the UserInit "wizard" via the "Cancel" button, prompting the user for confirmation beforehand. This action restarts the computer.

CORE-13530 #resolve

  1. … 16 more files in changeset.
[SHELL32]

- Simplify SHELL32_CoCreateInitSF by letting the callers fill the PERSIST_FOLDER_TARGET_INFO. This lets us stop using _ILSimpleGetTextW in it which breaks the logic that pidls should be read only by their shell folder. Also add an overload for SHELL32_CoCreateInitSF that makes it simpler to create a shell folder with a csidl.

- Add a SHELL32_BindToSF helper to share some logic that was duplicated in several shell folders.

- Move SHELL32_GetCustomFolderAttributeFromPath, SHELL32_GetCLSIDForDirectory and SHELL32_GetFSItemAttributes, SHELL32_BindToFS to CFSFolder.cpp as these were fs specific.

- These changes give finer control to shell folders for how the bind will be done and shares more logic that can be shared.

    • -7
    • +10
    /trunk/reactos/dll/win32/shell32/shfldr.h
    • -252
    • +28
    /trunk/reactos/dll/win32/shell32/shlfolder.cpp
[NETAPI32]

- Add DsMergeForestTrustInformationW stub.

- Implement DsGetForestTrustInformationW.

[SDK/INCLUDE]

Add DsGetSiteNameA/W, DsGetForestTrustInformationW and DsMergeForestTrustInformationW prototypes to dsgetdc.h.

    • -0
    • +30
    /trunk/reactos/sdk/include/psdk/dsgetdc.h
    • -6
    • +49
    /trunk/reactos/dll/win32/netapi32/netlogon.c
    • -2
    • +2
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
[QCKLNCH]

-Fixed a memory leak issue.

-Apparently Tested in xpvm.

-Needs further testing.

[QCKLNCH]

-Apparently fixed some memory leaks.

-Removed unnecessary methods.

-Fixed a checkmark bug. :p

-And thus finished any remaining issues of CR-122.

CR-122 (https://code.reactos.org/cru/CR-122#details)

PS: Please raise any other issues which you feel needs correction. I am waiting... ;D

[QCKLNCH]

-Removed CWindowImpl

-Added CWindow

-Used OnWinEvent() instead of subclassing

-Handled WM_COMMAND and WM_NOTIFY as needed

-Now along with buttons chevron menu is also working

CR-122 (https://code.reactos.org/cru/CR-122#details)

PS: Thank you everyone for spending your time and giving a thorough review. :)

[USBXHCI]

- few changes to stably load the driver onto windows 2003 server edition.

CORE-13344

[USERINIT]: Use a real horizontal line for the separator line in the userinit livecd pages.

CORE-13528 #resolve

  1. … 12 more files in changeset.
[NtGDI]

- Return Set if managed, part of CORE-12888.

    • -0
    • +3
    /trunk/reactos/win32ss/gdi/ntgdi/dcutil.c
[NtUser]

- Part of CORE-13110. Set DC window rectangle and pointer.

    • -15
    • +7
    /trunk/reactos/win32ss/user/ntuser/windc.c
[Gdi32]

- Sync/Port Wine Enhanced/Metafile code. This is a fix for CORE-12888.

- Wine made this difficult to port and keep the whole file unchanged for syncing.

    • -11
    • +25
    /trunk/reactos/win32ss/gdi/gdi32/wine/enhmetafile.c
    • -0
    • +570
    /trunk/reactos/win32ss/gdi/gdi32/wine/path.c
    • -2
    • +15
    /trunk/reactos/win32ss/gdi/gdi32/misc/misc.c
    • -52
    • +477
    /trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/dc.c
[USBXHCI]

- added dprints to all the xhci functions.

- some fixes suggested in code review.

- have written interrupt code (rudimentary).

CORE-13344

[NTFS] - Fix some formatting / style issues, per CR-123.
[SHELL32] -Remove IShellView_Constructor and CDefView_Constructor. Use SHCreateShellFolderView and SHCreateShellFolderViewEx instead.
    • -7
    • +41
    /trunk/reactos/dll/win32/shell32/CDefView.cpp
[NTFS] - Add a few fixes and improvements, most from CR-123:

-Add ATTR_RECORD_ALIGNMENT define to replace magic value of 8 when we need to adjust an attribute's beginning or length.

-Don't use int's.

-GetPackedByteCount() - Remove unused "bytes" variable.

[PRINTING]

Apply a consistent style to all similar functions:

- Spoolss functions don't necessarily set ERROR_SUCCESS. Check the boolean return value instead and only query the error code on failure.

- Use AlignRpcPtr and UndoAlignRpcPtr wherever feasible.

- Use one static function per level that can be called from both Get* and Enum* APIs.

- Use PackStrings in all functions that return structures with strings.

- Add TRACEs to all non-static functions in localspl.

- Pass a double pointer to all Marshalling functions and advance to the next structure there.

- Perform sanity checks and return the right error codes in a Windows-compatible way.

- Return TRUE when an Enum* API has no elements to enumerate.

Also fixes CORE-12793

  1. … 4 more files in changeset.
[RXCE]

- Implement RxFinalizeConnection(), RxOrphanSrvOpens()

- Stub RxOrphanSrvOpensForThisFcb()

[RDBSS]

- Fix a bug in RxCommonDevFCBClose() where prefix table wasn't acquire exclusively; this was problematic due to potential prefix table removal on dereference

- Stub RxCancelNotifyChangeDirectoryRequestsForVNetRoot()

This commit basically allows you to delete a NFS share you would have made use of in ReactOS.

Like net use z: \\share\path can be deleted through net use /delete z:

Note that if you access the share using cmd tools (dir, copy, more, and so on), dismount will work.

If you attempt to access with Explorer, then, handles will be kept open and dismount will fail.

CORE-8204

CORE-11327

    • -0
    • +6
    /trunk/reactos/sdk/include/ddk/rxprocs.h
    • -12
    • +12
    /trunk/reactos/sdk/include/ddk/fcb.h
    • -0
    • +5
    /trunk/reactos/sdk/include/ddk/rxcontx.h
    • -0
    • +1
    /trunk/reactos/sdk/include/ddk/mrxfcb.h
    • -0
    • +237
    /trunk/reactos/sdk/lib/drivers/rxce/rxce.c
[MPR]

Import Wine commit:

- 26192671700360859cd8a0133dabcd96ec1a786b, Implement WNetConnectionDialog().

CORE-13516

    • -3
    • +11
    /trunk/reactos/dll/win32/mpr/wnet.c
[NTFS] - Add some fixes and improvements to mft.c from CR-123:

FindAttribute() - Use * sizeof(WCHAR) in place bit-shifting wizardry.

IncreaseMftSize() - Remove two useless casts. Return error code if WriteAttribute() fails.

SetNonResidentAttributeDataLength() - Assert that AttrContext parameter describes a NonResident attribute. When migrating a resident attribute to non-resident, don't leak memory if FsRtlInitializeLargeMcb() throws an exception, and don't mark the attribute as non-resident until after the Mcb is initialized.

InternalSetResidentAttributeLength() and SetResidentAttributeLength() - Assert that AttrContext parameter describes a resident attribute.

AddNewMftEntry() - Simplify math of backing up and restoring reserved bits by changing BitmapData to PUCHAR type. Don't attempt to modify a volume with more than 2^32 clusters.

AddFixupArray() - Use ULONG in place of int.

[NTFS] - Add some fixes and improvements to finfo.c from CR-123:

NtfsSetEndOfFile() - Make fileNameAttribute and filename variables uppercase. Don't leak FileRecord if we can't truncate the file. Don't leak memory if there's no FileName attribute.

[WELCOME]: UI improvements:

- Allow only one running instance of the Welcome application at a time.

- Implement translating \xhhhh hexadecimal character specifications in topic text descriptions.

- Allow using the keyboard for navigating amongst the topics, and ENTER key presses to run the selected topic command.

<rant> *OF COURSE*, because we are ReactOS *SO* we are *buggy* (well, user32/win32k), keyboard navigation via arrow keys *DOES NOT WORK*!! (only navigation via TAB key do work) 8^(((( </rant>

This however works OK on Windows.

- Improve topic buttons activation when mouse hovers around above the window, as well as when window activation is lost or regained.

- Change the default text font to Tahoma.

- Don't hardcode white brush, but instead use stock object WHITE_BRUSH. Similarly, don't hardcode text black colour, but instead use the ambient text colour of the system.

- Add keyboard shortcuts to the default topic items.

- Shift the window ID of both the checkbox and the Exit buttons to be below a fixed topic-button base ID.

- In GetLocaleName(), use more explicit returned-variable names (cchRet, because it's a returned string length in character numbers).

    • -5
    • +5
    /trunk/reactos/base/setup/welcome/lang/hu-HU.rc
    • -5
    • +5
    /trunk/reactos/base/setup/welcome/lang/zh-CN.rc
    • -5
    • +5
    /trunk/reactos/base/setup/welcome/lang/sq-AL.rc
    • -5
    • +5
    /trunk/reactos/base/setup/welcome/lang/et-EE.rc
    • -3
    • +3
    /trunk/reactos/base/setup/welcome/lang/ja-JP.rc
    • -5
    • +5
    /trunk/reactos/base/setup/welcome/lang/de-DE.rc
    • -5
    • +5
    /trunk/reactos/base/setup/welcome/lang/tr-TR.rc
    • -5
    • +5
    /trunk/reactos/base/setup/welcome/lang/ms-MY.rc
    • -5
    • +5
    /trunk/reactos/base/setup/welcome/lang/fr-FR.rc
    • -5
    • +5
    /trunk/reactos/base/setup/welcome/lang/id-ID.rc
    • -5
    • +5
    /trunk/reactos/base/setup/welcome/lang/pt-BR.rc
    • -5
    • +5
    /trunk/reactos/base/setup/welcome/lang/sv-SE.rc
    • -5
    • +5
    /trunk/reactos/base/setup/welcome/lang/ro-RO.rc
    • -5
    • +5
    /trunk/reactos/base/setup/welcome/lang/es-ES.rc
    • -5
    • +5
    /trunk/reactos/base/setup/welcome/lang/zh-TW.rc
  1. … 15 more files in changeset.
[NTFS] - Add some fixes and improvements to create.c, dirctl.c and fcb.c from CR-123:

-NtfsOpenFile() - Replace an ExFreePool() with ExFreePoolWithTag().

-NtfsCreateFile() - Fix broken cast with BooleanFlagOn() macro.

-NtfsAddFilenameToDirectory() - Remove an extra cast. Return an error if we fail to allocate I30IndexRoot.

-NtfsGetNextPathElement(), NtfsWSubString(), NtfsGetFCBForFile() - Use PCWSTR in place of const PWCHAR or PWCHAR where it makes sense.

[NTFS] - Add some fixes and improvements to btree.c from CR-123:

-CompareTreeKeys() - Assert that the first key isn't the dummy key.

-CreateIndexRootFromBTree() - Assert that CurrentKey->IndexEntry->Length isn't 0.

-DumpBTreeKey() - Use sizeof(WCHAR) in place of magic 2.

-NtfsInsertKey() - Check for allocation failure of NewKey.