• last updated 31 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[COMCTL32_APITEST] - Log the dwDrawStage when the NM_CUSTOMDRAW is received to make the test slightly more descriptive.
[SDK] Added atlex for future use

- atlex is ATL wrappers for WINAPI functions

- It is header-only library licensed under GPLv3

- For details see https://github.com/Amebis/atlex

[ATL]

- Added missing operator+=

[RAPPS] Fixes

- Minor style improvements

- Not resizing with GetBuffer() calls where not nessesary

- loaddlg.cpp: Wrong logic fixed

- rosui.h: Fixed length determination

[RAPPS] Some fixes

- winmain.cpp, loaddlg.cpp, installed.cpp:

Changed string-related opreations

- installed.cpp: Fixed buffer sizing when calling RegQueryValueExW()

- misc.cpp: Removed unused function

- rosui.h: Made use of GetWindowTextLength()

[RAPPS] Extensive conversion to ATL and general improvements

* Converted most of the WCHAR buffers to ATL::CStringW

* available.cpp: replaced C heap list with ATL::CAtlList

* Improved style consistency

* Added myself to the headers

* Other improvements

[USBPORT]

Patch by Vadim Galyant:

- Improve variable naming

- Make more consistent use of constants

    • -33
    • +29
    /trunk/reactos/drivers/usb/usbport/usbport.c
    • -11
    • +7
    /trunk/reactos/drivers/usb/usbport/usbport.h
    • -1
    • +1
    /trunk/reactos/drivers/usb/usbport/pnp.c
    • -7
    • +7
    /trunk/reactos/drivers/usb/usbport/debug.c
    • -2
    • +2
    /trunk/reactos/drivers/usb/usbport/roothub.c
[EXPLORER]

- CTrayWindow: Implement the IContextMenu interface. This will be used by the CBandSite to query the context menu of its site (the CTrayWindow) and add it in its context menu.

- CTrayWindowCtxMenu: Use Shell_MergeMenus in QueryContextMenu and respect its parameters.

    • -12
    • +12
    /trunk/reactos/base/shell/explorer/resource.h
    • -31
    • +54
    /trunk/reactos/base/shell/explorer/traywnd.cpp
[ENG]

- Turn on GradientFill apply small hack fix to keep it out of a loop.

- Turning code off does not fix the code, 8 years later!

    • -84
    • +84
    /trunk/reactos/win32ss/gdi/eng/gradient.c
[old_WORDPAD]: Fix typo (caught by user_trisquel).
[FONTS] Add substitutes for the System font, and remove a hack for the System font. Patch by Katayama Hirofumi MZ. CORE-9222
    • -49
    • +18
    /trunk/reactos/win32ss/gdi/ntgdi/freetype.c
[RDBSS]

Fix broken assignment.

Spotted by cppcheck.

[NETAPI32]

- Add DsAddressToSiteNamesExA stub.

- Implement DsAddressToSiteNamesExW.

    • -2
    • +2
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
    • -0
    • +116
    /trunk/reactos/dll/win32/netapi32/netlogon.c
[RXCE]

- Define RxShouldPostCompletion() and use it

- Define RxIsResourceOwnershipStateExclusive() and use it

- Define some magic values

[RDBSS]

- Implement CheckForLoudOperations(), RxAdjustFileTimesAndSize(), RxIsOkToPurgeFcb()

- Continue implementation of RxCommonCleanup()

- Fix bugs in the RxCommonCleanup() implementation and make it more explicit when in the delete on close path

- Stub RxCleanupPipeQueues(), RxLowIoLockControlShell()

- Silent a few DPRINTs

CORE-8204

CORE-11327

    • -7
    • +8
    /trunk/reactos/sdk/lib/drivers/rxce/rxce.c
    • -0
    • +15
    /trunk/reactos/sdk/include/ddk/rxprocs.h
    • -0
    • +4
    /trunk/reactos/sdk/include/ddk/ntrxdef.h
[NETAPI32]

- Add DsValidateSubnetNameA/W stubs.

- Move DsRoleFreeMemory to a better location.

[SDK/INCLUDE]

Add DsValidateSubnetNameA/W prototypes to dsgetdc.h.

    • -2
    • +2
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
    • -5
    • +17
    /trunk/reactos/dll/win32/netapi32/netlogon.c
    • -0
    • +10
    /trunk/reactos/dll/win32/netapi32/dssetup.c
    • -0
    • +10
    /trunk/reactos/sdk/include/psdk/dsgetdc.h
[NETAPI32]

- Add DsDeregisterDnsHostRecordsA stub.

- Implement DsDeregisterDnsHostRecordsW.

[SDK/INCLUDE]

Add DsDeregisterDnsHostRecordsA/W prototypes to dsgetdc.h.

    • -2
    • +2
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
    • -0
    • +49
    /trunk/reactos/dll/win32/netapi32/netlogon.c
    • -12
    • +22
    /trunk/reactos/sdk/include/psdk/dsgetdc.h
Integrate the USERINIT changes r75295, r75302 and r75303 from the setup_improvements branch back to trunk.
    • -8
    • +51
    /trunk/reactos/base/system/userinit/userinit.c
    • binary
    /trunk/reactos/base/system/userinit/res/rosbitmap_old.bmp
    • -4
    • +6
    /trunk/reactos/base/system/userinit/userinit.rc
  1. … 20 more files in changeset.
[USERINIT]: Paint the ReactOS logo transparently (with alpha channel), much like it's done in dll/cpl/sysdm/general.c . CORE-13527 #resolve

This also fixes the drawing mismatch problem reported at CORE-11323 #resolve

Finally, add a standard comctl32 manifest.

[USERINIT]: Add the possibility to quit the UserInit "wizard" via the "Cancel" button, prompting the user for confirmation beforehand. This action restarts the computer.

CORE-13530 #resolve

  1. … 16 more files in changeset.
[SHELL32]

- Simplify SHELL32_CoCreateInitSF by letting the callers fill the PERSIST_FOLDER_TARGET_INFO. This lets us stop using _ILSimpleGetTextW in it which breaks the logic that pidls should be read only by their shell folder. Also add an overload for SHELL32_CoCreateInitSF that makes it simpler to create a shell folder with a csidl.

- Add a SHELL32_BindToSF helper to share some logic that was duplicated in several shell folders.

- Move SHELL32_GetCustomFolderAttributeFromPath, SHELL32_GetCLSIDForDirectory and SHELL32_GetFSItemAttributes, SHELL32_BindToFS to CFSFolder.cpp as these were fs specific.

- These changes give finer control to shell folders for how the bind will be done and shares more logic that can be shared.

    • -7
    • +10
    /trunk/reactos/dll/win32/shell32/shfldr.h
    • -252
    • +28
    /trunk/reactos/dll/win32/shell32/shlfolder.cpp
[NETAPI32]

- Add DsMergeForestTrustInformationW stub.

- Implement DsGetForestTrustInformationW.

[SDK/INCLUDE]

Add DsGetSiteNameA/W, DsGetForestTrustInformationW and DsMergeForestTrustInformationW prototypes to dsgetdc.h.

    • -0
    • +30
    /trunk/reactos/sdk/include/psdk/dsgetdc.h
    • -6
    • +49
    /trunk/reactos/dll/win32/netapi32/netlogon.c
    • -2
    • +2
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
[QCKLNCH]

-Fixed a memory leak issue.

-Apparently Tested in xpvm.

-Needs further testing.

[QCKLNCH]

-Apparently fixed some memory leaks.

-Removed unnecessary methods.

-Fixed a checkmark bug. :p

-And thus finished any remaining issues of CR-122.

CR-122 (https://code.reactos.org/cru/CR-122#details)

PS: Please raise any other issues which you feel needs correction. I am waiting... ;D

[QCKLNCH]

-Removed CWindowImpl

-Added CWindow

-Used OnWinEvent() instead of subclassing

-Handled WM_COMMAND and WM_NOTIFY as needed

-Now along with buttons chevron menu is also working

CR-122 (https://code.reactos.org/cru/CR-122#details)

PS: Thank you everyone for spending your time and giving a thorough review. :)

[USBXHCI]

- few changes to stably load the driver onto windows 2003 server edition.

CORE-13344

[USERINIT]: Use a real horizontal line for the separator line in the userinit livecd pages.

CORE-13528 #resolve

  1. … 12 more files in changeset.
[NtGDI]

- Return Set if managed, part of CORE-12888.

    • -0
    • +3
    /trunk/reactos/win32ss/gdi/ntgdi/dcutil.c
[NtUser]

- Part of CORE-13110. Set DC window rectangle and pointer.

    • -15
    • +7
    /trunk/reactos/win32ss/user/ntuser/windc.c
[Gdi32]

- Sync/Port Wine Enhanced/Metafile code. This is a fix for CORE-12888.

- Wine made this difficult to port and keep the whole file unchanged for syncing.

    • -11
    • +25
    /trunk/reactos/win32ss/gdi/gdi32/wine/enhmetafile.c
    • -0
    • +570
    /trunk/reactos/win32ss/gdi/gdi32/wine/path.c
    • -2
    • +15
    /trunk/reactos/win32ss/gdi/gdi32/misc/misc.c
    • -52
    • +477
    /trunk/reactos/win32ss/gdi/gdi32/wine/enhmfdrv/dc.c
[USBXHCI]

- added dprints to all the xhci functions.

- some fixes suggested in code review.

- have written interrupt code (rudimentary).

CORE-13344