• last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
  • More
  • CR-120
  • resumed reviewing
[RAPPS]

- Style changes, typo fixes etc.

    • -3
    • +3
    ./base/applications/rapps/installed.cpp
    • -1
    • +1
    ./base/applications/rapps/include/available.h
    • -1
    • +1
    ./base/applications/rapps/include/gui.h
    • -1
    • +1
    ./base/applications/rapps/include/unattended.h
    • -1
    • +1
    ./base/applications/rapps/integrity.cpp
    • -16
    • +16
    ./base/applications/rapps/installdlg.cpp
    • -4
    • +4
    ./base/applications/rapps/include/misc.h
    • -68
    • +68
    ./base/applications/rapps/include/rosui.h
    • -17
    • +12
    ./base/applications/rapps/unattended.cpp
  1. … 3 more files in changeset.
[RAPPS]

- Quit CmdParser() as soon as no valid key supplied

    • -0
    • +2
    ./base/applications/rapps/unattended.cpp
[RAPPS]

- Close the INF file after loading the info

    • -0
    • +1
    ./base/applications/rapps/unattended.cpp
[RAPPS]

- Added the icon provided by Pi_User5

    • binary
    ./base/applications/rapps/res/select.ico
[RAPPS]

- Changed "/SETUP" key to "/INSTALL"

- Added support for multiple apps install by "/INSTALL"

rapps /INSTALL 7-Zip AkelPad [...]

- Added INF based batch install with the "/SETUP" key

Works for the full path for the .inf file

TODO: detect if user entered the relative path for the inf and correct it

- Moved CmdParser to include/unattended.h and unattended.cpp

    • -0
    • +106
    ./base/applications/rapps/misc.cpp
    • -1
    • +3
    ./base/applications/rapps/CMakeLists.txt
    • -25
    • +3
    ./base/applications/rapps/include/available.h
    • -33
    • +3
    ./base/applications/rapps/winmain.cpp
    • -106
    • +14
    ./base/applications/rapps/available.cpp
    • -4
    • +28
    ./base/applications/rapps/include/misc.h
    • -0
    • +8
    ./base/applications/rapps/include/unattended.h
    • -0
    • +70
    ./base/applications/rapps/unattended.cpp
[RAPPS]

- Added headers to CMake file to have them in the VS project

    • -0
    • +10
    ./base/applications/rapps/CMakeLists.txt
[RAPPS]

- Added /SETUP key support

TODO: use the short names from db files

- Some style changes

- Conditional creation of the dialogs

    • -3
    • +25
    ./base/applications/rapps/available.cpp
    • -9
    • +20
    ./base/applications/rapps/loaddlg.cpp
    • -28
    • +42
    ./base/applications/rapps/winmain.cpp
    • -28
    • +31
    ./base/applications/rapps/include/available.h
    • -1
    • +1
    ./base/applications/rapps/installdlg.cpp
[RAPPS]

- Refactoring

- A template for a future parameters parser

    • -48
    • +58
    ./base/applications/rapps/winmain.cpp
    • -141
    • +112
    ./base/applications/rapps/misc.cpp
    • -0
    • +3
    ./base/applications/rapps/available.cpp
    • -16
    • +5
    ./base/applications/rapps/aboutdlg.cpp
    • -8
    • +4
    ./base/applications/rapps/settingsdlg.cpp
[RAPPS]

- Split the rapps.h into multiple headers for easier managing

- Moved headers to include/

- Corrected some typos and moved functions around

    • -2
    • +10
    ./base/applications/rapps/available.cpp
    • -0
    • +148
    ./base/applications/rapps/include/available.h
    • -0
    • +200
    ./base/applications/rapps/include/resource.h
    • -2
    • +4
    ./base/applications/rapps/CMakeLists.txt
    • -1
    • +1
    ./base/applications/rapps/lang/en-US.rc
    • -0
    • +803
    ./base/applications/rapps/include/rosui.h
    • -0
    • +120
    ./base/applications/rapps/include/crichedit.h
    • -1
    • +2
    ./base/applications/rapps/settingsdlg.cpp
    • -342
    • +0
    ./base/applications/rapps/rapps.h
    • -0
    • +20
    ./base/applications/rapps/include/gui.h
    • -0
    • +35
    ./base/applications/rapps/include/winmain.h
    • -0
    • +21
    ./base/applications/rapps/include/misc.h
    • -801
    • +0
    ./base/applications/rapps/rosui.h
    • -0
    • +34
    ./base/applications/rapps/include/defines.h
  1. … 13 more files in changeset.
[RAPPS] Incorrect "C" symbol replaced in the rest of the files
    • -12
    • +12
    ./base/applications/rapps/loaddlg.cpp
[RAPPS] Incorrect symbol replaced (why was it there though)
    • -2
    • +2
    ./base/applications/rapps/available.cpp
[RAPPS] Bulk install!

- Added ListView class

- Added ListView to a dialog

Dialog shows the install progress of individual apps. It also waits for an installator to finish before issuing another download-install cycle.

- Fixed: Downloads pointing to "\"

- Fixed: Selection data is not retrieved correctly

- Yet again replacing some macros to wide functions

- Minor improvements

    • -1
    • +4
    ./base/applications/rapps/lang/uk-UA.rc
    • -1
    • +4
    ./base/applications/rapps/lang/ru-RU.rc
    • -2
    • +2
    ./base/applications/rapps/available.cpp
    • -1
    • +4
    ./base/applications/rapps/lang/en-US.rc
    • -1
    • +1
    ./base/applications/rapps/installed.cpp
    • -12
    • +18
    ./base/applications/rapps/gui.cpp
    • -92
    • +263
    ./base/applications/rapps/loaddlg.cpp
[RAPPS]

- Added DownloadManager class (static for now)

- Multiple selection launches multiple download dialogs

(Checkbox selection has a priority over Selection when clicking Install)

*A preperation for lauching a single dialog with a list of apps*

- Show currently installing app in the dialog window

    • -11
    • +1
    ./base/applications/rapps/lang/en-US.rc
    • -1
    • +1
    ./base/applications/rapps/lang/ru-RU.rc
    • -13
    • +18
    ./base/applications/rapps/gui.cpp
    • -1
    • +1
    ./base/applications/rapps/lang/uk-UA.rc
    • -156
    • +177
    ./base/applications/rapps/loaddlg.cpp
    • -2
    • +2
    ./base/applications/rapps/available.cpp
[RAPPS]

- A quick fix for counter - used a list that is not updated prior to the message

[RAPPS] Making checkboxes useful WIP

- Added selection counter

*NOTE: This requires changes in lang files*

- Added Sellect/Desellect button functionality

- Fixed some typos and macros-to-wide-functions

    • -2
    • +1
    ./base/applications/rapps/available.cpp
    • -2
    • +2
    ./base/applications/rapps/lang/uk-UA.rc
    • -44
    • +85
    ./base/applications/rapps/gui.cpp
    • -1
    • +11
    ./base/applications/rapps/lang/en-US.rc
    • -1
    • +1
    ./base/applications/rapps/installed.cpp
    • -2
    • +2
    ./base/applications/rapps/lang/ru-RU.rc
[RAPPS] Improvements & multiple selections

- Improved translations view - storing LCIDs now

- Added checkboxes on list view and Select All button (although they do nothing just yet)

- Made download dialogs nonmodal (yay, download and install multiple apps at once!)

- Minor code improvements

    • -56
    • +36
    ./base/applications/rapps/available.cpp
    • -1
    • +3
    ./base/applications/rapps/lang/en-US.rc
    • -11
    • +29
    ./base/applications/rapps/gui.cpp
[RAPPS] Fixed multiple redraws of the apps list
[RAPPS] Translations

- Implemented HasNativeLanguage() and HasEnglishLanguage()

- Moved config parser to it's own class CConfigParser

- Added translation strings

    • -10
    • +27
    ./base/applications/rapps/rapps.h
    • -10
    • +25
    ./base/applications/rapps/gui.cpp
    • -0
    • +8
    ./base/applications/rapps/lang/ru-RU.rc
    • -55
    • +197
    ./base/applications/rapps/available.cpp
    • -4
    • +3
    ./base/applications/rapps/lang/en-US.rc
    • -0
    • +8
    ./base/applications/rapps/lang/uk-UA.rc
[RAPPS] Refactoring & bugfixes

- Made a bunch of classes for Available apps;

- Removed unnessesary GetBuffer calls;

- Set a bit higher minimum height for RichEdit;

- Added "Single" indicator for the Languages to show that the translation available is the only one;

- Small style changes.

    • -51
    • +186
    ./base/applications/rapps/gui.cpp
    • -2
    • +13
    ./base/applications/rapps/installed.cpp
    • -0
    • +1
    ./base/applications/rapps/lang/en-US.rc
    • -261
    • +172
    ./base/applications/rapps/available.cpp
How do I handle such situation correctly?

How do I handle such situation correctly?

[ATL] [3RDPARTY] Updated & moved atlex to sdk/lib/3rdparty
    • -0
    • +25
    ./sdk/lib/3rdparty/atlex/README.md
    • -0
    • +117
    ./sdk/lib/3rdparty/atlex/atlsec.h
    • -0
    • +79
    ./sdk/lib/3rdparty/atlex/atlwlan.h
    • -0
    • +326
    ./sdk/lib/3rdparty/atlex/atlmsi.h
    • -0
    • +70
    ./sdk/lib/3rdparty/atlex/atlshlwapi.h
    • -0
    • +63
    ./sdk/lib/3rdparty/atlex/atleap.h
    • -0
    • +654
    ./sdk/lib/3rdparty/atlex/atlex.h
    • -0
    • +2312
    ./sdk/lib/3rdparty/atlex/Doxyfile
    • -0
    • +498
    ./sdk/lib/3rdparty/atlex/atlcrypt.h
    • -0
    • +623
    ./sdk/lib/3rdparty/atlex/atlwin.h
    • -0
    • +339
    ./sdk/lib/3rdparty/atlex/LICENSE
    • -70
    • +0
    ./sdk/include/reactos/atlex/atlshlwapi.h
    • -79
    • +0
    ./sdk/include/reactos/atlex/atlwlan.h
  1. … 6 more files in changeset.
[RAPPS] Showing info from Languages sectin

- Created dummies & added new string resources

- lang/uk-UA.rc: translated all strings

- crichedit.h: safe text add

    • -0
    • +9
    ./base/applications/rapps/lang/en-US.rc
    • -2
    • +48
    ./base/applications/rapps/available.cpp
    • -11
    • +11
    ./base/applications/rapps/lang/uk-UA.rc
[RAPPS] Language loading

- RAPPS now can load language list from a file where locale identifiers are separated by '|'

`Language=0C09|0813|0422 \\English|Dutch|Ukrainian`

The only limitation is that the parameter is only 260 chars.

So there arises another goal - multiline parameters

- This list is stored in `CSimpleArray<CStringW>` as strings

Maybe it would be wiser to store them as INT array.

- Some refactoring

    • -21
    • +86
    ./base/applications/rapps/available.cpp
[RAPPS] More code improvements

- Replaced some functions with their Wide versions

- Generalized `GetInstalledVersion` function so it could accept NULL

- Minor cleanup

    • -31
    • +23
    ./base/applications/rapps/installed.cpp
    • -8
    • +8
    ./base/applications/rapps/settingsdlg.cpp
    • -37
    • +55
    ./base/applications/rapps/gui.cpp
    • -32
    • +15
    ./base/applications/rapps/available.cpp
I agree that using GetBuffer() when reading is not pretty. However, original code almost never copied the arrays themselves and passed that local arrays around. Perhaps I don't need to copy them?

I agree that using GetBuffer() when reading is not pretty.
However, original code almost never copied the arrays themselves and passed that local arrays around.
Perhaps I don't need to copy them?

[SDK] Added atlex for future use

- atlex is ATL wrappers for WINAPI functions

- It is header-only library licensed under GPLv3

- For details see https://github.com/Amebis/atlex

    • -0
    • +70
    ./sdk/include/reactos/atlex/atlshlwapi.h
    • -0
    • +79
    ./sdk/include/reactos/atlex/atlwlan.h
    • -0
    • +326
    ./sdk/include/reactos/atlex/atlmsi.h
    • -0
    • +117
    ./sdk/include/reactos/atlex/atlsec.h
    • -0
    • +498
    ./sdk/include/reactos/atlex/atlcrypt.h
    • -0
    • +623
    ./sdk/include/reactos/atlex/atlwin.h
    • -0
    • +654
    ./sdk/include/reactos/atlex/atlex.h
    • -0
    • +63
    ./sdk/include/reactos/atlex/atleap.h
[ATL]

- Added missing operator+=

This can be different per use case. If you need the buffer just to read from it, use GetString(), if you need the buffer to modify it, use GetBuffer() / ReleaseBuffer(). If you are going to pass t...

This can be different per use case.
If you need the buffer just to read from it, use GetString(), if you need the buffer to modify it, use GetBuffer() / ReleaseBuffer().

If you are going to pass the data to a control that holds on to it (lParam etc) you probably dont want to use a CString at all.