• last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[RAPPS] Improvements & multiple selections

- Improved translations view - storing LCIDs now

- Added checkboxes on list view and Select All button (although they do nothing just yet)

- Made download dialogs nonmodal (yay, download and install multiple apps at once!)

- Minor code improvements

[RAPPS] Fixed multiple redraws of the apps list
[RAPPS] Translations

- Implemented HasNativeLanguage() and HasEnglishLanguage()

- Moved config parser to it's own class CConfigParser

- Added translation strings

[RAPPS] Refactoring & bugfixes

- Made a bunch of classes for Available apps;

- Removed unnessesary GetBuffer calls;

- Set a bit higher minimum height for RichEdit;

- Added "Single" indicator for the Languages to show that the translation available is the only one;

- Small style changes.

How do I handle such situation correctly?

How do I handle such situation correctly?

Not without doing some work, or copying the .Buffer to a PWSTR. It looks like NtfsOpenFile() passes the variable on to several functions that expect a PWSTR. What is the issue with leaving it as a ...

Not without doing some work, or copying the .Buffer to a PWSTR. It looks like NtfsOpenFile() passes the variable on to several functions that expect a PWSTR. What is the issue with leaving it as a PWSTR? That maybe the buffer won't be null-terminated? I can see that FullPath.Buffer will be, I'm not sure about FileObject->FileName.Buffer.

[STOBJECT]

-Added support for battery enumeration.

-Now battery status is available.

-Added icons and resources respectively for battery levels.

-Now battery changes its icons dynamically as per its quantized levels.

  1. … 3 more files in changeset.
[ATL] [3RDPARTY] Updated & moved atlex to sdk/lib/3rdparty
  1. … 6 more files in changeset.
[RAPPS] Showing info from Languages sectin

- Created dummies & added new string resources

- lang/uk-UA.rc: translated all strings

- crichedit.h: safe text add

[RAPPS] Language loading

- RAPPS now can load language list from a file where locale identifiers are separated by '|'

`Language=0C09|0813|0422 \\English|Dutch|Ukrainian`

The only limitation is that the parameter is only 260 chars.

So there arises another goal - multiline parameters

- This list is stored in `CSimpleArray<CStringW>` as strings

Maybe it would be wiser to store them as INT array.

- Some refactoring

[USBXHCI]

- type cast issues solved for runtimebas and doorbellbase

- controller check function written to test teh event ring and command ring functionality.

- Finally inetrrupt is being generated upon connecting a pen drive. Interrupt service function is being called

CORE-13344

[RAPPS] More code improvements

- Replaced some functions with their Wide versions

- Generalized `GetInstalledVersion` function so it could accept NULL

- Minor cleanup

I agree that using GetBuffer() when reading is not pretty. However, original code almost never copied the arrays themselves and passed that local arrays around. Perhaps I don't need to copy them?

I agree that using GetBuffer() when reading is not pretty.
However, original code almost never copied the arrays themselves and passed that local arrays around.
Perhaps I don't need to copy them?

  • More
  • CR-120
  • finished reviewing
  • More
  • CR-122
  • resumed reviewing
[SDK] Added atlex for future use

- atlex is ATL wrappers for WINAPI functions

- It is header-only library licensed under GPLv3

- For details see https://github.com/Amebis/atlex

[ATL]

- Added missing operator+=

This can be different per use case. If you need the buffer just to read from it, use GetString(), if you need the buffer to modify it, use GetBuffer() / ReleaseBuffer(). If you are going to pass t...

This can be different per use case.
If you need the buffer just to read from it, use GetString(), if you need the buffer to modify it, use GetBuffer() / ReleaseBuffer().

If you are going to pass the data to a control that holds on to it (lParam etc) you probably dont want to use a CString at all.

The reason I did use GetBuffer() is that some functions require LPWSTR and I did not want to use const_cast<LPWSTR>(). So you say casting is better?

The reason I did use GetBuffer() is that some functions require LPWSTR and I did not want to use const_cast<LPWSTR>().
So you say casting is better?

A generic note for CString: If you just want to access the raw string pointer (to read!), use GetString() instead of GetBuffer().

A generic note for CString: If you just want to access the raw string pointer (to read!), use GetString() instead of GetBuffer().

[RAPPS] Fixes

- Minor style improvements

- Not resizing with GetBuffer() calls where not nessesary

- loaddlg.cpp: Wrong logic fixed

- rosui.h: Fixed length determination

[RAPPS] Some fixes

- winmain.cpp, loaddlg.cpp, installed.cpp:

Changed string-related opreations

- installed.cpp: Fixed buffer sizing when calling RegQueryValueExW()

- misc.cpp: Removed unused function

- rosui.h: Made use of GetWindowTextLength()

[RAPPS] Extensive conversion to ATL and general improvements

* Converted most of the WCHAR buffers to ATL::CStringW

* available.cpp: replaced C heap list with ATL::CAtlList

* Improved style consistency

* Added myself to the headers

* Other improvements

  • More
  • CR-122
  • finished reviewing
  • More
  • CR-123
  • finished reviewing
  • More
  • CR-121
  • finished reviewing
  • More
  • CR-120
  • finished reviewing
  • More
  • CR-122
  • finished reviewing
Jira cut off the url (already gave it in irc): https://git.reactos.org/?p=reactos.git;a=blob;f=reactos/dll/win32/browseui/explorerband.cpp;hb=6f6999647ab23b1ee53550b6f6196c912b03334a#l57

Jira cut off the url (already gave it in irc): https://git.reactos.org/?p=reactos.git;a=blob;f=reactos/dll/win32/browseui/explorerband.cpp;hb=6f6999647ab23b1ee53550b6f6196c912b03334a#l57

As you already found out, and what we overlooked was: The TBBUTTON struct treats this as opaque data, e.g. it does do nothing but store the raw value you pass it. (in our case, a pointer) So when f...

As you already found out, and what we overlooked was: The TBBUTTON struct treats this as opaque data, e.g. it does do nothing but store the raw value you pass it. (in our case, a pointer)
So when freeing this data, the pidl becomes invalid, and the button can no longer use it.