• last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tag the CLT-2017 release!
  1. … 27279 more files in changeset.
[CLT-2017]: The very last sync!

[SHUTDOWN]: shutdown -t causes crash. Patch by Michael Fritscher. (r74131 by Eric).

<@dreimer> OMG!!!!

<@hbelusca> hm dreimer?

<@dreimer> ITS SO IMPORTANT!!!!

<@hbelusca> ah you want it? <@hbelusca> ok <@hbelusca> let's add it :D

<@dreimer> jkjkjk

[CLT-2017]: Add the lstrlenA/W fixes from r74117,r74118,r74119.
[CLT-2017]: For this 0.4.4 release, let's play safe & revert the USB stack import from r73605, as the latter need more real-hardware testing & fixes.
[CLT2017]

Make CLT logo a bit more... on screen

[CLT2017]

Add wallpapers to ISO

  1. … 14 more files in changeset.
[NTOS]: Modify the ReactOS boot logo for the CLT 2017 edition, similarly to what was done for FOSDEM 2017.
[REACTOS-CLT2017]: Cherry-pick few trunk improvements/fixes:

- [UXTHME] Implement drawing themed text with shadows, by Giannis (r74083)

- [MKISOFS] Update mkisofs to schily-2017-02-16, by Colin (r74112)

[REACTOS-CLT2017]: Sync with ROS 0.4.4 release branch. In particular the following fixes/hacks:

- Apply the Wordpad related hack from CORE-5823 by Jared Smudde (r73624).

- Disable COMMAND.COM debugging messages. CORE-10710 (r73625).

- Add a hack by Thomas to avoid MmGetPhysicalAddress failures during USB transfers. CORE-9224 (r73627).

- Apply the patch that allows us to dynamically change the resolution by resizing in VirtualBox. CORE-6742 (r73628).

- Mask WndProc exceptions CORE-11915 (r73631).

[EXPLORER]: Update the Start Menu banner for CLT 2017.
[INF]: Disable hdaudbus.inf registration, because the driver currently crashes on the demo laptops Dell Latitude D531.
[FREELDR]: HACK: Manually reduce the size of the temporary heap from 32MB down to 10MB, because, in some situations (e.g. Bochs, or real HW, see CORE-12694), FreeLDR fails when creating the temporary heap with an "out of memory" error.

See also r73653 for other details.

[BOOTDATA][FREELDR]

- By default, boot the livecd without the kernel debugger enabled, but...

- ... augment the FreeLdr "Debugging Mode" option with serial+screen debug ports, so that, if someone wants to run ReactOS with the kernel debugger on real hardware, without serial port, (s)he still can do it and see the debug output.

I do that, until FreeLdr can support run-time editing boot options of existing boot menu entries.

[BOOTDATA]

- Add user-friendly boot menu.

[README]

- Update the ReadMe.txt for CLT 2017.

[WELCOME]

- Add the welcome.exe localized customizations for CLT 2017.

[VERSION]

- Adjust version to 0.4.4 CLT 2017.

[BOOTDATA]

- Flatten out the ISO layout for hybridcd (otherwise some problems appear for the livecd: see r66114 for more details).

Time is passing fast, and CLT 2017 is already coming! Branch for its release.
  1. … 27248 more files in changeset.
Why not just keep checking NewMdList != NULL? Or even ARGUMENT_PRESENT(NewMdList)

Why not just keep checking NewMdList != NULL? Or even ARGUMENT_PRESENT(NewMdList)

Don't like 'break'? https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/wink.gif

Don't like 'break'?

Descriptor makes more sense here than NextEntry

Descriptor makes more sense here than NextEntry

This is an __out. Also why not SAL2?

This is an __out. Also why not SAL2?

BasePage = BasePage would be more obvious

BasePage = BasePage would be more obvious

Why is there no truncate/coalesce/savepointer in this case?

Why is there no truncate/coalesce/savepointer in this case?

You mean NextDescriptor in these two lines

You mean NextDescriptor in these two lines

Same as in the Truncate function: deref'ing pointers that are not known-good

Same as in the Truncate function: deref'ing pointers that are not known-good

magic

magic

I understand the "never coalesce" flag since the do-coalesce flag can come from the MemoryDescriptor. But why is there a "never truncate" flag if all it does is remove the truncate flag from the sa...

I understand the "never coalesce" flag since the do-coalesce flag can come from the MemoryDescriptor. But why is there a "never truncate" flag if all it does is remove the truncate flag from the same variable?

... this however, I'd rather not see. You could be dereferencing based on the list head.

... this however, I'd rather not see. You could be dereferencing based on the list head.

Normally you shouldn't even use CONTAINING_RECORD unless the pointer in question is actually valid (i.e. NextEntry != MdList->First), but that's fine in practice if you don't reference it...

Normally you shouldn't even use CONTAINING_RECORD unless the pointer in question is actually valid (i.e. NextEntry != MdList->First), but that's fine in practice if you don't reference it...

Even if we assume the BaseAddress can never be the same, which I suppose is likely given they're memory descriptors: O0, O4, C2, L1, S3, A5 Becomes ['O0', 'C2', 'O4', 'L1', 'S3', 'A5'] Which is nei...

Even if we assume the BaseAddress can never be the same, which I suppose is likely given they're memory descriptors:
O0, O4, C2, L1, S3, A5
Becomes ['O0', 'C2', 'O4', 'L1', 'S3', 'A5']
Which is neither address ordering nor C<O<S<L<A

This ordering is strange. It's neither a "lower address first" nor a "higher precedence first" order, and gives a lot of emphasis to "order of insertion." Let's say I insert the following descripto...

This ordering is strange. It's neither a "lower address first" nor a "higher precedence first" order, and gives a lot of emphasis to "order of insertion."
Let's say I insert the following descriptors (in that order): Other0, Other2, Other1, Conventional0, Loader0, System1, Application0, Conventional1, System0, Application1, Loader1

That will give me a list like this:
Other0, Conventional0, Other1, Conventional1, Other2, Loader0, System0, System1, Application0, Application1, Loader1

Should the precedence only count if address is the same? That would give us: Conventional0, Other0, System0, Loader0, Application0, Conventional1, Other1, System1, Loader1, Application1, Other2
Or should the address only count if precedence is the same? Conventional0, Conventional1, Other0, Other1, Other2, System0, System1, Loader0, Loader1, Application0, Application1

Or is it really supposed to be like this?