• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
All GSOC Rapps changes
All GSOC Rapps changes
There was no strong consensus on this so I'll leave it as is for now.

There was no strong consensus on this so I'll leave it as is for now.

[USETUP]: Move the SetupExtractFile() function to where it is (only) used.
[SETUPLIB]: Use strsafe functions (cont).
[SETUPLIB]: Use strsafe functions.
[SETUPLIB][USETUP]: Make the GENERIC_LIST store the items display text in UNICODE (and not in ANSI). Only convert to ANSI when needed (e.g. in the display code for usetup).

The 1st-stage GUI setup will however use the UNICODE strings directly.

[USETUP]: Whitespace fixes only.
[SETUPLIB][USETUP]: Move the floppy-disk accessibility check into InstallFatBootcodeToFloppy().
[SETUPLIB][USETUP]: Move the registry-update procedure into setuplib, where it can also be used by the 1st-stage GUI setup, and make the necessary changes in usetup.

[REACTOS]: Fix build.

[USETUP]: Introduce some -V functions for CONSOLE_ConOutPrintf, CONSOLE_SetStatusText and CONSOLE_SetStatusTextX.

Fix also the whitespace in consup.h.

Given that VS2010 is the newest one that has a chance to work in ReactOS, that may take a while.

Given that VS2010 is the newest one that has a chance to work in ReactOS, that may take a while.

Seems a bit ugly IMO. Edit: I'd really prefer using enum class if we switch to more modern MSVC.

Seems a bit ugly IMO.
Edit: I'd really prefer using enum class if we switch to more modern MSVC.

I prefer having dedicated headers for semantically different parts of code.

I prefer having dedicated headers for semantically different parts of code.

Yes, I'll do that as the enum above.

Yes, I'll do that as the enum above.

Yep seems like I was thinking of something else. Doing a quick search through our CMakeLists.txt files, it seems like we do this in quite a few places, so it's OK.

Yep seems like I was thinking of something else. Doing a quick search through our CMakeLists.txt files, it seems like we do this in quite a few places, so it's OK.

I haven't found a command like this.

I haven't found a command like this.

[USETUP]: Fix a typo.
  1. … 12 more files in changeset.
Its not like you create many instances of this class. It will be cleaner if these are not global variables.

Its not like you create many instances of this class. It will be cleaner if these are not global variables.

There's also of course the option of using a namespace.

There's also of course the option of using a namespace.

don't we have some "add_include_files" for this?

don't we have some "add_include_files" for this?

In that case it would be best to have some prefix, like LicenseType_OpenSource and so on, rather than "polluting" the global namespace with names such as "Min" or "None".

In that case it would be best to have some prefix, like LicenseType_OpenSource and so on, rather than "polluting" the global namespace with names such as "Min" or "None".

VS2010 doesn't support enum class scoped enums.

VS2010 doesn't support enum class scoped enums.

This class uses static cache for locale strings so they won't be generated for each object but instead be shared.

This class uses static cache for locale strings so they won't be generated for each object but instead be shared.

Yeah, it acts like a namespace yet.

Yeah, it acts like a namespace yet.

The idea is that CAvailableApps just caches the entries into memory. The DB update merely downloads all the files, so it doesn't need any non-static object members and can be called without such, w...

The idea is that CAvailableApps just caches the entries into memory. The DB update merely downloads all the files, so it doesn't need any non-static object members and can be called without such, while still having semantic connection to CAvailableApps. I did it this way to keep the existing EnumAvailableApplications code, which can be redesigned I guess.

Opps, that's a weird typo. No warning either.

Opps, that's a weird typo. No warning either.