gadamopoulos in reactos

[WIN32K:NTUSER] -IntSetThreadDesktop: Don't close the previous desktop handle. Fixes a lot of tests. Based on a patch by Sebastian Gasiorek. CORE-13463
    • -3
    • +0
    /trunk/reactos/win32ss/user/ntuser/desktop.c
[USER32_APITEST] -Initial tests for desktop reference numbers.
    • -0
    • +18
    /trunk/rostests/apitests/user32/desktop.c
[ATL]

-Add a new template called CComQIIDPtr and its partner I_ID macro. Its purpose is to be a gcc compatible version of CComQIPtr.

-CComQIIDPtr<I_ID(Itype)> is the gcc compatible version of CComQIPtr<Itype>

- WARNING: this is not tested yet.

    • -0
    • +60
    /trunk/reactos/sdk/lib/atl/atlcomcli.h
[SHELL32]

-Rename constructors from Class_Creator to Class_CreateInstance. Prepend the ones that are exported from rshell with RSHELL_. The reasoning is that rshell will always use our code but whether or not internal classes will be used in shellmenu lib will be controlled by preprocessor definitions in shellmenu.h

[BROWSEUI]

-Rename more constructors to use the _CreateInstance suffix.

[RSHELL]

- The functions that let rshell export some objects have the RSHELL_ postfix but they are not exported as such.

[EXPLORER]

- Rename _CStartMenu_Constructor to _CStartMenu_CreateInstance.

    • -7
    • +7
    /trunk/reactos/base/shell/rshell/rshell.spec
    • -7
    • +7
    /trunk/reactos/dll/win32/browseui/browseui.cpp
    • -1
    • +1
    /trunk/reactos/base/shell/explorer/precomp.h
    • -3
    • +3
    /trunk/reactos/base/shell/explorer/rshell.cpp
    • -10
    • +10
    /trunk/reactos/base/shell/rshell/misc.cpp
    • -9
    • +1
    /trunk/reactos/base/shell/explorer/startmnu.cpp
  1. … 3 more files in changeset.
[SHELL32] -CMenuBand::SetSite: Don't fail if the site doesn't support the SID_STopLevelBrowser service.
[SHELL32] -CMenuBand: forward WM_WININICHANGE to CMenuToolbarBase so that when themes get enabled, the menu bar in explorer becomes flat immediately.
[BROWSEUI]

- CShellBrowser: Propagate WM_WININICHANGE to all immediate children.

- CInternetToolbar: Forward WM_WININICHANGE to the menu band to make aware that the flat menus option changed.

[SHELL32] -CMenuBand: When the flat menus style is enabled, shell menu bars should not look like toolbars.
[WIN32K] -Use RtlStringCchCopyW instead of RtlStringCbCopyW in SubstituteFontRecurse as LF_FACESIZE is the number of characters of the buffer. Patch by Katayama Hirofumi MZ. CORE-13419, CORE-13416
    • -1
    • +1
    /trunk/reactos/win32ss/gdi/ntgdi/freetype.c
[PSDK] -Add IShellFolderBand and IFolderBandPriv interfaces.
[PSDK] -Add CLSID_ISFBand, IID_IShellFolderBand and IID_IFolderBandPriv.
[SHELL32] -Add Comments as the 2nd column in CDesktopFolder, CDrivesFolder and CRegFolder. Add Type as the 3rd column in CRegFolder. This is not entirely correct. Our columns support is rudimentary, however we now show the comments stuff in the right place and the reg folder items have a type.
Fix build.
[SHELL32]

- Rename the resource identifiers for column names to make sense. Get rid of one called File. This was renamed to Name but was the same in other languages, now it is replaced by Name for good. We also had two strings for a column called Comments and I think that in some languages one was singular and the other was plural. We only need the plural one.

Note to translators: Please make sure that everything I changed makes sense. I had to edit all language files and there can be mistakes and typos.

    • -15
    • +13
    /trunk/reactos/dll/win32/shell32/lang/sk-SK.rc
    • -14
    • +12
    /trunk/reactos/dll/win32/shell32/lang/he-IL.rc
    • -14
    • +12
    /trunk/reactos/dll/win32/shell32/lang/ja-JP.rc
    • -14
    • +12
    /trunk/reactos/dll/win32/shell32/lang/ko-KR.rc
    • -14
    • +12
    /trunk/reactos/dll/win32/shell32/lang/de-DE.rc
    • -14
    • +12
    /trunk/reactos/dll/win32/shell32/lang/pt-BR.rc
    • -14
    • +12
    /trunk/reactos/dll/win32/shell32/lang/zh-TW.rc
    • -21
    • +19
    /trunk/reactos/dll/win32/shell32/shresdef.h
    • -14
    • +12
    /trunk/reactos/dll/win32/shell32/lang/fr-FR.rc
    • -15
    • +13
    /trunk/reactos/dll/win32/shell32/lang/el-GR.rc
    • -14
    • +12
    /trunk/reactos/dll/win32/shell32/lang/ro-RO.rc
  1. … 24 more files in changeset.
[SHELL32] -CDrivesFolder: Implement returning the appropriate type string in GetDetailsOf. Simplify GetDetailsOf and CDrivesExtractIcon_CreateInstance.
[EXPLORER] -Use WM_POPUPSYSTEMMENU to open the system menu of a window. CORE-13400
    • -13
    • +6
    /trunk/reactos/base/shell/explorer/taskswnd.cpp
[EXPLORER] -Fix the return value in HandleShellHookMsg. Suggestion by Christoph.
    • -7
    • +2
    /trunk/reactos/base/shell/explorer/taskswnd.cpp
[EXPLORER] -Revert a hack from r63304 that caused CORE-13388. This hid another bug and the correct way to fix this is to return MA_NOACTIVATE to WM_MOUSEACTIVATE.
    • -5
    • +9
    /trunk/reactos/base/shell/explorer/taskswnd.cpp
[EXPLORER] -Open the start menu on mouse down. Patch by Joachim Henze (reactosfanboy). CORE-13375
    • -2
    • +16
    /trunk/reactos/base/shell/explorer/traywnd.cpp
[UXTHEME] -Implement support for non rectangular caption buttons in WM_NCHITTEST handling. Please note that non rectangular buttons or buttons with no gaps between them are HACKY for XP so hittesting will never work properly (we really mimic windows xp here). Cache the position of caption buttons in the WINDOWINFO. CORE-13171
    • -0
    • +10
    /trunk/reactos/dll/win32/uxtheme/themehooks.c
    • -67
    • +106
    /trunk/reactos/dll/win32/uxtheme/nonclient.c
[UXTHEME] -Fix parsing font styles like bold or italic.
[UXTHEME] -Rename ActiveThemeFile to g_ActiveThemeFile, user32ApiHook to g_user32ApiHook and gbThemeHooksActive to g_bThemeHooksActive.
    • -37
    • +37
    /trunk/reactos/dll/win32/uxtheme/system.c
    • -23
    • +23
    /trunk/reactos/dll/win32/uxtheme/themehooks.c
[COMCTL32] -Fix a lot of tests for the v5 toolbar without braking the behavior of the v6 one (that needs to be tested).
[COMCTL32_APITEST] -Make comctl32v5.manifest really point to the v5 library.
Fix gcc build.
[COMCTL32_APITEST] -Add tests for CCM_GETVERSION and CCM_SETVERSION for the v5 and v6 toolbar control.
    • -0
    • +123
    /trunk/rostests/apitests/comctl32/toolbar.c
    • -0
    • +15
    /trunk/rostests/apitests/comctl32/comctl32v5.manifest
[COMCTL32] -Differentiate between v5 and v6 toolbar and make their CCM_SETVERSION behave correct according to their version.
    • -10
    • +27
    /trunk/reactos/dll/win32/comctl32/commctrl.c
    • -0
    • +4
    /trunk/reactos/dll/win32/comctl32/comctl32.h
    • -0
    • +56
    /trunk/reactos/dll/win32/comctl32/toolbar.c
[EXPLORER] -Implement the trick that makes the start button to get clicked when the user clicks on the corner of the screen.
    • -3
    • +0
    /trunk/reactos/base/shell/explorer/taskswnd.cpp
    • -0
    • +3
    /trunk/reactos/base/shell/explorer/precomp.h
    • -3
    • +0
    /trunk/reactos/base/shell/explorer/trayntfy.cpp
    • -0
    • +58
    /trunk/reactos/base/shell/explorer/traywnd.cpp
[EXPLORER] -Make the taskbar grip get its size from the theme. This fixes one of the last theme related problems in explorer itself. Also simplify some theme drawing code.
    • -40
    • +32
    /trunk/reactos/base/shell/explorer/traywnd.cpp
[EXPLORER] -Reload the theme data only when the orientation changes (we ended up reloading it every few seconds).
    • -15
    • +18
    /trunk/reactos/base/shell/explorer/trayntfy.cpp