khornicek in reactos

[WIN32K]

- really check whether the requested pixel is outside of the surface in NtGdiGetPixel

CORE-12820

    • -1
    • +3
    /trunk/reactos/win32ss/gdi/ntgdi/bitblt.c
[WIN32SS|KBDHID]

- fix some typos and copypastas

    • -1
    • +1
    /trunk/reactos/drivers/hid/kbdhid/kbdhid.c
    • -2
    • +2
    /trunk/reactos/win32ss/gdi/ntgdi/bitblt.c
[SHELL32]

- some tweaks, optimizations and fixes for the free/used disk space pie chart drawing code to properly cover all corner cases and remove minor drawing artifacts

CORE-8757

[NOTEPAD]

- don't allow multiple instances of the find/replace dialog

CORE-13744

[TRANSLATIONS]

- Fix missing shortcuts on desktop for Ukrainian localization.

    • -1
    • +1
    /trunk/reactos/dll/win32/userenv/lang/uk-UA.rc
[TRANSLATIONS]

- Shorten some strings to make MSVC happy.

Somehow this wasn't committed. Sorry.
    • -0
    • +28
    /trunk/reactos/dll/cpl/openglcfg/lang/cs-CZ.rc
[RAPPS]

- Move Mesa 3D to "Libraries"

- Clarify what this library is for and how to use it.

- Add Czech translation.

[OPENGLCFG]

- Add Czech translation.

    • -0
    • +3
    /trunk/reactos/dll/cpl/openglcfg/openglcfg.rc
[NTOS:KD64]

- Fix a copy-pasta.

- Spotted by Sumanai. Thanks!

CORE-12952

[RAPPS]

- Add a custom build of the Mesa 3D Graphics Library. This build contains mesa, gallium and llvmpipe. It provides an enormous performance boost over the software implementation present in opengl32.

- This is meant for platforms with missing, outdated or broken HW OpenGl acceleration.

- Thanks Daniel for helping with the Rapps stuff!

    • -0
    • +15
    /trunk/reactos/media/rapps/mesagallium.txt
[OPENGLCFG]

- Add a simple applet to set a custom OGL ICD or force the use of the built in software implementation.

- It can be used to set the DEBUGCHANNEL to +opengl,+wgl to make obtaining debug info more user friendly.

    • -0
    • +30
    /trunk/reactos/dll/cpl/openglcfg/openglcfg.h
  1. /trunk/reactos/dll/cpl/openglcfg/resources
    • -0
    • +19
    /trunk/reactos/dll/cpl/openglcfg/CMakeLists.txt
    • -0
    • +28
    /trunk/reactos/dll/cpl/openglcfg/lang/en-US.rc
    • -0
    • +23
    /trunk/reactos/dll/cpl/openglcfg/openglcfg.rc
    • -0
    • +20
    /trunk/reactos/dll/cpl/openglcfg/resource.h
    • -0
    • +2
    /trunk/reactos/dll/cpl/openglcfg/openglcfg.spec
    • binary
    /trunk/reactos/dll/cpl/openglcfg/resources/openglcfg.ico
    • -0
    • +197
    /trunk/reactos/dll/cpl/openglcfg/general.c
    • -0
    • +78
    /trunk/reactos/dll/cpl/openglcfg/openglcfg.c
[OPENGL32]

Disclaimer: This code is ReactOS specific and is the complete opposite of what Windows does (tm):

- Add the option to override the default OpenGL driver by a custom driver or to force the use of the built-in software implementation.

- This will allow some more flexibility when running games / apps that depend on OGL.

- This code needs a special entry in the registry so opengl32 behaves as usual by default.

    • -41
    • +111
    /trunk/reactos/dll/opengl/opengl32/icdload.c
    • -2
    • +2
    /trunk/reactos/dll/opengl/opengl32/wgl.c
[WIN32K]

- GreGetDIBitsInternal:

- Prevent an access violation in DIB_FreeConvertedBitmapInfo by initializing the bit count before calling DIB_ConvertBitmapInfo and setting clrUsed.

- Validate input parameters and return correct values - only return number of scan lines if bits are not null and bpp is not zero. Otherwise return 1 on success.

- We now pass more gdi32:GetDIBits and gdi32:bitmap tests.

CORE-9270

    • -27
    • +63
    /trunk/reactos/win32ss/gdi/ntgdi/dibobj.c
[SHELL32]

- Always set the default value in SetDefaultHandler, otherwise it's impossible to create a default association if the key for some reason already exists. This is consistent with what Windows does.

    • -14
    • +11
    /trunk/reactos/dll/win32/shell32/COpenWithMenu.cpp
[WIN32K]

- Clean up after myself. Thanks, Giannis and Thomas.

    • -1
    • +0
    /trunk/reactos/win32ss/user/ntuser/class.c
    • -1
    • +1
    /trunk/reactos/win32ss/gdi/ntgdi/region.c
[NTGDI]

- Check for zero rectangles in REGION_bXformRgn.

CORE-12204

    • -0
    • +4
    /trunk/reactos/win32ss/gdi/ntgdi/region.c
[NTUSER]

- Prevent a null to be passed to UserDereferenceObject in UserSetCursorIconData. CID 1321971

- Make the status check in co_IntCallSentMessageCallback less useless. CID 1322014

- Prevent a null pointer dereference in a trace in IntCreateClass. CID 514617

    • -1
    • +3
    /trunk/reactos/win32ss/user/ntuser/class.c
    • -0
    • +1
    /trunk/reactos/win32ss/user/ntuser/callback.c
    • -3
    • +3
    /trunk/reactos/win32ss/user/ntuser/callproc.c
[NTGDI]

- Consider the return value from IntFillArc in IntArc. CID 1237076

- Remove an useless check in ENTRY_ReferenceEntryByHandle CID 731587

- Prevent an unlikely memory leak in PATH_WidenPath. CID 716634

- Minor cleanup.

    • -8
    • +0
    /trunk/reactos/win32ss/gdi/ntgdi/drawing.c
    • -0
    • +4
    /trunk/reactos/win32ss/gdi/ntgdi/path.c
    • -1
    • +0
    /trunk/reactos/win32ss/gdi/ntgdi/gdiobj.c
    • -9
    • +12
    /trunk/reactos/win32ss/gdi/ntgdi/arc.c
[GDI32]

- Fix a possible null pointer dereference in GetGlyphOutlineA. CID 513747

- SetDIBits should not accept null bitmap info at all. CID 513425

- Don't set the pdwResult pointer itself to null in TADC_GetAndSetDCDWord. CID 1321970

[EVENTLOG]

- Silence some debug prints. This commit bears the "Hermès' seal of approval".

[WIN32K]

- Don't try to delete the pattern bitmap in UserInitialize.

- Set the correct owner before deleting the update region in co_UserFreeWindow.

- Fixes some "Trying to delete global object" debug prints.

    • -2
    • +1
    /trunk/reactos/win32ss/user/ntuser/ntuser.c
    • -0
    • +1
    /trunk/reactos/win32ss/user/ntuser/window.c
[SHELL32]

- Make the "Open with" dialog start in Program Files as is done in Windows (doesn't really changes anything because comdlg32 doesn't expand environment variables).

[WIN32K]

- The pattern bitmap can get deleted during the GDI cleanup for process before the brush itself.

- Gets rid of some of those pesky "GreDeleteObject: Trying to delete invalid object" debug prints.

    • -2
    • +2
    /trunk/reactos/win32ss/gdi/ntgdi/brush.cpp
[PING]

- Addendum to r73626. Convert the print specifiers too so that ping doesn't only output the old specifiers themselves.

[SPIDER]

- Make the formatting a bit more consistent.

[EVENTVWR]

- Remove an useless cast.

[REGEDIT]

- Fix a possible null pointer dereference. CID 731448

- Check string length before copying into a fixed size buffer. CID 515207

- Bail out of _CmdWndProc if keyPath is null. CID 1102164

- Use strsafe functions. CID 1102477

[UMPNPMGR]

- Fix a possible null pointer dereference. CID 515158

[TASKMGR]

- ellipsis is a pointer not an array. CID 1321855

[EVENTVWR]

- Attempt to speed up loading and displaying logs in EnumEventsThread:

- Rewriting the code fix an infinite loop that could happen under low memory conditions (this potentially speeds things up quite a lot).

- Remove ListView subclassing - sorry Hermès but not only it keeps constantly redrawing under Windows but also adds too much overhead.

- Don't read the event log records one by one but in chunks of roughly 0x7ffff bytes (maximum size allowed).

- Use poor man's "caching" of the event user name (optimizing/caching rest of the stuff in the loop didn't yield any significant speed up).

Result: Loading ~40000 records under Win7 went from 4.5 minutes to 65 seconds.

[SPIDER]

- Add a null pointer check. CID 500248

- Check for a memory allocation failure.

- Improve Czech resources.