vgal hid changes

Activity

CR-110 163

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 9h 50m 75 HidClassDequeueInterruptReport is called twice and both t...
    Reviewer - 70% reviewed 2h 32 It's okay as-is. It would just save a few unnecessary lin...
    Reviewer - 0% reviewed 31m    
    Reviewer - 0% reviewed 2h 13m 43 When compiling under the DDK/WDK environment (& using MSV...
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed 38m 11 It is only relevant for functions exported or used as cal...
    Reviewer - 0% reviewed 31m 2 Is it correct? Two if (!ReportId)
    Total   15h 42m 163  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /reactos/drivers/hid/hidclass/fdo.c Changed   108
    Open in IDE #permalink
    /reactos/drivers/hid/hidclass/hidclass.c Changed   5
    Open in IDE #permalink
    /reactos/drivers/hid/hidclass/pdo.c Changed   6
    Open in IDE #permalink
    /reactos/drivers/hid/hidclass/precomp.h Changed   17
    Open in IDE #permalink
    /reactos/drivers/hid/hidusb/hidusb.c Changed   13
    Open in IDE #permalink
    /reactos/drivers/hid/hidusb/hidusb.h Changed   6
    Open in IDE #permalink
    /reactos/drivers/hid/hidusb/hidusb.rc Changed  
    Open in IDE #permalink
    /reactos/drivers/hid/kbdhid/kbdhid.c Changed  
    Open in IDE #permalink
    /reactos/drivers/hid/mouhid/mouhid.c Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbccgp/pdo.c Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbhub/fdo.c Changed  
    Open in IDE #permalink
    /reactos/sdk/lib/drivers/hidparser/api.c Changed  
    Open in IDE #permalink
    /reactos/sdk/.../drivers/hidparser/hidparser.c Changed   8
    Open in IDE #permalink
    /reactos/sdk/.../drivers/hidparser/parser.h Changed  
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against