vgal usbport changes + usb(e/o)hci_new

Activity

CR-111 116

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 22h 20m 54 Fixed
    Reviewer - 28% reviewed 2h 36m 56 Can you please be more specific and add the error message...
    Reviewer - 0% reviewed 7m    
    Reviewer - 22% reviewed 42m    
    Reviewer - 0% reviewed 30m 1 "IsChirpHandled"? or "HandleChirp" (and then 1 would be T...
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 9% reviewed 10m 1 You probably want to use InterlockedExchangePointer, and ...
    Total   26h 26m 116  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /reactos/.../usbehci_new/CMakeLists.txt Changed  
    Open in IDE #permalink
    /reactos/drivers/.../usbehci_new/dbg_ehci.h Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbehci_new/debug.c Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbehci_new/guid.c Changed  
    Open in IDE #permalink
    /reactos/drivers/.../usbehci_new/hardware.h Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbehci_new/roothub.c Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbehci_new/usbehci.c Changed   34
    Open in IDE #permalink
    /reactos/drivers/usb/usbehci_new/usbehci.h Changed   2
    Open in IDE #permalink
    /reactos/drivers/.../usbehci_new/usbehci.rc Changed  
    Open in IDE #permalink
    /reactos/drivers/.../usbhub_new/CMakeLists.txt Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbhub_new/dbg_uhub.h Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbhub_new/debug.c Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbhub_new/guid.c Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbhub_new/ioctl.c Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbhub_new/pnp.c Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbhub_new/power.c Changed   15
    Open in IDE #permalink
    /reactos/drivers/usb/usbhub_new/usbhub.c Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbhub_new/usbhub.h Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbhub_new/usbhub.rc Changed  
    Open in IDE #permalink
    /reactos/.../usbohci_new/CMakeLists.txt Changed  
    Open in IDE #permalink
    /reactos/drivers/.../usbohci_new/dbg_ohci.h Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbohci_new/guid.c Changed  
    Open in IDE #permalink
    /reactos/drivers/.../usbohci_new/hardware.h Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbohci_new/roothub.c Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbohci_new/usbohci.c Changed   1
    Open in IDE #permalink
    /reactos/drivers/usb/usbohci_new/usbohci.h Changed  
    Open in IDE #permalink
    /reactos/drivers/.../usbohci_new/usbohci.rc Changed  
    Open in IDE #permalink
    /reactos/drivers/.../usbport/CMakeLists.txt Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbport/debug.c Changed   2
    Open in IDE #permalink
    /reactos/drivers/usb/usbport/device.c Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbport/endpoint.c Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbport/guid.c Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbport/iface.c Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbport/ioctl.c Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbport/pnp.c Changed   12
    Open in IDE #permalink
    /reactos/drivers/usb/usbport/power.c Changed   42
    Open in IDE #permalink
    /reactos/drivers/usb/usbport/queue.c Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbport/roothub.c Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbport/urb.c Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbport/usb2.c Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbport/usbdebug.h Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbport/usbport.c Changed   2
    Open in IDE #permalink
    /reactos/drivers/usb/usbport/usbport.h Changed   4
    Open in IDE #permalink
    /reactos/drivers/usb/usbport/usbport.rc Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbport/usbport.spec Changed  
    Open in IDE #permalink
    /reactos/.../usbuhci_new/CMakeLists.txt Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbuhci_new/guid.c Changed  
    Open in IDE #permalink
    /reactos/drivers/.../usbuhci_new/hardware.h Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbuhci_new/roothub.c Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbuhci_new/usbuhci.c Changed   2
    Open in IDE #permalink
    /reactos/drivers/usb/usbuhci_new/usbuhci.h Changed  
    Open in IDE #permalink
    /reactos/drivers/.../usbuhci_new/usbuhci.rc Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/CMakeLists.txt Changed  
    Open in IDE #permalink
    /reactos/drivers/usb/usbmport.h Changed  
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against