Implement closing mixer in wdmaud

Activity

CR-113 16

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 51m 3 I think the variable name "EventData" here is misleading....
    Reviewer - 50% reviewed 12m 10 It looks like WdmAudCleanup will do that for us
    Reviewer - 0% reviewed 0m    
    Reviewer - 0% reviewed      
    Reviewer - Complete 12m 3 Can we close this?
    Reviewer - 0% reviewed      
    Reviewer - 50% reviewed 26m    
    Total   1h 42m 16  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Mark Jansen

    Can we close this?

    Can we close this?

    /drivers/wdm/audio/legacy/wdmaud/control.c Changed  
    Open in IDE #permalink
    /drivers/wdm/audio/legacy/wdmaud/mmixer.c Changed   3
    Open in IDE #permalink
    /drivers/wdm/audio/legacy/wdmaud/wdmaud.h Changed   3
    Open in IDE #permalink
    /sdk/lib/drivers/sound/mmixer/controls.c Changed   6
    Open in IDE #permalink
    /sdk/lib/drivers/sound/mmixer/mixer.c Changed   2
    Open in IDE #permalink
    /sdk/lib/drivers/sound/mmixer/mmixer.h Changed  
    Open in IDE #permalink
    /sdk/lib/drivers/sound/mmixer/precomp.h Changed   1
    Open in IDE #permalink
    /reactos/drivers/.../legacy/wdmaud/control.c Changed
    Open in IDE #permalink
    /reactos/drivers/.../legacy/wdmaud/mmixer.c Changed
    Open in IDE #permalink
    /reactos/drivers/.../legacy/wdmaud/wdmaud.h Changed
    Open in IDE #permalink
    /reactos/sdk/lib/.../sound/mmixer/controls.c Changed
    Open in IDE #permalink
    /reactos/sdk/lib/.../sound/mmixer/mixer.c Changed
    Open in IDE #permalink
    /reactos/sdk/lib/.../sound/mmixer/mmixer.h Changed
    Open in IDE #permalink
    /reactos/sdk/lib/.../sound/mmixer/precomp.h Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against