shell32: Fix some bugs of SHGetFileInfoA/W function

Activity

CR-115 10

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator      
    Reviewer - 100% reviewed 22m 4 Undefined behaviour if psfParent is NULL ?
    Reviewer - 100% reviewed 7m    
    Reviewer - 100% reviewed 12m 2 The change to strlen should also not be necessary. -1 doe...
    Reviewer - 100% reviewed 13m 4 If we are changing this, might as well add spaces around ...
    Reviewer - 100% reviewed 1m    
    Total   54m 10  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /dll/win32/shell32/wine/shell32_main.c Changed   10
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against