Improve parameters probing in Cm' NT apis

Activity

CR-119 34

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 1h 9m 20 That's possible. But if not captured, then the user of th...
    Reviewer - 50% reviewed 24m 8 It's hard to tell where "here" is because your patch isn'...
    Reviewer - 0% reviewed      
    Reviewer - 100% reviewed 21m 6 Why the extra probes? ProbeAndCaptureObjectAttributes als...
    Total   1h 53m 34  
    #permalink

    Objectives

    First jet of a patch for CORE-13448, intended to:

    • better probe for invalid user-mode data;
    • correctly differentiate user-mode vs. kernel-mode root directory handles (in OBJECT_ATTRIBUTES).
      Note that most of the Cm* APIs suppose their parameters are kernel-mode.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    HBelusca

    NOTE: A version 1b of the patch with correct anchoring has been uploaded. Ple...

    NOTE: A version 1b of the patch with correct anchoring has been uploaded. Please add the new comments in there. I wasn't able to find a way to "post-anchor" the original patch.

    /ntoskrnl/config/ntapi.c Changed 33
    Open in IDE #permalink
    /ntoskrnl/config/ntapi.c Changed  
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against