RAPPS GSoC Changes, Part 1

Activity

CR-120 93

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 2h 5m 17 How do I handle such situation correctly?
    Reviewer - Complete 10m    
    Reviewer - Complete 54m 24 ok, perhaps it's when you compile in x64 mode.
    Reviewer - 100% reviewed 1h 1m 28 I highly doubt it. If there is a warning, someone show it...
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 100% reviewed 13m    
    Reviewer - 0% reviewed      
    Reviewer - Complete 49m    
    Reviewer - 0% reviewed      
    Reviewer - Complete 35m 23 This can be different per use case. If you need the buffe...
    Reviewer - 77% reviewed 9m 1 This is a personal opinion but since you have two big ors...
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Total   5h 55m 93  
    #permalink

    Objectives

    This is the first set of RAPPS changes for GSoC 2017.
    We can decide whether we want to keep adding new changes to this review or make a new one later.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Alexander Shaposhnikov

    Thank you guys for reviews, everything noted.

    Thank you guys for reviews, everything noted.

    Mark Jansen

    A generic note for CString: If you just want to access the raw string pointer...

    A generic note for CString: If you just want to access the raw string pointer (to read!), use GetString() instead of GetBuffer().

    Alexander Shaposhnikov

    The reason I did use GetBuffer() is that some functions require LPWSTR and I ...

    The reason I did use GetBuffer() is that some functions require LPWSTR and I did not want to use const_cast<LPWSTR>().
    So you say casting is better?

    Mark Jansen

    This can be different per use case. If you need the buffer just to read from ...

    This can be different per use case.
    If you need the buffer just to read from it, use GetString(), if you need the buffer to modify it, use GetBuffer() / ReleaseBuffer().

    If you are going to pass the data to a control that holds on to it (lParam etc) you probably dont want to use a CString at all.

    Alexander Shaposhnikov

    I agree that using GetBuffer() when reading is not pretty. However, original ...

    I agree that using GetBuffer() when reading is not pretty.
    However, original code almost never copied the arrays themselves and passed that local arrays around.
    Perhaps I don't need to copy them?

    /branches/GSoC_2017/.../rapps/lang/en-US.rc Changed 3
    /branches/GSoC_2017/.../rapps/lang/ru-RU.rc Changed 1
    /branches/GSoC_2017/.../rapps/lang/uk-UA.rc Changed 2
    /branches/GSoC_2017/.../rapps/available.cpp Changed 28
    /branches/GSoC_2017/.../rapps/crichedit.h Changed
    /branches/GSoC_2017/.../rapps/gui.cpp Changed 17
    /branches/GSoC_2017/.../rapps/installed.cpp Changed 8
    /branches/GSoC_2017/.../rapps/misc.cpp Changed 23
    /branches/GSoC_2017/.../rapps/rapps.h Changed 5
    /branches/GSoC_2017/.../rapps/resource.h Changed 1
    /branches/GSoC_2017/.../rapps/winmain.cpp Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against