Shell Extensions GSoC Changes, Part 1

Activity

CR-122 129

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 5h 46m 35 Yup... already solved... thanx for mentioning https://cod...
    Reviewer - 100% reviewed 46m 29 I believe that means you should do the same thing that th...
    Reviewer - Complete 39m 6 Make sure you removed handling of button up/down window m...
    Reviewer - 100% reviewed 1h 2m 17 Oki, in that way it's clear we need to generate this GUID...
    Reviewer - 0% reviewed 0m    
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 100% reviewed 16m 1 Nothing wrong with this, just wanted to note that we have...
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - Complete 50m 24 Jira cut off the url (already gave it in irc): https://gi...
    Reviewer - Complete 59m 15 What you mean is aggregation but we tend to avoid it. it ...
    Reviewer - 0% reviewed 0m    
    Total   10h 19m 129  
    #permalink

    Objectives

    This is the first set of Shell Extensions changes for GSoC 2017.
    We can decide whether we want to keep adding new changes to this review or make a new one later.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Shriraj Sawant

    Thank you, everyone, for giving a thorough review of the code. Helped a lot. ...

    Thank you, everyone, for giving a thorough review of the code. Helped a lot. Looking forward to similar and great feedback for the future revisions too.

    /branches/GSoC_2017/.../dll/shellext/qcklnch/ Added
    Open in IDE #permalink
    /branches/GSoC_2017/.../shellext/qcklnch/rgs/ Added
    Open in IDE #permalink
    /branches/GSoC_2017/.../rgs/qcklnch.rgs Added 2
    /branches/GSoC_2017/.../qcklnch/CISFBand.cpp Added 52
    /branches/GSoC_2017/.../qcklnch/CISFBand.h Added 23
    /branches/GSoC_2017/.../qcklnch/CMakeLists.txt Added 7
    /branches/.../qcklnch/CQuickLaunchBand.cpp Added 28
    /branches/.../qcklnch/CQuickLaunchBand.h Added 5
    /branches/GSoC_2017/.../qcklnch/precomp.h Added 1
    /branches/GSoC_2017/.../qcklnch/qcklnch.cpp Added 4
    /branches/GSoC_2017/.../qcklnch/qcklnch.rc Added 4
    /branches/GSoC_2017/.../qcklnch/qcklnch.spec Added
    Open in IDE #permalink
    /branches/GSoC_2017/.../qcklnch/resource.h Added 2
    Open in IDE #permalink
    /branches/.../shellext/CMakeLists.txt Changed
    Open in IDE #permalink
    /branches/GSoC_2017/.../media/inf/syssetup.inf Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against