GET_HASH_ENTRY improvement

Activity

CR-20 1

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 7m    
    Reviewer - Complete 6m    
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Total   13m 1  
    #permalink

    Objectives

    The patch modifies the GET_HASH_ENTRY() macro, so that it returns a pointer instead of a structure, which is counterintuitive and not very function like. It also convert a few macros to inline functions.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Samuel Serapion

    This looks fine, why not committed ? or further tests needed?

    This looks fine, why not committed ? or further tests needed?

    /config/cmkcbncb.c Changed
    Open in IDE #permalink
    /config/cmsysini.c Changed
    Open in IDE #permalink
    /include/internal/cm_x.h Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against