Untitled

Activity

CR-53 4

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 23m 2 I'll keep that in mind for an additional refactoring. Btw...
    Reviewer - Complete 8m 1 Seems fine here too. Just a general remark about your two...
    Reviewer - 100% reviewed 13m    
    Reviewer - 0% reviewed      
    Reviewer - Complete 11m 1 Patch seems ok; think about that too: [01:37:46] <@Piggle...
    Total   54m 4  
    #permalink

    Objectives

    I just want to be told how much I suck and what a bitch I am.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    HBelusca

    Patch seems ok; think about that too: [01:37:46] <@Pigglesworth> https://www....

    Patch seems ok; think about that too:
    [01:37:46] <@Pigglesworth> https://www.youtube.com/watch?v=vQTrdYEaoIU @ tkreuzer

    Pierre Schweitzer

    Seems fine here too. Just a general remark about your two helper functions: c...

    Seems fine here too.
    Just a general remark about your two helper functions: can't you dereference just once into a local variable? Would prevent lots of dereferencing in the code path (for both compiler & reader).

    Timo Kreuzer

    I'll keep that in mind for an additional refactoring. Btw, since it's inlined...

    I'll keep that in mind for an additional refactoring. Btw, since it's inlined the dererence will be entirely eliminated by the compiler.

    /ntoskrnl/mm/ARM3/virtual.c Changed   1
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against