Refactor RtlQueryRegistryValues

Activity

CR-61 1

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 21m    
    Reviewer - 100% reviewed 1m    
    Reviewer - 0% reviewed      
    Reviewer - 100% reviewed 45m    
    Reviewer - 100% reviewed 7m 1 Timo Kreuzer: Was it commited since then?
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Total   1h 14m 1  
    #permalink

    Objectives

    The old implementation was a huge mess. I refactored it completely to make it somewhat readable.
    I also simplified a bunch of things.
    It doesn't really make sense to look "what changed", since everything changed.
    So just check the new implementation and use the old code as a reference.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    HBelusca

    Timo Kreuzer: Was it commited since then?

    Timo Kreuzer: Was it commited since then?

    /lib/rtl/registry.c Changed  
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against