Implement partial support for job objects

Activity

CR-86 41

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 1h 39m 7 This will break out of the case, similar to other cases i...
    Moderator 4m    
    Reviewer - 100% reviewed 48m 7 Samuel Serapion: You said you were working on a new patch...
    Reviewer - 0% reviewed 57m 10 Process->Job == JobObject will still not be true, since ...
    Reviewer - 0% reviewed      
    Reviewer - 92% reviewed 15m 5 The indentation here should line up with the first parameter
    Reviewer - 92% reviewed 3m    
    Reviewer - 100% reviewed 13m 8 Believe it or not, the _SEH2_YIELD(break); construct (and...
    Reviewer - 0% reviewed      
    Reviewer - 100% reviewed 27m 4 It does look a bit weird through (having a break inside t...
    Total   4h 26m 41  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Samuel Serapion

    Thank you all for your comments! I have been reworking various aspects thanks...

    Thank you all for your comments! I have been reworking various aspects thanks to them. I'll be resubmitting an updated patch soon

    Mark Jansen

    Hack committed in 74947 that can probably be removed / reviewed after this.

    Hack committed in 74947 that can probably be removed / reviewed after this.

    Mark Jansen

    Samuel Serapion: You said you were working on a new patch, is the latest vers...

    Samuel Serapion: You said you were working on a new patch, is the latest version attached here or do you have a new revision?

    /include/ndk/pstypes.h Changed   2
    Open in IDE #permalink
    /ntoskrnl/include/internal/ps.h Changed  
    Open in IDE #permalink
    /ntoskrnl/ps/job.c Changed   36
    Open in IDE #permalink
    /ntoskrnl/ps/process.c Changed  
    Open in IDE #permalink
    /job.patch Added
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against