Implement partial support for job objects

Activity

CR-86 46

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 2h 6m 8 Do it quick! Before life catches up to you and you buy a ...
    Moderator 4m    
    Reviewer - 87% reviewed 1h 5m 11 Mainly formatting / dprint pass while I read into this. M...
    Reviewer - 0% reviewed 1h 7m 10 Process->Job == JobObject will still not be true, since ...
    Reviewer - 0% reviewed      
    Reviewer - 12% reviewed 19m 5 The indentation here should line up with the first parameter
    Reviewer - 12% reviewed 3m    
    Reviewer - 16% reviewed 13m 8 Believe it or not, the _SEH2_YIELD(break); construct (and...
    Reviewer - 0% reviewed      
    Reviewer - 62% reviewed 27m 4 It does look a bit weird through (having a break inside t...
    Total   5h 25m 46  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Samuel Serapion

    Thank you all for your comments! I have been reworking various aspects thanks...

    Thank you all for your comments! I have been reworking various aspects thanks to them. I'll be resubmitting an updated patch soon

    Mark Jansen

    Hack committed in 74947 that can probably be removed / reviewed after this.

    Hack committed in 74947 that can probably be removed / reviewed after this.

    Mark Jansen

    Samuel Serapion: You said you were working on a new patch, is the latest vers...

    Samuel Serapion: You said you were working on a new patch, is the latest version attached here or do you have a new revision?

    Mark Jansen

    Mainly formatting / dprint pass while I read into this. More to follow

    Mainly formatting / dprint pass while I read into this.
    More to follow

    Samuel Serapion

    Do it quick! Before life catches up to you and you buy a new computer, fall i...

    Do it quick! Before life catches up to you and you buy a new computer, fall in love, escape an island, get a demanding job, buy a house, get married and such, because then, then the hurricanes will start attacking and your mom will call you 10x per day and and and by the time it's all over you barely can breath let alone run reactos the 6781 times needed to test/develop this thing.

    /include/ndk/pstypes.h Changed   4
    Open in IDE #permalink
    /ntoskrnl/include/internal/ps.h Changed  
    Open in IDE #permalink
    /ntoskrnl/ps/job.c Changed   37
    Open in IDE #permalink
    /ntoskrnl/ps/kill.c Changed  
    Open in IDE #permalink
    /ntoskrnl/ps/process.c Changed  
    Open in IDE #permalink
    /sdk/include/ndk/pstypes.h Changed  
    Open in IDE #permalink
    /job.patch Added
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against