NtUserCreateDesktop rewrite review

Activity

CR-9 26

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 43m 5 I'll add a SetLastNtError call in case ObOpenObjectByName...
    Reviewer - Complete 1h 21 Update comments
    Reviewer - Complete 40m    
    Total   2h 23m 26  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    Giannis Adamopoulos

    You can find many details about this patch here: http://jira.reactos.org/brow...

    You can find many details about this patch here: http://jira.reactos.org/browse/CORE-6723

    /ntoskrnl/ex/win32k.c Changed  
    Open in IDE #permalink
    /ntoskrnl/ps/win32.c Changed  
    Open in IDE #permalink
    /win32ss/gdi/ntgdi/device.c Changed  
    Open in IDE #permalink
    /win32ss/user/ntuser/accelerator.c Changed  
    Open in IDE #permalink
    /win32ss/user/ntuser/callback.c Changed  
    Open in IDE #permalink
    /win32ss/user/ntuser/callproc.c Changed   1
    Open in IDE #permalink
    /win32ss/user/ntuser/class.c Changed   1
    Open in IDE #permalink
    /win32ss/user/ntuser/class.h Changed  
    Open in IDE #permalink
    /win32ss/user/ntuser/clipboard.c Changed  
    Open in IDE #permalink
    /win32ss/user/ntuser/csr.c Changed  
    Open in IDE #permalink
    /win32ss/user/ntuser/cursoricon.c Changed  
    Open in IDE #permalink
    /win32ss/user/ntuser/desktop.c Changed   15
    Open in IDE #permalink
    /win32ss/user/ntuser/desktop.h Changed  
    Open in IDE #permalink
    /win32ss/user/ntuser/event.c Changed  
    Open in IDE #permalink
    /win32ss/user/ntuser/hook.c Changed  
    Open in IDE #permalink
    /win32ss/user/ntuser/input.c Changed  
    Open in IDE #permalink
    /win32ss/user/ntuser/kbdlayout.c Changed  
    Open in IDE #permalink
    /win32ss/user/ntuser/main.c Changed  
    Open in IDE #permalink
    /win32ss/user/ntuser/menu.c Changed   2
    Open in IDE #permalink
    /win32ss/user/ntuser/message.c Changed   1
    Open in IDE #permalink
    /win32ss/user/ntuser/monitor.c Changed  
    Open in IDE #permalink
    /win32ss/user/ntuser/msgqueue.h Changed  
    Open in IDE #permalink
    /win32ss/user/ntuser/object.c Changed   3
    Open in IDE #permalink
    /win32ss/user/ntuser/object.h Changed  
    Open in IDE #permalink
    /win32ss/user/ntuser/simplecall.c Changed   1
    Open in IDE #permalink
    /win32ss/user/ntuser/timer.c Changed  
    Open in IDE #permalink
    /win32ss/user/ntuser/window.c Changed  
    Open in IDE #permalink
    /win32ss/user/ntuser/window.h Changed  
    Open in IDE #permalink
    /win32ss/user/ntuser/winsta.c Changed  
    Open in IDE #permalink
    /win32ss/user/win32csr/desktopbg.c Changed  
    Open in IDE #permalink
    /win32ss/user/win32csr/dllmain.c Changed   1
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against