Shriraj Sawant

  • More
  • CR-123
  • finished reviewing
  • More
  • CR-121
  • finished reviewing
Yup... already solved... thanx for mentioning https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/smile.gif

Yup... already solved... thanx for mentioning

  • More
  • CR-120
  • finished reviewing
That's exactly what I needed, while Giannis had provided me a temporary working solution. Thanx https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/smile.gif EDIT: Ahh, it i...

That's exactly what I needed, while Giannis had provided me a temporary working solution. Thanx

EDIT: Ahh, it indeed conflicts with ATL and all. Besides, I don't think including the entire header is a better alternative, just for this two macro definitions, right.

Hmm... I did that and I am getting Access violation errors and some other stuff. 0_o EDIT: Infact, CComHeapPtr caused problems in case of Left/Right clicks. In the case of handling the clicks, I u...

Hmm... I did that and I am getting Access violation errors and some other stuff. 0_o

EDIT: Infact, CComHeapPtr caused problems in case of Left/Right clicks. In the case of handling the clicks, I used to receive the pidls via dwdata member of TBBUTTON structure. And when I used the CComHeapPtr, as usual it used to auto destroy it. So whenever I clicked the button again (i.e internally the pidl is destroyed.) it gave me access violation errors and hang ups, just like in this case. 0_o The main culprit I guess depends on how TBButton structure handles that dwData member.

Thank you, everyone, for giving a thorough review of the code. Helped a lot. Looking forward to similar and great feedback for the future revisions too. https://code.reactos.org/static/olpro3/2stat...

Thank you, everyone, for giving a thorough review of the code. Helped a lot. Looking forward to similar and great feedback for the future revisions too.

Hmm... I tried to test CISFBand::OnWinEvent() but it is not even called while the program is alive. (i.e. the control doesn't even reach that function when I click the button.) So how to make use o...

Hmm... I tried to test CISFBand::OnWinEvent() but it is not even called while the program is alive. (i.e. the control doesn't even reach that function when I click the button.) So how to make use of this function to avoid subclassing? Besides, how to know which click (left/mid/right) caused the WM_COMMAND? ;P

Oops.. I am getting a 404 error for that link. https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/tongue.gif

Oops.. I am getting a 404 error for that link.

Hmm... I asked the same to Giannis and he said not to mind about this for now. https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/smile.gif

Hmm... I asked the same to Giannis and he said not to mind about this for now.

Hmm... yeah, so any changes required in the interface MAP?

Hmm... yeah, so any changes required in the interface MAP?

Ahh... I am trying to do the following in this code: Generally, a desktop ISF is passed in the first parameter of InitialzieSFB. 1. If pidl is NULL then make the pISF the same one as it is passed....

Ahh... I am trying to do the following in this code:
Generally, a desktop ISF is passed in the first parameter of InitialzieSFB.

1. If pidl is NULL then make the pISF the same one as it is passed.
2. Or if pidl passed is of desktop itself then also same as above.
3. Otherwise first bind and receive the pidl's pISF and use that particular pISF.

Please advise if any simpler solution is there and, of course, a lot of testing is needed.

I think... it will be better to make it a CComHeapPtr. https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/wink.gif

I think... it will be better to make it a CComHeapPtr.

Hmm... needs further clarification.

Hmm... needs further clarification.

yeah.. resolved locally. https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/smile.gif

yeah.. resolved locally.

Yeah sure. I'll note it down. https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/smile.gif

Yeah sure. I'll note it down.

Alright.. I'll note it down and refactor it soon. https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/wink.gif

Alright.. I'll note it down and refactor it soon.

Yeah thanx. Will resolve it soon.

Yeah thanx. Will resolve it soon.

That's why I kept it as a magic value so that someone will notice it and probably define it officially. https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/tongue.gif

That's why I kept it as a magic value so that someone will notice it and probably define it officially.

Hmm... needs testing.

Hmm... needs testing.

Good one. XD

Good one. XD

Yeah indeed, though I went with a shorter name for starters. https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/tongue.gif

Yeah indeed, though I went with a shorter name for starters.

Yes needs error correction, but my confusion is, what shall I return in a case of failure? Since 0 is used as success in this case. Any suggestions? https://code.reactos.org/static/olpro3/2static/i...

Yes needs error correction, but my confusion is, what shall I return in a case of failure? Since 0 is used as success in this case. Any suggestions?

Needs error checking of course. I am still working on it. https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/tongue.gif

Needs error checking of course. I am still working on it.

In the sense, it initializes the internal members of CISFBand.

In the sense, it initializes the internal members of CISFBand.

Please provide further clarifications. https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/tongue.gif

Please provide further clarifications.

Exactly. I had discussed that with Giannis in the beginning. https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/wink.gif

Exactly. I had discussed that with Giannis in the beginning.

Yeah... I generated it using 'Create GUID' tool from visual studio. What fixes are required?

Yeah... I generated it using 'Create GUID' tool from visual studio. What fixes are required?

Hmm? It's MFC right? And afaik is it supported?

Hmm? It's MFC right? And afaik is it supported?

Thanx for mentioning. https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/smile.gif

Thanx for mentioning.