Thomas Faber

[USBPORT]

- Simplify some loops in USBPORT_OpenInterface. No logical changes

    • -60
    • +47
    /trunk/reactos/drivers/usb/usbport/device.c
[USBPORT]

- Rename NumInterfaces to NumEndpoints in USBPORT_OpenInterface

    • -11
    • +11
    /trunk/reactos/drivers/usb/usbport/device.c
[KMTESTS:KERNEL32]

- Add additional file attribute tests. Based on a patch by Katayama Hirofumi MZ.

CORE-13495

    • -6
    • +12
    /trunk/rostests/kmtests/kernel32/kernel32_drv.c
[NTFS]

- Revert ext2 change from r71341, since it's only a drop in the bucket

[NTFS]

- Delete autorun.inf, which SVN decided to improperly merge. See r71342.

- Use trunk's version of the large MCB implementation, which already has Trevor's changes.

    • -11
    • +25
    /branches/GSoC_2016/NTFS/ntoskrnl/fsrtl/largemcb.c
[USBPORT][USBHUB_NEW]

- Add license headers

    • -0
    • +7
    /trunk/reactos/drivers/usb/usbport/pnp.c
    • -0
    • +7
    /trunk/reactos/drivers/usb/usbport/ioctl.c
    • -0
    • +7
    /trunk/reactos/drivers/usb/usbport/iface.c
    • -0
    • +7
    /trunk/reactos/drivers/usb/usbport/queue.c
    • -0
    • +7
    /trunk/reactos/drivers/usb/usbport/usb2.c
    • -0
    • +7
    /trunk/reactos/drivers/usb/usbhub_new/power.c
    • -0
    • +7
    /trunk/reactos/drivers/usb/usbhub_new/pnp.c
    • -0
    • +7
    /trunk/reactos/drivers/usb/usbhub_new/debug.c
    • -0
    • +7
    /trunk/reactos/drivers/usb/usbport/trfsplit.c
    • -0
    • +7
    /trunk/reactos/drivers/usb/usbport/usbport.c
    • -0
    • +7
    /trunk/reactos/drivers/usb/usbport/endpoint.c
    • -0
    • +7
    /trunk/reactos/drivers/usb/usbport/device.c
  1. … 8 more files in changeset.
[USBPORT]

- Begin implementing split transfers. Patch by Vadim Galyant.

    • -41
    • +134
    /trunk/reactos/drivers/usb/usbport/usbport.c
    • -1
    • +37
    /trunk/reactos/drivers/usb/usbport/usbport.h
    • -16
    • +40
    /trunk/reactos/drivers/usb/usbport/queue.c
    • -2
    • +1
    /trunk/reactos/drivers/usb/usbport/endpoint.c
    • -0
    • +329
    /trunk/reactos/drivers/usb/usbport/trfsplit.c
[NTFS]

- Merge to trunk r75746

[NTFS]

- Try to make SVN less confused about merging

[USBPORT]

Patch by Vadim Galyant:

- Move isochronous transfer functions to their own file

- Fix return type of PUSBPORT_COMPLETE_TRANSFER

- Improve some debug prints

    • -0
    • +16
    /trunk/reactos/drivers/usb/usbport/usbport.h
    • -0
    • +26
    /trunk/reactos/drivers/usb/usbport/iso.c
    • -19
    • +9
    /trunk/reactos/drivers/usb/usbport/usbport.c
    • -2
    • +2
    /trunk/reactos/drivers/usb/usbport/queue.c
[NTFS]

- Sync to trunk r75743

    • -765
    • +0
    /branches/GSoC_2016/NTFS/sdk/lib/rtl/srw.c
    • -0
    • +566
    /branches/GSoC_2016/NTFS/sdk/lib/atl/atltypes.h
  1. … 6575 more files in changeset.
There's also of course the option of using a namespace.

There's also of course the option of using a namespace.

[NTOS:MM]

- Improve inaccurate debug print

    • -2
    • +2
    /trunk/reactos/ntoskrnl/mm/ARM3/pool.c
[MBEDTLS]

- Update to version 2.6.0

CORE-13739

    • -162
    • +372
    /trunk/reactos/dll/3rdparty/mbedtls/ssl_srv.c
    • -3
    • +3
    /trunk/reactos/dll/3rdparty/mbedtls/dhm.c
    • -8
    • +113
    /trunk/reactos/dll/3rdparty/mbedtls/ecp.c
  1. … 27 more files in changeset.
[MPG123]

- Update to version 1.25.6

CORE-13739

[LIBPNG]

- Update to version 1.6.32

CORE-13739

    • -10
    • +61
    /trunk/reactos/dll/3rdparty/libpng/docs/INSTALL
    • -30
    • +160
    /trunk/reactos/dll/3rdparty/libpng/pngrutil.c
    • -2
    • +179
    /trunk/reactos/dll/3rdparty/libpng/docs/CHANGES
  1. … 9 more files in changeset.
This seemed better as a switch. There are more RTL languages than just Hebrew.

This seemed better as a switch. There are more RTL languages than just Hebrew.

Do we do this elsewhere? It's kind of weird to add header files (the PCH aside) to this list.

Do we do this elsewhere? It's kind of weird to add header files (the PCH aside) to this list.

This and IsAvailableEnum should either be both macros or both functions

This and IsAvailableEnum should either be both macros or both functions

Spacing looks off

Spacing looks off

Why is this an improvement over having this stuff in rapps.h?

Why is this an improvement over having this stuff in rapps.h?

Was there consensus on the ellipses? I see other strings that still use "..."

Was there consensus on the ellipses? I see other strings that still use "..."

This doesn't make sense grammatically. Presumably other languages will have the same problem. Not sure what the right approach is... revert to English? Check with individual translators?

This doesn't make sense grammatically. Presumably other languages will have the same problem.
Not sure what the right approach is... revert to English? Check with individual translators?

missing newline. Double-check for this kind of problem in all files please.

missing newline. Double-check for this kind of problem in all files please.

Not sure what the point of all these style changes is

Not sure what the point of all these style changes is

The constructor must set this to null, and this should check for null before calling FreeLibrary

The constructor must set this to null, and this should check for null before calling FreeLibrary

m_

m_

This might be more readable with if-else if instead of double ?:

This might be more readable with if-else if instead of double ?:

'inline' here does nothing.

'inline' here does nothing.

const on a return type doesn't make sense. Doesn't this produce a warning? Consider const on the function though.

const on a return type doesn't make sense. Doesn't this produce a warning?
Consider const on the function though.