Thomas Faber

[USBHUB_NEW]

- Fix interval calculation in USBH_Wait. Patch by Vadim Galyant.

[CMIDriver]

- Set svn:eol-style to CRLF for inf files. Files that end up on the iso should never have 'native' line endings.

[DDK]

- Fix calling convention for NDIS_PROC. Fixes stack corruption when running 3rd party network drivers

CORE-13685 #resolve

[USETUP]

- Include some actually useful information when printing errors

[ACPICA]

- Update to version 20170728

CORE-13625 #resolve

  1. … 38 more files in changeset.
[0.4.6]

- Merge regedit fix (r75458) by Joachim & Mark

CORE-13071

[0.4.6]

- Revert r75061 (wined3d sync) due to unresolved regressions

CORE-13486

  1. … 55 more files in changeset.
[0.4.6]

- Merge NFS symbolic link fix (r75451) by Pierre

CORE-13615

[0.4.6]

- Revert r73436 to avoid trouble with VirtualBox Guest Additions.

CORE-13172 CORE-12700 CORE-12765

[0.4.6]

- Apply the WordPad icon hack by Jared Smudde

CORE-5823

[0.4.6]

- Mask WndProc exceptions

CORE-11915

[0.4.6]

- Set version number for RC1

[0.4.6]

- Branch for the release

  1. … 27681 more files in changeset.
[DLLS]

- Fix import order

- Remove unnecessary imports

[ACPICA]

- Update to version 20170629

CORE-13538 #resolve

  1. … 6 more files in changeset.
[USBPORT]

Patch by Vadim Galyant:

- Improve variable naming

- Make more consistent use of constants

    • -33
    • +29
    /trunk/reactos/drivers/usb/usbport/usbport.c
    • -11
    • +7
    /trunk/reactos/drivers/usb/usbport/usbport.h
    • -1
    • +1
    /trunk/reactos/drivers/usb/usbport/pnp.c
    • -7
    • +7
    /trunk/reactos/drivers/usb/usbport/debug.c
    • -2
    • +2
    /trunk/reactos/drivers/usb/usbport/roothub.c
I believe that means you should do the same thing that this line does with IOleWindow also with IDockingWindow

I believe that means you should do the same thing that this line does with IOleWindow also with IDockingWindow

The way InitializeSFB is currently implemented, it does take ownership. I think that's unusual for a COM interface though. InitializeSFB should probably do an ILClone, and its caller should free th...

The way InitializeSFB is currently implemented, it does take ownership. I think that's unusual for a COM interface though. InitializeSFB should probably do an ILClone, and its caller should free the original pidl.

Right, this was before I read the implementation. If it stays the way it's currently implemented, a common base class is not needed.

Right, this was before I read the implementation. If it stays the way it's currently implemented, a common base class is not needed.

And really it's == 0, it can't be less since it's unsigned

And really it's == 0, it can't be less since it's unsigned

As opposed to half the attribute length?

As opposed to half the attribute length?

There's actually a downside to doing it now: it breaks special pool's ability to detect uses after free (because the allocations aren't actually freed when you return them to the lookaside list)

There's actually a downside to doing it now: it breaks special pool's ability to detect uses after free (because the allocations aren't actually freed when you return them to the lookaside list)

It's hard to tell where "here" is because your patch isn't anchored :\

It's hard to tell where "here" is because your patch isn't anchored :\

Unnecessary change

Unnecessary change

Isn't that simply a performance optimization?

Isn't that simply a performance optimization?

This is IUnknown_QueryInterface (that's the C macro name for this call) https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/wink.gif

This is IUnknown_QueryInterface (that's the C macro name for this call)

Or just if (KeyValueInformationClass > KeyValuePartialInformationAlign64)

Or just if (KeyValueInformationClass > KeyValuePartialInformationAlign64)

Not clear on why this needs to be a parameter

Not clear on why this needs to be a parameter

Looking at the current code, nothing that would need to be freed can possibly have been set at this point.

Looking at the current code, nothing that would need to be freed can possibly have been set at this point.

You zeroed it above so don't technically need this

You zeroed it above so don't technically need this