Aman Priyadarshi

I have uploaded a new diff file https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/smile.gif

I have uploaded a new diff file

I forget to remove this. I used it for StorPoolAllocate, but now when we are not using StorPoolAllocate.

I forget to remove this.
I used it for StorPoolAllocate, but now when we are not using StorPoolAllocate.

Actually, I do maintain this habit so when writing without any IDE. This reduces error chances of assigning pointer to wrong variable. Compiler warn me, if the caste type does not look like left ha...

Actually, I do maintain this habit so when writing without any IDE.
This reduces error chances of assigning pointer to wrong variable.
Compiler warn me, if the caste type does not look like left hand side type.

Also, It does not affect efficiency, so Is it bad idea?

hahaa, I copy function description header https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/tongue.gif so forget to sometime update it https://code.reactos.org/static/olpro...

hahaa, I copy function description header
so forget to sometime update it

I have written <= intentionally (for (i = 1; i <= MAXIMUM_AHCI_PORT_COUNT; i++)) – sanity, I was about to add DebugPrint in final return of function, because that's a invalid case. I want function ...

I have written <= intentionally (for (i = 1; i <= MAXIMUM_AHCI_PORT_COUNT; i++)) – sanity, I was about to add DebugPrint in final return of function, because that's a invalid case. I want function to return from the for-loop body itself

It should be adapterExtension->PortExtension[nextPort]

It should be adapterExtension->PortExtension[nextPort]

Right, will fix it.

Right,

will fix it.

It's actually related to address (32 bit or 64 bit) HBA is using to communicate with the driver. If CAP.S64A is set to 1, then It should be ready to deal with 64 bit address both for Command List, ...

It's actually related to address (32 bit or 64 bit) HBA is using to communicate with the driver.
If CAP.S64A is set to 1, then It should be ready to deal with 64 bit address both for Command List, and DMA.

Better I add a Storport not implemented warning or something if bit is set.

xD If you notice it carefully Every if clause followed by StorPortDebugPrint has this style and rest of code follow the braces code-styling rues https://code.reactos.org/static/olpro3/2static/image...

xD If you notice it carefully
Every if clause followed by StorPortDebugPrint has this style and rest of code follow the braces code-styling rues

will fix it

Sounds good. thanks https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/smile.gif

Sounds good.
thanks

Right

Right

Your concern is right, but when I implement ATA/ATAPI read buffer SRB functions, It will need a optimized clear function. clearing up 128KB (Maximum transfer limit) will be significantly faster wit...

Your concern is right, but when I implement ATA/ATAPI read buffer SRB functions, It will need a optimized clear function.
clearing up 128KB (Maximum transfer limit) will be significantly faster with this implementation.

We can't use it, no such function exist for miniport driver.

We can't use it, no such function exist for miniport driver.

does it really matter? I feel cool with Hexadecimal numbers https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/tongue.gif Although 0x1 is equivalent to 1

does it really matter?
I feel cool with Hexadecimal numbers
Although 0x1 is equivalent to 1

haha xD eagle eye https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/tongue.gif

haha xD
eagle eye

Although documentations doesn't say anything about other bits during we send a restart command. But I guess It would be better if we check for first bit only in that case: if ((StorPortReadRegister...

Although documentations doesn't say anything about other bits during we send a restart command.
But I guess It would be better if we check for first bit only
in that case:

if ((StorPortReadRegisterUlong(adapterExtension, &abar->GHC) & AHCI_Global_HBA_CONTROL_HR) == 0)
    break;
usually I do care about this, silly mistake again https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/tongue.gif will fix it https://code.reactos.org/static/olpro3/2static/i...

usually I do care about this, silly mistake again

will fix it

That can be an extra assert condition. because this function is called by AhciFindAdapter only. And before calling this adapter I am checking for portImplemented count, Because if a device reports ...

That can be an extra assert condition. because this function is called by AhciFindAdapter only.
And before calling this adapter I am checking for portImplemented count, Because if a device reports portImplemented == 0, then device is invalid

this is so awesome :o https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/tongue.gif Okay will do it https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticon...

this is so awesome :o
Okay will do it

Right

Right

oh https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/tongue.gif Okay

oh Okay

Even I am not very much sure https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/tongue.gif comment syntax says ';' Anyways, will fix this

Even I am not very much sure
comment syntax says ';'
Anyways, will fix this

Right

Right

Right

Right

I made this indentation intentionally It makes it more readable, all three parts of for loop and also properly differentiate two statements of conditional block.

I made this indentation intentionally
It makes it more readable, all three parts of for loop and also properly differentiate two statements of conditional block.

Right, take a look at comment storahci.h where I have made declaration of this function.

Right, take a look at comment storahci.h where I have made declaration of this function.

not possible! check line 514 https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/smile.gif

not possible!
check line 514

Windows look for [storahci] if platform dependent section (.x86, .amd) are not found. Although we have x86 section here, but I have seen windows has used this type of empty section in many INFs may...

Windows look for [storahci] if platform dependent section (.x86, .amd) are not found.
Although we have x86 section here, but I have seen windows has used this type of empty section in many INFs maybe to maintain continuity of sections?
I don't have any problem in removing this

Actually I am planning to implement more optimized version of AhciZeroMemory. pseudo code: for i = 0 -> (bufferSize/4) ((PULONG)buffer)[i] = 0 for i = 0 -> bufferSize%4 buffer[i] = 0

Actually I am planning to implement more optimized version of AhciZeroMemory.
pseudo code:
for i = 0 -> (bufferSize/4)
((PULONG)buffer)[i] = 0
for i = 0 -> bufferSize%4
buffer[i] = 0