Implement DNS cache service
Implement DNS cache service
I know, but it doesn't give me option to what to anchor it... It does it automatically

I know, but it doesn't give me option to what to anchor it... It does it automatically

Can we discuss this if there is a problem? I'm not sure if QEMU can boot full ROS at this point and I really don't know what to place in the table to break it and for that to work I have to recalcu...

Can we discuss this if there is a problem?
I'm not sure if QEMU can boot full ROS at this point and I really don't know what to place in the table to break it and for that to work I have to recalculate also RSDP checksum, and...
Plus this doesn't fail boot if tables fail to create, just DRPINT1.

Not sure if I have to encode it if it is not or just fail.

Not sure if I have to encode it if it is not or just fail.

Fixed locally

Fixed locally

Just tried. RtlIntegerToUnicodeString doesn't add leading zeros.

Just tried. RtlIntegerToUnicodeString doesn't add leading zeros.

Fixed locally.

Fixed locally.

It does the same thing, but is not defined in wdm.h, but in rtlfuncs.h Not sure if I can use it

It does the same thing, but is not defined in wdm.h, but in rtlfuncs.h
Not sure if I can use it

I can't find RtlUnicodeStringFromAsciiz in ROS. Which header it is in?

I can't find RtlUnicodeStringFromAsciiz in ROS.
Which header it is in?

oops. thanks for noticing

oops. thanks for noticing

There is nothing to validate it against. Or just SEH read check?

There is nothing to validate it against. Or just SEH read check?

No reason. Just used to that format

No reason. Just used to that format

Hum. Have to check

Hum. Have to check

Yes

Yes

Does acpi_create_registry_tables sound better?

Does acpi_create_registry_tables sound better?

Sure, but OemId and OemTableId are local parameters valid only in context of the function https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/sad.gif

Sure, but OemId and OemTableId are local parameters valid only in context of the function

I don't see it hackish, but IMHO it will simplify code. Technically here is no actual issue, but just a question if you would like my proposal to simplify code. But it is your code https://code.rea...

I don't see it hackish, but IMHO it will simplify code.
Technically here is no actual issue, but just a question if you would like my proposal to simplify code.
But it is your code
Technically it can still be while (start < end) and have a check inside if (!p) break;

Add missing ACPI registry keys with ACPI tables
Add missing ACPI registry keys with ACPI tables
And if we catch him? Then what?

And if we catch him? Then what?

So what? You can initialize it as 0xDEADBEAF and it will enter if start < end

So what? You can initialize it as 0xDEADBEAF and it will enter if start < end

Unused?

Unused?

uh uh Not supported fine, but ASSERT...

uh uh Not supported fine, but ASSERT...

str safe compare?

str safe compare?

str safe compare?

str safe compare?

MAGIC comment?

MAGIC comment?

_countof?

_countof?

This file needs its own .h

This file needs its own .h

sizeof(*pData)? I know it is a matter of personal preference...

sizeof(*pData)? I know it is a matter of personal preference...

szLayer is WCHAR[], but initialized with ANSI UNICODE_NULL? Also you allocate with HEAP_ZERO_MEMORY...

szLayer is WCHAR[], but initialized with ANSI UNICODE_NULL?
Also you allocate with HEAP_ZERO_MEMORY...