Hermes Belusca-Maito

[README]

- Show our URLs using https.

- Add a "FAQ" section to point to the corresponding website URL; feel free to improve the section!

    • -6
    • +15
    /trunk/reactos/boot/bootdata/readme.txt
[CRT]: Fix typo. Thanks DopefishJustin:)
    • -1
    • +1
    /trunk/reactos/sdk/lib/crt/stdlib/abort.c
[DOSKEY]

Our kernel32.lib already exports all of the console API and in particular the console history API, so we can directly link doskey against it and use them, instead of delay-loading at runtime. We just need to add their prototypes in the source code since they are not declared by wincon.h by default.

[SHELL32]: We are not Windows! (and not completely Wine either).
    • -1
    • +1
    /trunk/reactos/dll/win32/shell32/lang/hu-HU.rc
    • -1
    • +1
    /trunk/reactos/dll/win32/shell32/lang/he-IL.rc
    • -1
    • +1
    /trunk/reactos/dll/win32/shell32/lang/sq-AL.rc
    • -1
    • +1
    /trunk/reactos/dll/win32/shell32/lang/ko-KR.rc
    • -1
    • +1
    /trunk/reactos/dll/win32/shell32/lang/zh-TW.rc
    • -1
    • +1
    /trunk/reactos/dll/win32/shell32/lang/fr-FR.rc
    • -1
    • +1
    /trunk/reactos/dll/win32/shell32/lang/uk-UA.rc
    • -1
    • +1
    /trunk/reactos/dll/win32/shell32/lang/ja-JP.rc
    • -1
    • +1
    /trunk/reactos/dll/win32/shell32/lang/sk-SK.rc
    • -1
    • +1
    /trunk/reactos/dll/win32/shell32/lang/en-US.rc
    • -1
    • +1
    /trunk/reactos/dll/win32/shell32/lang/ca-ES.rc
    • -1
    • +1
    /trunk/reactos/dll/win32/shell32/lang/da-DK.rc
    • -1
    • +1
    /trunk/reactos/dll/win32/shell32/lang/el-GR.rc
    • -1
    • +1
    /trunk/reactos/dll/win32/shell32/lang/no-NO.rc
    • -1
    • +1
    /trunk/reactos/dll/win32/shell32/lang/sl-SI.rc
  1. … 7 more files in changeset.
[HAL]

Update the PCI hardware IDs database. Extracted from the pci.ids database from http://pci-ids.ucw.cz/ from 2016-08-26 03:15:02

Maintained by Albert Pool, Martin Mares, and other volunteers from the PCI ID Project at http://pci-ids.ucw.cz/.

CORE-11903 #resolve

Fix translation (cf. r72465) CORE-11763
[CMAKE]: Update baseaddress_msvc.cmake with the updated scripts from CORE-11382 , with RTC1 enabled so that we get a bit of space margin. Dedicated to Thomas Faber :)

    • -355
    • +356
    /trunk/reactos/sdk/cmake/baseaddress_msvc.cmake
[IERUNONCE]: CORE-11763 #comment Addendum to r72456 : comment out one of the IDS_INCORRECTFORMAT strings (since only one can exist at a time!). Somebody (Sergey?) should choose the best translation between the two. Also re-add the original IDS_NOEXPORT string that just vanished out.
    • -1
    • +2
    /trunk/reactos/dll/win32/iernonce/lang/ru-RU.rc
[TRANSLATIONS]: Update russian translation, by 'amber'.

CORE-11510 #comment Only the translations that did not collide with existing ones were committed! Please recheck :)

    • -8
    • +8
    /trunk/reactos/dll/win32/devmgr/lang/ru-RU.rc
    • -9
    • +9
    /trunk/reactos/dll/cpl/sysdm/lang/ru-RU.rc
[SHORTCUTS]: Update russian translations, by 'amber'.

CORE-11510

    • -0
    • +2
    /trunk/reactos/media/inf/shortcuts.inf
[TRANSLATIONS][ACPPAGE][IERNONCE]: Update ReactOS russian translation, by Sergey Stopkin.

CORE-11763 #resolve #comment Committed, thanks!

    • -1
    • +3
    /trunk/reactos/dll/win32/iernonce/iernonce.rc
    • -0
    • +41
    /trunk/reactos/dll/shellext/acppage/lang/ru-RU.rc
    • -0
    • +29
    /trunk/reactos/dll/win32/iernonce/lang/ru-RU.rc
[TRANSLATIONS][USETUP][EXPLORER]: Update ReactOS russian translation, by Kudratov Olimjon. Part 2

CORE-11636

    • -9
    • +9
    /trunk/reactos/base/setup/usetup/lang/ru-RU.h
[TRANSLATIONS]: Update ReactOS russian translation, by Kudratov Olimjon. Part 1

CORE-11636

    • -11
    • +11
    /trunk/reactos/dll/win32/shell32/lang/ru-RU.rc
    • -1
    • +1
    /trunk/reactos/dll/cpl/appwiz/lang/ru-RU.rc
    • -6
    • +6
    /trunk/reactos/dll/win32/devmgr/lang/ru-RU.rc
    • -1
    • +1
    /trunk/reactos/media/rapps/cstalin.txt
  1. … 5 more files in changeset.
[BOOTDATA]

- Remove invalid "ServiceType" registry value of the MPU401 driver.

- Fix MUP driver group.

- Fix MountMgr driver group.

- Fix rosfltmgr driver group.

- Add "Base" group list (until we have it inside some driver inf).

- Add tags for acpi, pci, null, beep and ksecdd drivers.

    • -0
    • +1
    /trunk/reactos/drivers/base/beep/beep_reg.inf
    • -7
    • +12
    /trunk/reactos/boot/bootdata/hivesys.inf
    • -1
    • +1
    /trunk/rosapps/drivers/green/green.inf
[CMAKE]: Update baseaddress_msvc.cmake with the updated scripts from CORE-11382 , after the recent translations of some of the message compiler files.
    • -346
    • +360
    /trunk/reactos/sdk/cmake/baseaddress_msvc.cmake
[EVENTLOG]

- Get rid of MyHeap.

- Continue using safe string functions.

- Allow event logs themselves to be their own source. And store the full list of log sources in the "Sources" registry multi-string value.

- Correctly compute the number of records.

- Correctly return the event number and the write timestamp of reported events.

- Use a helper function for ElfrReportEventW/A and for ElfrReportEventAndSourceW that is now implemented.

- Rewrite the file.c functions using NT-APIs almost exclusively for file operations.

- Modify the logic of LogfReadEvents so that a RecordNumber == 0 in sequential read mode means we need to determine where to start the read operation, depending on whether a forwards-read or a backwards-read is performed. The log handle's CurrentRecord member is therefore initialized to 0 before usage.

- Adjust LogfAllocAndBuildNewRecord to take in input the event generation timestamp.

- Do not "compute" the RecordNumber of the new event in LogfAllocAndBuildNewRecord; it will be consistently assigned by LogfWriteRecord.

- Correctly initialize the OldestRecordNumber to zero for new (empty) logs.

- Perform extensive log validity checks when opening existing logs: log header and EOF record as well as boundary checks.

- Rewrite almost of the functions to support event log wrapping (see https://msdn.microsoft.com/en-us/library/windows/desktop/bb309026(v=vs.85).aspx ) and splitted records. Now our event logs are not corrupted anymore, and are readable under Windows 2k/xp/2k3/Vista+.

- As a consequence of supporting wrapping event logs we need to iterate through them at loading time in order to locate the valid EOF record (indeed it may happen that the log header is not correctly synced, and its Start/EndOffsets are invalid. The EOF record offsets contain on the other way the correct values).

The file.c fixes are a bit still work-in-progress, but the bulk of the code works. It is extensively tested in situ in my local VM since 2 months now.

CORE-11843 #resolve

    • -29
    • +30
    /trunk/reactos/base/services/eventlog/eventlog.h
    • -642
    • +1338
    /trunk/reactos/base/services/eventlog/file.c
    • -12
    • +16
    /trunk/reactos/base/services/eventlog/logport.c
    • -55
    • +54
    /trunk/reactos/base/services/eventlog/eventlog.c
[ROSTESTS]: Add an interactive test that tests some parts of the event log service.

CORE-11843 CORE-11838

    • -0
    • +1
    /trunk/rostests/win32/advapi32/CMakeLists.txt
    • -0
    • +102
    /trunk/rostests/win32/advapi32/eventlog/MyEventProvider.mc
    • -0
    • +21
    /trunk/rostests/win32/advapi32/eventlog/CMakeLists.txt
    • -0
    • +468
    /trunk/rostests/win32/advapi32/eventlog/EvtLogTest.c
[ROSTESTS]: Update the code file header.
[SDK:MC]: Ensure the EOL style of MC files is *always* CR-LF in *all* platforms.
[EVENTLOG]

- Use NT functions to retrieve timestamps for events.

- Log kernel events with the current computer name.

- Don't hardcode variables types for sizeofs.

- Add type-checks for the data to be retrieved from the registry, and use default values in case the values do not exist or are invalid.

- Use ULONG_PTR to perform pointer arithmetics.

- Use string-safe functions for copy/concatenation.

- Cache EventLog source for eventlog service self-logging.

- Unlock the LogFile in LogfClearFile.

- Fix rounding in LogfAllocAndBuildNewRecord.

- Verify ELF handle validity in ElfrGetLogInformation.

- Implement IELF_HANDLE_rundown to correctly cleanup ELF handles when client apps shut down. Adapt also the parameter of ElfDeleteEventLogHandle for reusing it there.

- Update some code formatting.

CORE-11842 #resolve

I don't completely touch file.c as it contains most of my upcoming eventlog fixes...

    • -274
    • +310
    /trunk/reactos/base/services/eventlog/file.c
    • -153
    • +185
    /trunk/reactos/base/services/eventlog/rpc.c
    • -71
    • +61
    /trunk/reactos/base/services/eventlog/eventlog.h
    • -17
    • +26
    /trunk/reactos/base/services/eventlog/logport.c
    • -127
    • +169
    /trunk/reactos/base/services/eventlog/eventlog.c
[EVENTLOG]: Fix also ElfrChangeNotify here. Addendum to r72211. Must fix the build.

CORE-11839

[SDK:IDL]: Fix the event log RPC IDL file definitions:

- ElfrChangeNotify takes a IELF_HANDLE handle as its first parameter, not a pointer to it.

- Since we already use NT-like types (especially for USHORT variables), do the same for the other parameters (DWORD -> ULONG), and also use the Pxxx for pointers to xxx.

- Use Windows 2003 maximum size (0x3FFFF) for the event data to be written, instead of the Vista+ limit that is much smaller (0xF000). See also revisions r72207 and r72209.

CORE-11839 #resolve

[SDK]: Move some event log flags to the correct header (from winbase.h to winnt.h).

CORE-11839

    • -10
    • +1
    /trunk/reactos/sdk/include/psdk/winbase.h
[ADVAPI32_APITEST]: Addendum to r72207:

- Fix the tests so that they test what they have to test, on ReactOS & Windows 2k3/XP. (Note that here, ReactOS used the more restrained event size limitations of Vista+ compared to those of Win2k3. I choose to test, and will implement, the size limitations of Win2k3.)

- Choose a different name for the test such that it doesn't collide with the 'eventlog' test from advapi32_winetest.

CORE-11838 CORE-11839

[ADVAPI32_APITEST]: Add some supplemental tests for Winetests' Event Logging functions, testing different RPC limits related to the maximum size of the data buffer in events.

CORE-11838 CORE-11839

    • -0
    • +91
    /trunk/rostests/apitests/advapi32/eventlog.c
Remove extra ending semicolons in our C code base.
    • -1
    • +1
    /trunk/reactos/win32ss/user/ntuser/sysparams.c
[INPUT]

- Fix misspelling "Dublicate" -> "Duplicate".

- Use ZeroMemory instead of memset(..., 0, ...).

- Don't hardcode most of the variable types for sizeof.

    • -3
    • +3
    /trunk/reactos/dll/cpl/input/input_list.c
    • -3
    • +3
    /trunk/reactos/dll/cpl/input/locale_list.c
    • -4
    • +4
    /trunk/reactos/dll/cpl/input/settings_page.c
    • -3
    • +3
    /trunk/reactos/dll/cpl/input/layout_list.c
[ADVAPI32]: Addendum to r72151: It's incorrect to compare the variable of BOOL type with TRUE. Any non-zero value is considered to be "true". Caught by Thomas.
[ADVAPI32]: Don't directly redirect IsTextUnicode to RtlIsTextUnicode, but use a helper function, so that the return value is correctly set to TRUE or FALSE. Indeed the former function returns a BOOL (long) while the latter returns a BOOLEAN (byte), and the high bytes in the return value could not be correctly set otherwise.

Adapted from a patch by 'andy-123'.

CORE-11803 #resolve #comment Fixesd, thanks!

    • -1
    • +1
    /trunk/reactos/dll/win32/advapi32/advapi32.spec
    • -0
    • +36
    /trunk/reactos/dll/win32/advapi32/misc/unicode.c
[SDK][RTL][NDK]: Update RtlIsTextUnicode prototype.
    • -3
    • +3
    /trunk/reactos/sdk/include/ndk/rtlfuncs.h