Hermes Belusca-Maito

ReactOS 0.4.3 was released! Tag its repo.
  1. … 26778 more files in changeset.
[SERVICES]: Addendum to r73433 for ScmStartUserModeService:

- Use the correct capitalization for the desktop name (to be consistent with all the rest of our code);

- Fix DPRINT1 order of arguments;

- Reorganize a bit the code to avoid the memory leak if ImpersonateLoggedOnUser fails and the environment block was already allocated (caught by Ged Murphy).

CORE-12414

    • -26
    • +35
    /trunk/reactos/base/system/services/database.c
Fix for source code file header, sorry for commit noise.
[ADVAPI32_APITEST]: Test for a (correctly initialized) service process environment block, that should contain both ALLUSERSPROFILE and USERPROFILE environment variables.

CORE-12414

    • -0
    • +259
    /trunk/rostests/apitests/advapi32/ServiceEnv.c
[ADVAPI32_APITEST]: Add a small helper lib 'svchlp' for common routines for test-services embedded in api tests. Taken & heavily adapted from Jacek Caban's services_service test and Thomas Faber's ServiceArgs.c (the latter will be able to use 'svchlp' when it'll be ready).

CORE-12414

    • -0
    • +73
    /trunk/rostests/apitests/advapi32/svchlp.h
[NTDLL]: Export _wcstoui64 (as done in Win2k3). Prototype from msvcrt. CORE-12534
    • -1
    • +1
    /trunk/reactos/dll/ntdll/def/ntdll.spec
[NTDLL]: Add proper stubs for EtwpGetTraceBuffer and EtwpSetHWConfigFunction, needed for CORE-12534.

[NTDLL][ADVAPI32]: Improve the prototypes for EtwReceiveNotificationsA/WmiReceiveNotificationsA and EtwReceiveNotificationsW/WmiReceiveNotificationsW.

    • -2
    • +2
    /trunk/reactos/dll/win32/advapi32/advapi32.spec
    • -4
    • +4
    /trunk/reactos/dll/ntdll/def/ntdll.spec
[ADVAPI32_APITEST]: Rename the 'LockDatabase' test to 'LockServiceDatabase' to better match the name of the API.
    • -761
    • +0
    /trunk/rostests/apitests/advapi32/LockDatabase.c
[USERENV]: Use ARRAYSIZE instead of hardcoding the sizes of the static buffers.
    • -25
    • +25
    /trunk/reactos/dll/win32/userenv/setup.c
[ROSTESTS]: advapi32_apitest: Add a test to extensively test services command-line arguments. By Thomas Faber.

[ADVAPI32]: Correctly set up both the ANSI and UNICODE service command-line arguments. Adapted from a patch by Thomas Faber. Thanks!

[SERVICES]

- Correctly pack the service command-line arguments in the control packet structure. In particular, the offsets stored in the vector are relative to the beginning of the vector (and not relative to the previous offset ^^). Improve comments...

- Fix the definition of the SCM_CONTROL_PACKET control packet structure to make it Win2k3-compatible, so that we can use Win2k3' advapi32.dll or services.exe on ReactOS and vice-versa.

CORE-9235 CORE-9838

    • -23
    • +28
    /trunk/reactos/base/system/services/database.c
    • -0
    • +475
    /trunk/rostests/apitests/advapi32/ServiceArgs.c
[SERVICES]:

- Fix build.

- Remove now deprecated code (since we use RPC for service commands since revision r13xxx).

    • -179
    • +0
    /trunk/reactos/base/system/services/services.c
[SERVICES]

- The new ScmDeleteServiceKey (r73400) and the already existing ScmDeleteRegKey are the same functions: remove the old ScmDeleteRegKey and use ScmDeleteServiceKey instead AND rename ScmDeleteServiceKey to ScmDeleteRegKey (as it can be used generically within services.exe).

- Call RegDeleteKeyW for the subkey after we have closed its opened handle.

    • -12
    • +16
    /trunk/reactos/base/system/services/config.c
    • -2
    • +2
    /trunk/reactos/base/system/services/rpcserver.c
    • -49
    • +0
    /trunk/reactos/base/system/services/database.c
[LSASRV]: Use LsapAllocateHeapZero to initialize the AllocateLsaHeap member of the LSA auth DispatchTable. Should fix login (this means some of the code calling DispatchTable->AllocateLsaHeap expect zero-initialized memory). Addendum to r73330.

CORE-12432

    • -1
    • +1
    /trunk/reactos/dll/win32/lsasrv/authpackage.c
[LSASRV]: Implement a simplified version of LsaIAllocateHeap / LsaIAllocateHeapZero / LsaIFreeHeap.

CORE-12432

    • -8
    • +10
    /trunk/reactos/dll/win32/lsasrv/authpackage.c
[LSASRV]: Whitespace fixes only.
    • -147
    • +147
    /trunk/reactos/dll/win32/lsasrv/lsasrv.spec
[LSASRV]: Revert part of r73233: GetModuleHandle(NULL) retrieves the exe module in which the dll is loaded, not the dll instance itself. (an alternative might be to use the hinstance from DllMain...). Thanks Thomas for having pointed this to me.
    • -1
    • +1
    /trunk/reactos/dll/win32/lsasrv/lookup.c
[LSASRV]

- No need to hardcode the name of the dll in the GetModuleHandleW call;

- Use ARRAYSIZE instead of hardcoding string buffer sizes;

- When initializing the "Network Sid", use the correct localized string.

    • -43
    • +43
    /trunk/reactos/dll/win32/lsasrv/lookup.c
[LSASRV]

- Remove trailing whitespace;

- Tabs --> Spaces;

- Don't always hardcode parameters sizeofs;

- Use ARRAYSIZE where applicable;

- Use UNICODE_NULL

    • -2
    • +2
    /trunk/reactos/dll/win32/lsasrv/dssetup.c
    • -14
    • +13
    /trunk/reactos/dll/win32/lsasrv/database.c
    • -2
    • +2
    /trunk/reactos/dll/win32/lsasrv/authpackage.c
    • -1
    • +1
    /trunk/reactos/dll/win32/lsasrv/service.c
    • -5
    • +5
    /trunk/reactos/dll/win32/lsasrv/privileges.c
[EVENTVWR]: Fix translation for "Information" event type: it is really in singular, not plural.
[MSVCRT]: Implement and export _wtof, based on Wine and existing code; patch by Amine Khaldi.

CORE-12335 #resolve

CORE-9312 #comment Please retest with r73206

    • -0
    • +10
    /trunk/reactos/sdk/lib/crt/string/wtof.c
[MSAFD]

- In C, void functions should better have 'VOID' mentioned in their prototypes.

- Simplify GetCurrentTimeInSeconds code.

    • -11
    • +11
    /trunk/reactos/dll/win32/msafd/misc/dllmain.c
[MSAFD]: Addendum to r73203.
    • -4
    • +2
    /trunk/reactos/dll/win32/msafd/misc/dllmain.c
[MSAFD]: Convert tabs to spaces.
[EVENTVWR]: Adjust some menu keyboard shortcuts.
  1. … 8 more files in changeset.
[EXPLORER]: Add missing keyboard shortcuts for some commands.
[NTOS]: Fix MmPt and DOPE tags.
    • -2
    • +2
    /trunk/reactos/ntoskrnl/cache/section/sptab.c
[NTOS:IO]: IopCreateDriver(): Set the returned DriverObject value only in case of success.
    • -4
    • +5
    /trunk/reactos/ntoskrnl/io/iomgr/driver.c
[TCPIP]

- Enable logging now that IoWriteErrorLogEntry works.

- Check for log event size before calling IoAllocateErrorLogEntry.

- Reduce code indentation in the logging function.

    • -25
    • +26
    /trunk/reactos/drivers/network/tcpip/tcpip/main.c
[NTOS:IO]: An improvement for the total log size check (addendum to r73167).
    • -7
    • +7
    /trunk/reactos/ntoskrnl/io/iomgr/error.c
[NTOS:IO][INCLUDES][EVENTLOG]: Fix support for event logging through the "ErrorLogPort" LPC. See the details in CORE-12301 #resolve
    • -32
    • +34
    /trunk/reactos/base/services/eventlog/eventlog.c
    • -48
    • +89
    /trunk/reactos/base/services/eventlog/logport.c
    • -87
    • +136
    /trunk/reactos/ntoskrnl/io/iomgr/error.c