• More
  • CR-120
  • resumed reviewing
That's possible. But if not captured, then the user of this data buffer should use it within SEH block...

That's possible. But if not captured, then the user of this data buffer should use it within SEH block...

  • More
  • CR-122
  • resumed reviewing
  • More
  • CR-123
  • finished reviewing
Thanks! I don't know if it's work a 1-line comment in the code then https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/smile.gif

Thanks! I don't know if it's work a 1-line comment in the code then

K thanks guys. My remark was more targeting the fact someone could think the function name could refer to only getting the Length member value of the FileNameAttribute Unicode string member inside ...

K thanks guys. My remark was more targeting the fact someone could think the function name could refer to only getting the Length member value of the FileNameAttribute Unicode string member inside this bigger structure.

NOTE: A version 1b of the patch with correct anchoring has been uploaded. Please add the new comments in there. I wasn't able to find a way to "post-anchor" the original patch.

NOTE: A version 1b of the patch with correct anchoring has been uploaded. Please add the new comments in there. I wasn't able to find a way to "post-anchor" the original patch.

NOTE: Kept as a future reference.

NOTE: Kept as a future reference.

Because OBJECT_ATTRIBUTES only contains a pointer to a UNICODE_STRING (and not a full UNICODE_STRING), what I do is that when I want to call this function, I also create (on the stack so far) an OB...

Because OBJECT_ATTRIBUTES only contains a pointer to a UNICODE_STRING (and not a full UNICODE_STRING), what I do is that when I want to call this function, I also create (on the stack so far) an OBJECT_ATTRIBUTES and a UNICODE_STRING (to hold the captured object name), and then I pass them as pointers to the ProbeAndCapture function (btw. the same thing is done by ObpCaptureObjectCreateInformation() ).

Oki, in that way it's clear we need to generate this GUID, then.

Oki, in that way it's clear we need to generate this GUID, then.

Possibly depends on the order of inclusion? To be tested...

Possibly depends on the order of inclusion? To be tested...

Hmm... so we're actually doing the quicklaunch a bit differently than on windows? or?

Hmm... so we're actually doing the quicklaunch a bit differently than on windows? or?

Possibly to find which GUID the quick-launch bar uses on 2k3 and use it instead? (perhaps to be done only when your code is finalized).

Possibly to find which GUID the quick-launch bar uses on 2k3 and use it instead? (perhaps to be done only when your code is finalized).

[22:42:21] <Timo Kreuzer> coderTrevor: It should probably be called "Usa" to not collude with the russians, ehh conflict with our coding standards. https://code.reactos.org/static/olpro3/2static/im...

[22:42:21] <Timo Kreuzer> coderTrevor: It should probably be called "Usa" to not collude with the russians, ehh conflict with our coding standards.

UpperCase variable: "FileName"

UpperCase variable: "FileName"

Does this need to be an ASSERT?

Does this need to be an ASSERT?

Should be of same type as KeyCount, e.g. ULONG. You should also fix the other functions.

Should be of same type as KeyCount, e.g. ULONG. You should also fix the other functions.

This shouldn't be considered for an ASSERT? (I don't know, I'm just suggesting)

This shouldn't be considered for an ASSERT? (I don't know, I'm just suggesting)

Code style: previous 'if' block had brackets, so this one too.

Code style: previous 'if' block had brackets, so this one too.

This needs to be of the same type as KeyCount, e.g. ULONG.

This needs to be of the same type as KeyCount, e.g. ULONG.

Here it would be e.g. a ULONG

Here it would be e.g. a ULONG

Code style : "if<space>(test)"

Code style : "if<space>(test)"

Looks like it's the full file name attribute length ^^

Looks like it's the full file name attribute length ^^

Code style!! if (CurrentIndexEntry->Flags & NTFS_WHATEVER)

Code style!!
if (CurrentIndexEntry->Flags & NTFS_WHATEVER)

We have ULONG_MAX for this https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/smile.gif

We have ULONG_MAX for this

Bracket on its own line.

Bracket on its own line.

Maybe a #define would be nice (especially if there'll be more flags possible for this struct member).

Maybe a #define would be nice (especially if there'll be more flags possible for this struct member).

8 == ? Number of bits in 1 byte? or sizeof(ULONGLONG)? or something else?

8 == ? Number of bits in 1 byte? or sizeof(ULONGLONG)? or something else?

Make USA great again!

Make USA great again!

Do we need this cast?

Do we need this cast?