Mark Jansen

[SHORTCUTS.INF] Move the shortcut creation for screenshot.exe to the new rosapps_shortcuts.inf. Patch by Joachim Henze (reactosfanboy)

CORE-13426 #resolve #comment Thanks!

    • -0
    • +47
    /trunk/rosapps/rosapps_shortcuts.inf
    • -47
    • +0
    /trunk/reactos/media/inf/shortcuts.inf
[WIN32SS][SHELL32] Fix the location and repaint of the version info shown on the desktop. Patch by Katayama Hirofumi MZ.

CORE-13567 #resolve #comment Thanks!

    • -0
    • +5
    /trunk/reactos/win32ss/user/ntuser/desktop.c
[SYSSETUP][SHORTCUTS.INF] Add FontSub program shortcut to Start Menu. Patch by Katayama Hirofumi MZ.

CORE-13428 #resolve #comment Thanks!

    • -0
    • +294
    /trunk/rosapps/rosapps_shortcuts.inf
    • -0
    • +14
    /trunk/reactos/dll/win32/syssetup/install.c
[SHIMENG] Pass shim commandline to shims. CORE-11329
[SHIMLIB] Add debug print functionality for shims. CORE-11329
[ACPPAGE] Usability: Convert the edit box to a combobox, ask the user if they want to add the layer when closing the dialog.
  1. … 10 more files in changeset.
[SHELL32] Do not dereference a nullpointer for logging. CORE-13552
[USBPORT] Fix incorrect transfer direction for URBs. Patch by Vadim Galyant. CORE-13546
    • -3
    • +3
    /trunk/reactos/drivers/usb/usbport/urb.c
[APPHELP_APITEST] Convert test_match_ex to a data driven test + fix a bug in the apitest.
    • -43
    • +39
    /trunk/rostests/apitests/apphelp/db.cpp
[SPOOLSS] Stub BuildOtherNamesFromMachineName as seen in wine commit cdb5f35. This fixes a crash in spoolss:spoolss
[APPCOMPAT] Various fixes.

- Simplify shimdbg output as suggested by Thomas

- Simplify media/sdb/sysmain.xml

- Fix some warnings + a debug print

    • -90
    • +49
    /trunk/reactos/media/sdb/sysmain.xml
[WIN32SS] Fix EqualFamilyInfo function logic. Patch by Victor Martinez Calvo, modified by Katayama Hirofumi MZ.

CORE-13411 #resolve, CID 1411971

    • -16
    • +11
    /trunk/reactos/win32ss/gdi/ntgdi/freetype.c
This can be different per use case. If you need the buffer just to read from it, use GetString(), if you need the buffer to modify it, use GetBuffer() / ReleaseBuffer(). If you are going to pass t...

This can be different per use case.
If you need the buffer just to read from it, use GetString(), if you need the buffer to modify it, use GetBuffer() / ReleaseBuffer().

If you are going to pass the data to a control that holds on to it (lParam etc) you probably dont want to use a CString at all.

A generic note for CString: If you just want to access the raw string pointer (to read!), use GetString() instead of GetBuffer().

A generic note for CString: If you just want to access the raw string pointer (to read!), use GetString() instead of GetBuffer().

[FONTS] Add substitutes for the System font, and remove a hack for the System font. Patch by Katayama Hirofumi MZ. CORE-9222
    • -49
    • +18
    /trunk/reactos/win32ss/gdi/ntgdi/freetype.c
Samuel Serapion: You said you were working on a new patch, is the latest version attached here or do you have a new revision?

Samuel Serapion: You said you were working on a new patch, is the latest version attached here or do you have a new revision?

  • More
  • CR-120
  • finished reviewing
  • More
  • CR-122
  • finished reviewing
Jira cut off the url (already gave it in irc): https://git.reactos.org/?p=reactos.git;a=blob;f=reactos/dll/win32/browseui/explorerband.cpp;hb=6f6999647ab23b1ee53550b6f6196c912b03334a#l57

Jira cut off the url (already gave it in irc): https://git.reactos.org/?p=reactos.git;a=blob;f=reactos/dll/win32/browseui/explorerband.cpp;hb=6f6999647ab23b1ee53550b6f6196c912b03334a#l57

As you already found out, and what we overlooked was: The TBBUTTON struct treats this as opaque data, e.g. it does do nothing but store the raw value you pass it. (in our case, a pointer) So when f...

As you already found out, and what we overlooked was: The TBBUTTON struct treats this as opaque data, e.g. it does do nothing but store the raw value you pass it. (in our case, a pointer)
So when freeing this data, the pidl becomes invalid, and the button can no longer use it.

[USER32_APITEST] Add tests to validate the messages sent during MDI window creation. CORE-12052

The test passes from 2k3 - 10.

    • -0
    • +481
    /trunk/rostests/apitests/user32/CreateWindowEx.c
You are probably looking for _IlIsDesktop

You are probably looking for _IlIsDesktop

Yes. But remember: When the CComHeapPtr is not inside the for loop, it needs to be freed each iteration as well!

Yes.
But remember: When the CComHeapPtr is not inside the for loop, it needs to be freed each iteration as well!

[SHIMDBG] Output both to the console and the debug output + fix a copypasta error.
[REGEDIT] Pre-select the text in the edit dialog.
[APPHELP] Propagate applied layers to child processes by setting the env var __COMPAT_LAYER. CORE-13284
Or route allocations trough a generic macro / function, which you can use to switch between the 2 https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/smile.gif

Or route allocations trough a generic macro / function, which you can use to switch between the 2

Update Sequence Array

Update Sequence Array

  • More
  • CR-119
  • resumed reviewing
Yes sorry, I meant CWindow. that is the ATL version, it's simply a thin wrapper around an HWND, allows some convenience functions.

Yes sorry, I meant CWindow.
that is the ATL version, it's simply a thin wrapper around an HWND, allows some convenience functions.