Mark Jansen

[KERNEL32] Initial implementation for BaseCheckRunApp, calling into apphelp to check for compatibility fixes CORE-10368
[USER32_APITEST] Add more tests to validate messages sent during window creation / modifying of styles. CORE-12052
    • -5
    • +338
    /trunk/rostests/apitests/user32/CreateWindowEx.c
[USER32_APITEST] Add tests to validate messages sent during window creation / modifying of styles. CORE-12052
    • -2
    • +259
    /trunk/rostests/apitests/user32/CreateWindowEx.c
[SYSSETUP][UNATTENDED] Allow changing the resolution automatically. CORE-13315
    • -0
    • +64
    /trunk/reactos/dll/win32/syssetup/wizard.c
[WIN32SS] Improve IntGetFontLocalizedName by less strict matching on language id's. Patch by Katayama Hirofumi MZ. CORE-13239 #comment Thanks!
    • -38
    • +85
    /trunk/reactos/win32ss/gdi/ntgdi/freetype.c
[KERNEL32] Format the stack trace generated on an unhandled exception so that log2lines can parse it. CORE-13232 #resolve
[SHIMS] Add IgnoreDebugOutput shim CORE-10369
    • -0
    • +32
    /trunk/reactos/dll/appcompat/shims/genral/ignoredbgout.c
[BOOTDATA] Create an empty HKLM\...\AppCompatFlags\Layers key to silence logging.
    • -3
    • +4
    /trunk/reactos/boot/bootdata/hivesys.inf
    • -0
    • +3
    /trunk/reactos/boot/bootdata/hivesft.inf
[SLAYER] Remove the shell extension. CORE-13111 #resolve
    • -1
    • +0
    /trunk/reactos/dll/shellext/CMakeLists.txt
  1. … 17 more files in changeset.
[WIN32SS] Reduce the amount of calls to IntGetFontLocalizedName, since this was identified as a source of recent slower drawing. CORE-13274

Thanks to Thomas, Giannis and Joachim.

    • -0
    • +8
    /trunk/reactos/win32ss/gdi/eng/engobjects.h
    • -2
    • +2
    /trunk/reactos/win32ss/user/ntuser/main.c
    • -27
    • +115
    /trunk/reactos/win32ss/gdi/ntgdi/freetype.c
[GDI32_APITEST] Improve GetFontResourceInfoW tests. Patch by Katayama Hirofumi MZ. ROSTESTS-269 #resolve #comment Thanks!
    • binary
    /trunk/rostests/apitests/gdi32/ExampleFont.ttf
[APPHELP] Initial implementation of ApphelpCheckRunAppEx. CORE-10368
Yes this is the case, and my apitests even rely on this behavior to detect the size of the struct.

Yes this is the case, and my apitests even rely on this behavior to detect the size of the struct.

[APPHELP][SHIMLIB] Forward some events to loaded shims. CORE-11329
    • -0
    • +163
    /trunk/reactos/dll/appcompat/apphelp/shimeng.c
[NDK][RTL] Make the Name argument in RtlQueryEnvironmentVariable_U const.
    • -1
    • +1
    /trunk/reactos/sdk/include/ndk/rtlfuncs.h
It takes a full screen height that way, it's a bit overkill. I'd rather have a bit different formatting there than use an entire screen for one typedef.

It takes a full screen height that way, it's a bit overkill.
I'd rather have a bit different formatting there than use an entire screen for one typedef.

Ill remove em.

Ill remove em.

Just dont try to share the precompiled header.

Just dont try to share the precompiled header.

Might be a leftover from writing this in a .cpp file, will re-check.

Might be a leftover from writing this in a .cpp file, will re-check.

typedefs usually don't have IN/OUT, but will fix the formatting.

typedefs usually don't have IN/OUT, but will fix the formatting.

Missed that, indeed. Will doublecheck the other args.

Missed that, indeed.
Will doublecheck the other args.

Yes.

Yes.

I prefer to have them inside the loop, because now it is clear that no state is kept.

I prefer to have them inside the loop, because now it is clear that no state is kept.

I did it this way because this is the native type with which those members are defined inside the structures.

I did it this way because this is the native type with which those members are defined inside the structures.

Nice.

Nice.

It is from a blog post that was one of my references for implementing this stuff, I'll remove this comment before committing. (ps: are you viewing this on 640x480?)

It is from a blog post that was one of my references for implementing this stuff,
I'll remove this comment before committing.
(ps: are you viewing this on 640x480?)

ps: Your patch is anchored to branches/GSoC_2016/NTFS/ instead of trunk.

ps: Your patch is anchored to branches/GSoC_2016/NTFS/ instead of trunk.

sure.

sure.

[SHELL32] Add stub for SHEnumerateUnreadMailAccountsW, needed by Thunderbird. Found by Joachim Henze. CORE-13229
    • -1
    • +1
    /trunk/reactos/dll/win32/shell32/shell32.spec
    • -0
    • +15
    /trunk/reactos/dll/win32/shell32/stubs.cpp