Mark Jansen

[WINED3D] Silence a noisy DPRINT that makes Test KVM AHK abort.

CORE-13829

I dont see any code using this spinlock in the diff, is that because it is already existing code, or is that because the spinlock is not used?

I dont see any code using this spinlock in the diff, is that because it is already existing code, or is that because the spinlock is not used?

Code style.

Code style.

We don't need to decrement the HalpOutstandingScatterGatherCount here?

We don't need to decrement the HalpOutstandingScatterGatherCount here?

ASSERT(Element != ScatterGatherList->Elements)

ASSERT(Element != ScatterGatherList->Elements)

ROUND_UP

ROUND_UP

Would be nice not to use a magic value here? Maybe define something for it.

Would be nice not to use a magic value here?
Maybe define something for it.

[USER32][WIN32K] Make antialiased disabled font readable. Patch by Katayama Hirofumi MZ. CORE-7721
    • -0
    • +1
    /trunk/reactos/win32ss/gdi/ntgdi/font.h
    • -7
    • +10
    /trunk/reactos/win32ss/gdi/ntgdi/freetype.c
[ACPPAGE] Work around a crash with BSTR's. CORE-13800 #resolve
Mainly formatting / dprint pass while I read into this. More to follow

Mainly formatting / dprint pass while I read into this.
More to follow

ditto

ditto

This now lives in sdk/include, fixed tho.

This now lives in sdk/include, fixed tho.

What should we do if this fails? For now I just return this status.

What should we do if this fails?
For now I just return this status.

[LIBTIRPC] Do not add makefiles in the CMakeLists.txt
[APPHELP_APITEST][APPSHIM_APITEST] Update the license headers
    • -15
    • +4
    /trunk/rostests/apitests/apphelp/data.c
    • -18
    • +6
    /trunk/rostests/apitests/apphelp/db.cpp
    • -15
    • +4
    /trunk/rostests/apitests/apphelp/env.c
[XML2SDB][SHIMDBG] Update license headers
    • -6
    • +4
    /trunk/reactos/sdk/tools/xml2sdb/xml2sdb.cpp
    • -6
    • +4
    /trunk/reactos/sdk/tools/xml2sdb/main.cpp
[ACLAYERS][ACGENRAL] Update license headers + include cleanup.
[APPHELP][ACPPAGE][SHIMLIB] Update license headers
  1. … 11 more files in changeset.
[SDK] Allow version lie shims to be applied to msi.dll
    • -0
    • +18
    /trunk/reactos/media/sdb/sysmain.xml
All GSOC Rapps changes
All GSOC Rapps changes
[SHIMENG] Fix logging when handling ordinal ordinal functions.
[SERVICES] Allow CreateService to create an interactive service under the LocalSystem account.

MSDN stated that this is allowed, and this fixes VMWare Horizon setup not working.

CORE-13434

    • -1
    • +5
    /trunk/reactos/base/system/services/rpcserver.c
[WINED3D] Dereference context slightly later, as seen in wine. This prevents some crashes while applications are starting up. (f.e. ANNO1602)
[OLE32] Do not crash on an invalid / empty clipboard.

CORE-12302

  • More
  • CR-120
  • resumed reviewing
[SHIMENG] Enable the Application Compatibility framework by default.

- Also add disabled keys to configure the logging

- Demote a noisy print used in the shim engine.

At this point the shim engine should be functional enough to be used.

One thing that remains is creating more shims(fixes) to use, and implement more features for the already existing ones.

CORE-13284

    • -0
    • +2
    /trunk/reactos/boot/bootdata/hivesys.inf
    • -2
    • +2
    /trunk/reactos/boot/bootdata/hivesft.inf
[ACLAYERS] Add a compatibility shim + layer for the VMWare Horizon setup.

This fixes the setup trying to print some debug strings.

For now the shim has to be applied manually, however the setup does not complete yet.

Patch bits & fixes by Thomas.

CORE-13434

    • -0
    • +142
    /trunk/reactos/dll/appcompat/shims/layer/vmhorizon.c
[NTDLL_APITEST] Test unaligned pointers for NtOpenKey

CORE-13689

    • -0
    • +2
    /trunk/rostests/apitests/ntdll/testlist.c
    • -0
    • +58
    /trunk/rostests/apitests/ntdll/NtOpenKey.c
[ADVAPI32_APITEST] Addendum to 75585, use void pointers to work around gcc ignoring pshpack1.
    • -24
    • +11
    /trunk/rostests/apitests/advapi32/RegOpenKeyExW.c