Alexander Shaposhnikov

All GSOC Rapps changes
All GSOC Rapps changes
There was no strong consensus on this so I'll leave it as is for now.

There was no strong consensus on this so I'll leave it as is for now.

Seems a bit ugly IMO. Edit: I'd really prefer using enum class if we switch to more modern MSVC.

Seems a bit ugly IMO.
Edit: I'd really prefer using enum class if we switch to more modern MSVC.

I prefer having dedicated headers for semantically different parts of code.

I prefer having dedicated headers for semantically different parts of code.

Yes, I'll do that as the enum above.

Yes, I'll do that as the enum above.

I haven't found a command like this.

I haven't found a command like this.

VS2010 doesn't support enum class scoped enums.

VS2010 doesn't support enum class scoped enums.

This class uses static cache for locale strings so they won't be generated for each object but instead be shared.

This class uses static cache for locale strings so they won't be generated for each object but instead be shared.

Yeah, it acts like a namespace yet.

Yeah, it acts like a namespace yet.

The idea is that CAvailableApps just caches the entries into memory. The DB update merely downloads all the files, so it doesn't need any non-static object members and can be called without such, w...

The idea is that CAvailableApps just caches the entries into memory. The DB update merely downloads all the files, so it doesn't need any non-static object members and can be called without such, while still having semantic connection to CAvailableApps. I did it this way to keep the existing EnumAvailableApplications code, which can be redesigned I guess.

Opps, that's a weird typo. No warning either.

Opps, that's a weird typo. No warning either.

For this one it doesn't matter.

For this one it doesn't matter.

I created these variables static to share them across objects as they don't change, but have to be loaded.

I created these variables static to share them across objects as they don't change, but have to be loaded.

I did that to have .h files in the generated .vssolution .

I did that to have .h files in the generated .vssolution .

How do I handle such situation correctly?

How do I handle such situation correctly?

I agree that using GetBuffer() when reading is not pretty. However, original code almost never copied the arrays themselves and passed that local arrays around. Perhaps I don't need to copy them?

I agree that using GetBuffer() when reading is not pretty.
However, original code almost never copied the arrays themselves and passed that local arrays around.
Perhaps I don't need to copy them?

The reason I did use GetBuffer() is that some functions require LPWSTR and I did not want to use const_cast<LPWSTR>(). So you say casting is better?

The reason I did use GetBuffer() is that some functions require LPWSTR and I did not want to use const_cast<LPWSTR>().
So you say casting is better?

Pointless check (removed already)

Pointless check (removed already)

I've just marked them for myself. Like "these were macros, refactor it please" https://code.reactos.org/static/olpro3/2static/images/wiki/icons/emoticons/tongue.gif

I've just marked them for myself. Like "these were macros, refactor it please"

Thank you guys for reviews, everything noted.

Thank you guys for reviews, everything noted.

I guess this is even UNICODE_NULL

I guess this is even UNICODE_NULL

Hmm, I just prefer to instantly see how the right check relates to the left one.

Hmm, I just prefer to instantly see how the right check relates to the left one.

Definetly length. I plan to replace a C array by ATL::CSimpleArray to avoid such constants.

Definetly length. I plan to replace a C array by ATL::CSimpleArray to avoid such constants.

Thats what I've seen in current entries and in my expericence. The majority of version formats are using a, b, c as suffix. Although there can be -alpha, -beta, never seen such in the registry.

Thats what I've seen in current entries and in my expericence. The majority of version formats are using a, b, c as suffix.
Although there can be -alpha, -beta, never seen such in the registry.