• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[CRYPTNET]

- Fix ROS-Diff. Spotted by CRLF.

CORE-13117 #resolve

[SERVMAN]

- Make a copy of the service list where service and display name strings are separately allocated. We need this to update the service names rather than reload the list when the display name is changed.

- Write the display name, description or binary path to the registry when the user changed them.

- Disable the Edit button after it has been clicked.

- Do not add the service name to the argument vector in the call to StartServiceW. Services.exe already add the service name to the vector.

CORE-12743

[LOCALSPL]

Implement all corner cases of handling the Name parameter in EnumPrinters. This can be done in a common way for all levels.

Fixes more tests.

[NTOSKRNL] CcPurgeCacheSection: Check if SharedCacheMap is NULL. Change suggested by ThFabba. CORE-13115
[NTOS:MM]

- In NtMapViewOfSection, check for address alignment after validating the handles. This fixes the tests from the previous commit, but is also necessary because information about the section object is necessary to avoid the alignment checks for physical memory sections.

CORE-13113

    • -17
    • +21
    /trunk/reactos/ntoskrnl/mm/ARM3/section.c
[KMTESTS:MM]

- Show that NtMapViewOfSection validates section and process handles before checking base address alignment

CORE-13113

[NTOS:MM]

- Check for ROS section object before accessing the AllocationAttributes member in NtMapViewOfSection, since ARM3 sections use a different structure.

CORE-13113

    • -1
    • +2
    /trunk/reactos/ntoskrnl/mm/ARM3/section.c
[ACPPAGE] Implement custom compatibility mode selection + Expand paths CORE-10375
    • -0
    • +7
    /trunk/reactos/sdk/lib/atl/atlexcept.h
    • -0
    • +111
    /trunk/reactos/dll/shellext/acppage/CLayerStringList.hpp
[ACPPAGE] Update translations based on slayer. CORE-10375

Translators, please check your language, some text was changed!

    • -0
    • +46
    /trunk/reactos/dll/shellext/acppage/lang/sk-SK.rc
    • -0
    • +41
    /trunk/reactos/dll/shellext/acppage/lang/es-ES.rc
    • -0
    • +41
    /trunk/reactos/dll/shellext/acppage/lang/it-IT.rc
    • -0
    • +47
    /trunk/reactos/dll/shellext/acppage/lang/uk-UA.rc
    • -0
    • +39
    /trunk/reactos/dll/shellext/acppage/lang/no-NO.rc
    • -0
    • +39
    /trunk/reactos/dll/shellext/acppage/lang/bg-BG.rc
    • -0
    • +39
    /trunk/reactos/dll/shellext/acppage/lang/eu-ES.rc
    • -0
    • +43
    /trunk/reactos/dll/shellext/acppage/lang/sq-AL.rc
    • -0
    • +39
    /trunk/reactos/dll/shellext/acppage/lang/id-ID.rc
    • -0
    • +41
    /trunk/reactos/dll/shellext/acppage/lang/he-IL.rc
    • -0
    • +39
    /trunk/reactos/dll/shellext/acppage/lang/fr-FR.rc
  1. … 9 more files in changeset.
[KMTESTS:MM]

- Enable MEM_RESERVED test in SimpleErrorChecks() since it no longer asserts. Patch by Serge Gautherie.

ROSTESTS-109 #resolve

[INPUT.CPL]

- Remove an unneeded header inclusion;

- Fix a sizeof invocation;

- RegEnumKeyExW and RegEnumValueW take their fourth parameter (size of key / value name, resp.) as a size in number of *characters* (and not in number of bytes);

- Add a missing RegCloseKey call in LocaleList_Create.

    • -2
    • +2
    /trunk/reactos/dll/cpl/input/layout_list.c
    • -2
    • +4
    /trunk/reactos/dll/cpl/input/locale_list.c
[NTOS:KE]

- Reset DebugDpcTime before calling timer DPC routines. Avoids spurious "DPC routine > 1 sec" break-ins.

[NTOS:MM]

- Avoid reference leaks in failure cases of MmCreateCacheSection

CORE-6931

    • -0
    • +4
    /trunk/reactos/ntoskrnl/cache/section/data.c
[VGADDI]

- Fix buffer overflow in DIB_BltFromVGA. A byte fits two pixels.

[TRANSLATION]

Romanian resources maintenance

Patch by Ștefan Fulea.

CORE-13099

    • -20
    • +20
    /trunk/reactos/dll/win32/shell32/lang/ro-RO.rc
    • -1
    • +1
    /trunk/reactos/dll/win32/devmgr/lang/ro-RO.rc
    • -0
    • +29
    /trunk/reactos/dll/cpl/openglcfg/lang/ro-RO.rc
    • -1
    • +1
    /trunk/reactos/base/setup/usetup/lang/ro-RO.h
    • -0
    • +3
    /trunk/reactos/dll/cpl/openglcfg/openglcfg.rc
  1. … 7 more files in changeset.
[SHELL32] Fix for BuildPathsList, this solves some problems showing while copying folders. Patch by 'Gleb'. CORE-8434
[SHELL32] -CDesktopBrowser: Clone the pidl passed to SHOpenNewFrame as it will later free it itself. This was masked by a hacky cast.
[NTOS:MM]

- Never use special pool for prototype PTEs. Avoids "(PointerPte >= (PMMPTE)MmPagedPoolStart) && (PointerPte <= (PMMPTE)MmPagedPoolEnd)" assertion failure in MiDecrementShareCount.

CORE-11474

    • -0
    • +7
    /trunk/reactos/ntoskrnl/mm/ARM3/special.c
[KERNEL32_WINETEST]

- Improve the test_GetVolumePathNamesForVolumeNameW hack to avoid a stack buffer underrun.

CORE-11474

[OPENGL32]

- Fix uninitialized variable use in IntGetIcdData

CORE-11474

[KMTESTS:OB]

- After ObCreateObject+ObInsertObject a handle close is enough to destroy the object, so do not dereference it in addition. Fixes use after free.

CORE-11474

    • -2
    • +4
    /trunk/rostests/kmtests/ntos_ob/ObType.c
[KMTESTS:NPFS]

- Remove tests that cause pool buffer overflows. NtQueryVolumeInformationFile does not validate buffer length for kernel mode callers, so passing an invalid length is not a good test.

CORE-11474

[WS2_32][DNSAPI]

- Avoid stack buffer overflow in ParseV4Address

CORE-11474

    • -0
    • +1
    /trunk/reactos/dll/win32/dnsapi/dnsapi/query.c
    • -0
    • +1
    /trunk/reactos/dll/win32/ws2_32/src/addrinfo.c
[GDI32]

- Use the number of WCHARs, not the number of ANSI chars in GetCharABCWidthsA. Fixes stack corruption when running gdi32_winetest:font

CORE-11474

[VARIOUS]

Updating Turkish Translation

Patch by Erdem Ersoy.

CORE-12362

    • -27
    • +27
    /trunk/reactos/dll/win32/shell32/lang/tr-TR.rc
    • -0
    • +30
    /trunk/reactos/dll/cpl/openglcfg/lang/tr-TR.rc
    • -0
    • +3
    /trunk/reactos/dll/cpl/openglcfg/openglcfg.rc
    • -1
    • +1
    /trunk/reactos/media/rapps/net20sp2.txt
  1. … 12 more files in changeset.
[USER32]

- In RealSystemParametersInfoA/SPI_GETDESKWALLPAPER, write the ansi wallpaper path directly into the user's buffer instead of using an allocation (and overrunning it). Fixes crash when running user32_winetest:sysparams with DPH.

Tangential to CORE-13097

[USER32] -CallWindowProc: Call PreWndProc and PostWndProc hooks for dialog messages if the message is not hooked for PreDefDlgProc and PostDefDlgProc.
[CONCFG]: Addendum for r74366: Initialize the console settings information codepage with the current OEM codepage, and read the optional console "CodePage" DWORD registry setting.

CORE-12451

[CONCFG]: Use 'Success' boolean variable instead of an obscure 'RetVal'.
[CONSOLE.CPL]: Paint the text samples using the correct character set (derived from the current code page).

This e.g. fixes display for the backslash symbol in CJK languages (that should appear as the Chinese "yuan" / Japanese "yen" currency symbol ¥, or the Korean "won" currency symbol ₩).

CORE-12451

    • -2
    • +3
    /trunk/reactos/dll/cpl/console/options.c
    • -3
    • +3
    /trunk/reactos/dll/cpl/console/layout.c