• last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[DEVMGR]

- NEVER EVER use single line if statements!!!!

- Fix indentation and coding style.

[DEVMGR]

Hide "HTREE\ROOT\0" from the device tree.

CORE-12670 #resolve #comment Thanks a lot!

[DEVMGR]

Select a treeview item on a right click.

[MSAFD][WS2_32]

- Properly return error codes from WSPConnect

CORE-12787 #resolve

    • -7
    • +25
    /trunk/reactos/dll/win32/msafd/misc/dllmain.c
    • -7
    • +0
    /trunk/reactos/dll/win32/ws2_32/src/socklife.c
[EVENTVWR]

Don't attempt to free random address

CID 1401231

[UXTHEME] Fix the conversion from color id to theme metric and don't pass the metric id to GetSysColor. CORE-11086
    • -5
    • +1
    /trunk/reactos/dll/win32/uxtheme/metric.c
[ACPI]

Generate a proper device id string for processor devices.

    • -0
    • +10
    /trunk/reactos/drivers/bus/acpi/main.c
    • -3
    • +11
    /trunk/reactos/drivers/bus/acpi/buspdo.c
[SHELL32]

For the input string, WideCharToMultiByte takes a char count and not a buffer size.

CID 1401096, 1401088

    • -2
    • +6
    /trunk/reactos/dll/win32/shell32/CShellLink.cpp
[SHELL32]

Don't attempt to dereference a pointer after having freed it

CID 1401297

    • -2
    • +2
    /trunk/reactos/dll/win32/shell32/CShellLink.cpp
[WS2_32]

Remove duplicated if

CID 1400935

    • -7
    • +0
    /trunk/reactos/dll/win32/ws2_32/src/socklife.c
[DNSAPI]

Properly check for domain name being set

CID 1401070

    • -2
    • +2
    /trunk/reactos/dll/win32/dnsapi/dnsapi/query.c
[WSHTCPIP]

- Fix incorrect sizeof in SHIoctl_GetInterfaceList. CID 1401188

[WS2_32]

- Fix ridiculous over-casting

    • -4
    • +4
    /trunk/reactos/dll/win32/ws2_32/src/nsquery.c
    • -4
    • +4
    /trunk/reactos/dll/win32/ws2_32/src/nscatalo.c
    • -2
    • +2
    /trunk/reactos/dll/win32/ws2_32/src/qshelpr.c
    • -1
    • +1
    /trunk/reactos/dll/win32/ws2_32/src/getxbyxx.c
    • -4
    • +4
    /trunk/reactos/dll/win32/ws2_32/src/dprocess.c
    • -6
    • +6
    /trunk/reactos/dll/win32/ws2_32/inc/ws2_32p.h
    • -6
    • +6
    /trunk/reactos/dll/win32/ws2_32/src/dcatalog.c
    • -2
    • +2
    /trunk/reactos/dll/win32/ws2_32/src/addrinfo.c
    • -1
    • +1
    /trunk/reactos/dll/win32/ws2_32/src/dcatitem.c
    • -1
    • +1
    /trunk/reactos/dll/win32/ws2_32/src/nsprovid.c
    • -3
    • +3
    /trunk/reactos/dll/win32/ws2_32/src/dprovide.c
[WS2_32]

- Fix wrong ServLength in getnameinfo, again, since it got lost in the ws2_32_new work. CID 716150

CORE-11214

    • -1
    • +1
    /trunk/reactos/dll/win32/ws2_32/src/addrinfo.c
[UXTHEME] -Set cbSize field of WINDOWINFO before calling GetWindowInfo. CORE-12776
    • -0
    • +2
    /trunk/reactos/dll/win32/uxtheme/nonclient.c
[DNSAPI]

Properly check for domain name being set

CID 1401080

    • -1
    • +1
    /trunk/reactos/dll/win32/dnsapi/dnsapi/query.c
[FASTFAT]

Avoid uninit variable usage.

CID 1401257, 1401259

[LOCALMON]

- Avoid a potential double free in InitializePrintMonitor2. CID 1401299

- Avoid a use after free in LocalmonClosePort. CID 1401298

[UXTHEME] -The code to draw the classic style borders was copied from win32k, so imitate what it does and restore two bits that got removed in the copy. CORE-9667
    • -4
    • +5
    /trunk/reactos/dll/win32/uxtheme/nonclient.c
[SHELL32] -Try to fix themes when opening the control panel applet from the control panel.
    • -1
    • +2
    /trunk/reactos/dll/win32/shell32/wine/control.c
[KS] Cleanup in the failure path of KsCreateDefaultClock. Patch by Sebastian Gasiorek. CID 1322124 CORE-12784 #resolve #comment Thanks!
[FASTFAT]

Get rid of the ENTRY_DELETED2, ENTRY_VOLUME2 and ENTRY_END2 macros.

[FASTFAT]

Modify ReadVolumeLabel() so that it is able to read the volume label, even without using the VCB, the root FCB, Cc, the universe.

This is important, because in case of device verifying, you cannot rely on these elements anylonger, but you need to read the label.

A readme has been attached to the function, to indicate how to call it (I wish I could have put more asserts!). It's ugly, I know.

This allows fixing a FIXME in VfatVerify(): we can also check the volume label for FATX volumes.

The FIXME comment was misleading: MS FastFAT doesn't make any checksum or whatever of FAT root. Let's not do it.

[FASTFAT]

Move ReadVolumeLabel() to fsctl.c close to functions that need it

[DESK.CPL] -Apparently the second parameter of ApplyTheme is not a string. One case is that it is not a pointer and another case that it is a pointer to a struct. What I'm sure of is that as it is now the position of the string in the binary affects the behavior of ApplyTheme. Thankfully 0 works great on windows.
[KMTESTS:MM]

- Add some stricter checks and improved error handling in NtCreateSection_user

[USBSTOR]

- Fix a broken assert (yes, calling NTOHL is wrong, ContiguousLogicBlocksByte0 is the MSB). CID 701077

    • -1
    • +1
    /trunk/reactos/drivers/usb/usbstor/scsi.c
[GDI32_APITEST] Add tests for GetFontResourceInfoW. Patch by Katayama Hirofumi MZ. CORE-6621
    • -1
    • +3
    /trunk/rostests/apitests/gdi32/testlist.c
    • -0
    • +433
    /trunk/rostests/apitests/gdi32/GetFontResourceInfoW.c
[PSDK]

- Fix KsFilterFactoryGetDevice

CORE-11794

    • -1
    • +11
    /trunk/reactos/sdk/include/psdk/ks.h
[SHELL32]

- Make the "Open with" dialog start in Program Files as is done in Windows (doesn't really changes anything because comdlg32 doesn't expand environment variables).