Pierre Schweitzer

[MOVEFILE]

Open source the movefile utily that allows queueing deletion/renaming operations for the next reboot

[ROSINTERNALS]

Addendum to r75529

    • -0
    • +2
    /trunk/rosapps/applications/rosinternals/CMakeLists.txt
[ROSINTERNALS]

Move the sysinternals tools to their own directory: rosinternals. To be completed :-)

  1. … 4 more files in changeset.
[PENDMOVES]

Open source the PendMoves utility from Sysinternals that allow easy display of renaming/deleting operations queued for next reboot.

See: https://docs.microsoft.com/en-us/sysinternals/downloads/pendmoves

  1. /trunk/rosapps/applications/cmdutils/pendmoves
[SYSSETUP]

Translate r75495 in French.

Thanks Giannis! :-)

    • -5
    • +5
    /trunk/reactos/dll/win32/syssetup/lang/fr-FR.rc
[RDBSS]

- Implement RxSetRenameInfo()

- Implement the SL_OPEN_TARGET_DIRECTORY case in RxCreateFromNetRoot()

This implements renaming in RDBSS, and thus in NFS.

So far, renaming fails due to different NET_ROOT, I need to check why. So far, files are properly copied on rename failure.

CORE-8204

CORE-11327

CORE-13632

[NFS]

And make NP a bit more discrete when not really used...

[NFS]

Make hack introduced in r75415 more verbose.

CORE-8204

CORE-11327

[RDBSS]

Implement RxSetDispositionInfo(): this allows deleting files on a remote NFS share!

CORE-8204

CORE-11327

CORE-13636

[RDBSS]

On cleanup, only take the quick path if the file was already orphaned

CORE-11327

[RXCE]

In RxRemoveNameNetFcb(), check if name was already removed. MS doesn't do this, but as we use double linked-list macros

that perform extra sanity checks, this is required. This can be called twice for a single FCB.

CORE-11327

CORE-13632

CORE-13636

    • -4
    • +11
    /trunk/reactos/sdk/lib/drivers/rxce/rxce.c
[KERNEL32]

Don't leak a handle when renaming a source file which is a MS mount point or a file without the reparse attribute while we can query its reparse information.

CORE-13635

[RDBSS]

Don't attempt to dereference NULL-ptr if CCB isn't set.

Fixes crash in RxFsdCommonDispatch() under rare circumstances.

CORE-11327

[RXCE]

In spite of what its name may look like: SyncEvent is a notification event, not a sync event.

Use the correct event for synchronization. This avoids infinite wait in certain circumstances in RxScavengeFobxsForNetRoot()

CORE-11327

    • -2
    • +2
    /trunk/reactos/sdk/lib/drivers/rxce/rxce.c
[RXCE]

Make code that deals with DBG stuff only built in DBG builds

CORE-11327

CORE-13610

    • -0
    • +10
    /trunk/reactos/sdk/lib/drivers/rxce/rxce.c
[RDBSS]

For non dbg builds, don't implement macro defined functions RxCheckShareAccess(), RxRemoveShareAccess(), RxSetShareAccess(), RxUpdateShareAccess()

CORE-11327

CORE-13610

[RXCE]

Only implement RxTrackerUpdateHistory() if RDBSS_TRACKER is defined

CORE-11327

CORE-13610

    • -0
    • +2
    /trunk/reactos/sdk/lib/drivers/rxce/rxce.c
[RDBSS]

For non dbg builds, don't implement macro defined functions RxDumpCurrentAccess(), RxDumpWantedAccess()

CORE-11327

CORE-13610

[RDBSS]

Implement RxPrepareToReparseSymbolicLink().

This allows symbolic links to work on a NFS share, we can now follow links that would have been exported by the server.

Safe to merge.

CORE-8204

CORE-11327

CORE-13615

[RDBSS]

When CcFlushCache fails, properly set status before leaving.

CORE-11327

[NFSD]

In case NFS session expires while reading/writing to a file, renew the session instead of just failing.

This avoids not being able to transfer any file with slow connection, and not being able to transfer big files with normal connection.

CORE-8204

CORE-13484

[KERNEL32]

In case of synchronous read, it's legit for the FSD to notify EOF by returning success & zero read length.

It fixes never ending reads when copying a file from NFS to local disk.

CORE-8204

CORE-11327

CORE-13484

[RXCE]

Don't forget to set RX_CONTEXT_FLAG_FROM_POOL flag when allocating a new RX_CONTEXT structure from pool.

This avoids leaking it afterwards and exhausting NP pool when using NFS.

CORE-8204

CORE-11327

CORE-13484

CORE-13604

    • -1
    • +5
    /trunk/reactos/sdk/lib/drivers/rxce/rxce.c
[RXCE]

- Implement RxAcquireFcbForLazyWrite(), RxAcquireFcbForReadAhead(), RxReleaseFcbFromLazyWrite(), RxReleaseFcbFromReadAhead()

This makes RXCE better at dealing with Cc (and the other way round ;-)). This notably avoids infinite acquire loops from Cc when writing on a NFS share.

CORE-8204

CORE-11327

    • -0
    • +2
    /trunk/reactos/sdk/include/ddk/nodetype.h
    • -0
    • +186
    /trunk/reactos/sdk/lib/drivers/rxce/rxce.c
[EXT2]

Import commits by Kaho Ng <ngkaho1234@gmail.com> from upstream:

- b7657e5 Ext3Fsd: Introduce VCB_RO_COMPAT_READ_ONLY flag for struct VCB

- e7c1142 Ext3Fsd: EXT4_FEATURE_INCOMPAT_64BIT is not supported

- 785943f Ext3Fsd: fix issue #6

Refuse mounting filesystems with incompatible flags. This avoids corrupting 64bits filesystems.

Patch by Lubomir Rintel

CORE-13589

[KERNEL32_VISTA]

Delay load NTDLL_vista, in order to save *380KB* at boot.

CORE-13361

[RDBSS]

- Misc fixes with DPRINTS

[RXCE]

- In RxFinalizeSrvOpen, always dereference the FCB, it's always referenced on SRV_OPEN creation

- Misc fixes with DPRINTS

With that revision and r75419, I'm now able to mount a NFS share, browse it, read a file from it, and unmount it.

We're OK regarding references counting!

CORE-8204

CORE-11327

CORE-13581

    • -2
    • +7
    /trunk/reactos/sdk/lib/drivers/rxce/rxce.c
[SHELL32]

Revert r75348.

Because of r75349, this revision was made useless, and even worse, it was leaking a handle to the directory where the FSD doesn't support notifications.

Also made some debug traces more useful

[NFS]

Huge "hack" for ReactOS.

In case we're asked to unmount a NFS share, and there are still active FCBs, browse the prefix table for active NET_ROOT, and then, dump their associated FCBs (prefix + refcount).

It seems we only leak the root FCB.

CORE-8204

CORE-11327

CORE-13581

[DDK]

Define RxIsFcbTableLockAcquired

CORE-8204

CORE-11327

CORE-13581

    • -0
    • +3
    /trunk/reactos/sdk/include/ddk/fcbtable.h