Eric Kohl

[POWERCFG]

Show and hide the power systray icon.

    • -1
    • +34
    /trunk/reactos/dll/cpl/powercfg/advanced.c
[STOBJECT]

Implement code to show and hide the power and volume icons in the notification area aka systray.

Control panel applications send WM_USR+220 messages to the systray window in order to show or hide an icon in the systray. The wParam parameter identifies the icon: 1=power, 4=volume. The lParam parameter indicates the new icon status: 0:show, 1:hide.

Control panel applications also send WM_USER+221 messages to the systray window in order to retrieve the current status of a systray icon. The wParam parameter identifies the icon, just like in the WM_SUER+220 messages. The lParam parameter is ignored. The return value indicates the status of the icon: 1:visible, 0:hidden.

    • -0
    • +185
    /trunk/reactos/dll/shellext/stobject/power.cpp
    • -29
    • +66
    /trunk/reactos/dll/shellext/stobject/volume.cpp
[AT]

- Confirm deleting all jobs.

- Fix typos in resources and add missing usage text.

[AT]

- Retrieve the users short day names instead of hardcoded day names.

- Fix resources.

[AT]

- Implement the DaysOfWeek parser and display code.

- ParseDaysOfMonth: Handle a failure case.

- Fix display bugs.

[AT]

- Replace ARRAYSIZE() by _countof().

- Implement parsing of days per month schedule information for the /every and /next options.

- Print days per month schedule information.

[AT]

Fix duplicate resource string.

[AT]

Implement the AT command:

- The /every and /next options are not supported yet.

- The 12 hour time format cannot be parsed yet.

    • -0
    • +515
    /trunk/reactos/base/applications/cmdutils/at/at.c
    • -0
    • +24
    /trunk/reactos/base/applications/cmdutils/at/resource.h
    • -0
    • +17
    /trunk/reactos/base/applications/cmdutils/at/at.rc
  1. /trunk/reactos/base/applications/cmdutils/at
    • -0
    • +8
    /trunk/reactos/base/applications/cmdutils/at/CMakeLists.txt
[FONTVIEW]

Implement fontview /p parameter support.

Patch by amber. Patch was slightly modified by me in order to open the print dialog automatically.

CORE-12944 #resolve #comment Thanks a lot!

[NTOS:IO]

IopGetDeviceRelations:

- Use captured parameters to probe for write.

- Do not check IopInitiatePnpIrp for STATUS_PENDING.

    • -4
    • +2
    /trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c
[NTOS:OB]

- Allocate all of the kernel objects security descriptor and the dos devices security descriptor from the paged pool, instead of just the ACLs.

- Replace special security descriptor free routines by calls to ExFreePoolWithTag.

- Replace the TAG_OB_DIR_SD by TAG_SD.

    • -37
    • +33
    /trunk/reactos/ntoskrnl/ob/obinit.c
    • -39
    • +36
    /trunk/reactos/ntoskrnl/ob/obname.c
[POWERCFG]

Replace 'CONTROL ... "Button", BS_AUTOCHECKBOX ...' by 'AUTOCHECKBOX'.

    • -6
    • +6
    /trunk/reactos/dll/cpl/powercfg/lang/he-IL.rc
    • -6
    • +6
    /trunk/reactos/dll/cpl/powercfg/lang/cs-CZ.rc
    • -6
    • +6
    /trunk/reactos/dll/cpl/powercfg/lang/id-ID.rc
    • -6
    • +6
    /trunk/reactos/dll/cpl/powercfg/lang/uk-UA.rc
    • -6
    • +6
    /trunk/reactos/dll/cpl/powercfg/lang/ru-RU.rc
    • -6
    • +6
    /trunk/reactos/dll/cpl/powercfg/lang/sk-SK.rc
    • -6
    • +6
    /trunk/reactos/dll/cpl/powercfg/lang/ro-RO.rc
    • -6
    • +6
    /trunk/reactos/dll/cpl/powercfg/lang/tr-TR.rc
    • -6
    • +6
    /trunk/reactos/dll/cpl/powercfg/lang/it-IT.rc
    • -6
    • +6
    /trunk/reactos/dll/cpl/powercfg/lang/zh-TW.rc
    • -6
    • +6
    /trunk/reactos/dll/cpl/powercfg/lang/fr-FR.rc
    • -6
    • +6
    /trunk/reactos/dll/cpl/powercfg/lang/ja-JP.rc
    • -6
    • +6
    /trunk/reactos/dll/cpl/powercfg/lang/sq-AL.rc
    • -6
    • +6
    /trunk/reactos/dll/cpl/powercfg/lang/th-TH.rc
    • -6
    • +6
    /trunk/reactos/dll/cpl/powercfg/lang/es-ES.rc
  1. … 8 more files in changeset.
[MMSYS]

Convert all CHECKBOXes to AUTOCHECKBOXes.

    • -3
    • +3
    /trunk/reactos/dll/cpl/mmsys/lang/zh-TW.rc
    • -3
    • +3
    /trunk/reactos/dll/cpl/mmsys/lang/he-IL.rc
    • -3
    • +3
    /trunk/reactos/dll/cpl/mmsys/lang/el-GR.rc
    • -3
    • +3
    /trunk/reactos/dll/cpl/mmsys/lang/es-ES.rc
    • -3
    • +3
    /trunk/reactos/dll/cpl/mmsys/lang/nl-NL.rc
    • -3
    • +3
    /trunk/reactos/dll/cpl/mmsys/lang/no-NO.rc
    • -3
    • +3
    /trunk/reactos/dll/cpl/mmsys/lang/sk-SK.rc
    • -3
    • +3
    /trunk/reactos/dll/cpl/mmsys/lang/fr-FR.rc
    • -3
    • +3
    /trunk/reactos/dll/cpl/mmsys/lang/ja-JP.rc
    • -3
    • +3
    /trunk/reactos/dll/cpl/mmsys/lang/ro-RO.rc
    • -3
    • +3
    /trunk/reactos/dll/cpl/mmsys/lang/zh-CN.rc
    • -3
    • +3
    /trunk/reactos/dll/cpl/mmsys/lang/sq-AL.rc
    • -3
    • +3
    /trunk/reactos/dll/cpl/mmsys/lang/uk-UA.rc
    • -3
    • +3
    /trunk/reactos/dll/cpl/mmsys/lang/it-IT.rc
    • -3
    • +3
    /trunk/reactos/dll/cpl/mmsys/lang/pl-PL.rc
  1. … 8 more files in changeset.
[NTOS:OB]

Replace calls to ExFreePool by calls to ExFreePoolWithTag.

[SHUTDOWN]

shutdown -t causes crash

Patch by Michael Fritscher.

CORE-12886 #resolve #comment Thanks a lot!

[NTOS:OB]

- Define and use a pool tag for directory security descriptors.

- Use a custom security descriptor to create the KernelObjects directory.

    • -5
    • +88
    /trunk/reactos/ntoskrnl/ob/obinit.c
[NTOS:CM]

CmpSecurityMethod:

- Lock and unlock the Hive and the KCB.

- Fail, if we try to access a key that has been marked for deletion.

    • -9
    • +61
    /trunk/reactos/ntoskrnl/config/cmse.c
[NTOS:OB]

Create a custom security descriptor for the global DosDevices directory.

    • -1
    • +104
    /trunk/reactos/ntoskrnl/ob/obname.c
[NTOS:SE]

Add a missing ACE(SeAliasAdminsSid / GENERIC_ALL) to the SePublicDefaultDacl ACL. This fixes a kmtest:ObSecurity failure.

[UMPNPMGR]

Fix a property id for a call to NtPlugPlayControl().

[SCHEDSVC]

Set service status to SERVICE_STOP_PENDING before setting it to SERVICE_STOPPED.

[USETUP]

Fix unbootable system after recreating the boot partition

Patch by Wim Hueskens.

CORE-11232 #resolve #comment Thanks a lot!

[FONTVIEW]

Implementation of the install button.

Patch by Baruch Rutman.

Fixes by Eric Kohl.

CORE-7355 #resolve #comment Thanks a lot!

[Fontview]

Unicodify it.

CORE-7355

[REACTOS]

Fix LoadSetupData() failure paths (properly).

CORE-11691 #resolve

    • -39
    • +68
    /trunk/reactos/base/setup/reactos/reactos.c
[USETUP]

Scroll in partitions list doesn't work.

Patch by thc.

CORE-11895 #resolve #comment Thanks a lot!

    • -0
    • +21
    /trunk/reactos/base/setup/usetup/partlist.c
[USETUP]

Define the language specific keyboard layout first. The US keyboard layout should always be the last one (aka fallback). Other languages will probably need the same fix!

CORE-10064 #resolve

    • -1
    • +1
    /trunk/reactos/base/setup/usetup/lang/ru-RU.h
[RAPPS_NEW][USRMGR]

Missing italian translations in ReactOS.

CORE-9725 #resolve #comment Thanks a lot for making this mess! Please don't ever reopen this task again! Create a new one instead!

    • -11
    • +11
    /trunk/reactos/dll/cpl/usrmgr/lang/it-IT.rc
[PROCESSR]

Add a generic processor driver that does nothing but provide a proper CPU device name (FriendlyName) to the registry.

CORE-5960 #resolve

    • -0
    • +12
    /trunk/reactos/drivers/processor/processr/CMakeLists.txt
    • -52
    • +77
    /trunk/reactos/media/inf/cpu.inf
    • -0
    • +65
    /trunk/reactos/drivers/processor/processr/processr.c
    • -0
    • +13
    /trunk/reactos/drivers/processor/processr/processr.rc
    • -0
    • +81
    /trunk/reactos/drivers/processor/processr/misc.c
  1. /trunk/reactos/drivers/processor/processr
    • -0
    • +2
    /trunk/reactos/drivers/processor/CMakeLists.txt
    • -0
    • +402
    /trunk/reactos/drivers/processor/processr/pnp.c
    • -0
    • +51
    /trunk/reactos/drivers/processor/processr/processr.h
[SETUPAPI]

- Implement CM_Get_Class_Registry_PropertyA().

- Move mapping of poperty type to registry value type into a separate function and use it in CM_Get_Class_Registry_PropertyA(), CM_Set_DevNode_Registry_Property_ExA() and CM_Set_DevNode_Registry_Property_ExW().

    • -164
    • +119
    /trunk/reactos/dll/win32/setupapi/cfgmgr.c