Eric Kohl

[NETAPI32]

Implement NetBrowserStatisticsGet().

    • -2
    • +76
    /trunk/reactos/dll/win32/netapi32/browser.c
    • -1
    • +1
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
[NETAPI32]

Move the functions NetGetDCName, NetGetAnyDCName and NetEnumerateTrustedDomains into a separate file for the Netlogon service interface code.

    • -0
    • +57
    /trunk/reactos/dll/win32/netapi32/netlogon.c
    • -42
    • +0
    /trunk/reactos/dll/win32/netapi32/access.c
[NETAPI32]

Implement I_BrowserQueryOtherDomains, I_BrowserQueryStatistics and I_BrowserResetNetlogonState. This functions calls their counterpart in the computer browser service.

    • -0
    • +91
    /trunk/reactos/dll/win32/netapi32/browser.c
    • -3
    • +3
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
[NETAPI32]

Implement I_BrowserQueryEmulatedDomains, I_BrowserResetStatistics and I_BrowserSetNetlogonState. This functions calls their counterpart in the computer browser service.

    • -1
    • +1
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
    • -4
    • +66
    /trunk/reactos/dll/win32/netapi32/browser.c
[INCLUDE]

Replace the lmbrowsr.h form wine by a more complete psdk version.

Lmbrowsr.h was a part of Visual Studio 6 but Microsoft removed it from the PSDK later.

    • -0
    • +78
    /trunk/reactos/sdk/include/psdk/lmbrowsr.h
[NETAPI32]

NetEnumerateComputerNames: Convert the returned array of strings.

    • -2
    • +26
    /trunk/reactos/dll/win32/netapi32/wksta_new.c
[NETAPI32]

Implement NetConnectionEnum(). This function calls its counterpart in the server service.

    • -1
    • +1
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
    • -0
    • +74
    /trunk/reactos/dll/win32/netapi32/srvsvc.c
[NTOS:SE]

Add the CmpAssignSecurityDescriptor() stub and improve some comments.

    • -6
    • +16
    /trunk/reactos/ntoskrnl/config/cmse.c
[DESK]

Replace the screen resolution change confirmation message box by a proper dialog box with timeout.

CORE-8352

    • -0
    • +12
    /trunk/reactos/dll/cpl/desk/lang/de-DE.rc
    • -0
    • +12
    /trunk/reactos/dll/cpl/desk/lang/hu-HU.rc
    • -0
    • +5
    /trunk/reactos/dll/cpl/desk/resource.h
    • -0
    • +12
    /trunk/reactos/dll/cpl/desk/lang/id-ID.rc
    • -0
    • +12
    /trunk/reactos/dll/cpl/desk/lang/ja-JP.rc
    • -0
    • +12
    /trunk/reactos/dll/cpl/desk/lang/el-GR.rc
    • -0
    • +12
    /trunk/reactos/dll/cpl/desk/lang/ru-RU.rc
    • -0
    • +12
    /trunk/reactos/dll/cpl/desk/lang/sv-SE.rc
    • -0
    • +12
    /trunk/reactos/dll/cpl/desk/lang/pt-BR.rc
    • -0
    • +12
    /trunk/reactos/dll/cpl/desk/lang/en-GB.rc
    • -0
    • +12
    /trunk/reactos/dll/cpl/desk/lang/bg-BG.rc
    • -0
    • +12
    /trunk/reactos/dll/cpl/desk/lang/pl-PL.rc
    • -3
    • +70
    /trunk/reactos/dll/cpl/desk/settings.c
    • -0
    • +12
    /trunk/reactos/dll/cpl/desk/lang/es-ES.rc
    • -0
    • +12
    /trunk/reactos/dll/cpl/desk/lang/nl-NL.rc
  1. … 13 more files in changeset.
[DESK]

- Add a message box to ask the user to confirm the screen resolution change.

- The resolution change will be reverted if the user clicks 'No'.

A separate dialog box with a timer will be added next.

    • -36
    • +85
    /trunk/reactos/dll/cpl/desk/settings.c
[ADVAPI32]

ScmRpcStatusToWinError: Convert STATUS_ACCESS_VIOLATION to ERROR_INVALID_HANDLE.

UnlockServiceDatabase returns ERROR_INVALID_SERVICE_LOCK instead of ERROR_INVALID_HANDLE.

    • -0
    • +4
    /trunk/reactos/dll/win32/advapi32/service/scm.c
[ADVAPI32]

CreateServiceA/W: Call SetLastError() in case of success too.

    • -2
    • +2
    /trunk/reactos/dll/win32/advapi32/service/scm.c
[ADVAPI32]

OpenServiceA/W: Call SetLastError() in case of success too.

    • -2
    • +2
    /trunk/reactos/dll/win32/advapi32/service/scm.c
[NETAPI32]

Add obsolete NetRepl functions.

    • -1
    • +178
    /trunk/reactos/dll/win32/netapi32/obsolete.c
    • -15
    • +15
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
[NETAPI32]

- Add I_BrowserQueryEmulatedDomains and I_BrowserSetNetlogonState to the new computer browser inferface file.

- Get rid of the now obsolete browsr.c file.

    • -43
    • +0
    /trunk/reactos/dll/win32/netapi32/browsr.c
    • -18
    • +49
    /trunk/reactos/dll/win32/netapi32/browser.c
[NETAPI32]

- Add the computer browser service client interface.

- Add binding code for the computer browser service client interface.

    • -0
    • +56
    /trunk/reactos/dll/win32/netapi32/browser.c
[NETAPI32]

Implement NetEnumerateComputerNames. This function calls its counterpart in the workstation service.

    • -1
    • +1
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
    • -0
    • +38
    /trunk/reactos/dll/win32/netapi32/wksta_new.c
[IDL]

Add computer browser service interface definition files.

    • -0
    • +6
    /trunk/reactos/sdk/include/reactos/idl/browser.acf
    • -0
    • +108
    /trunk/reactos/sdk/include/reactos/idl/browser.idl
[NETAPI32]

Move the stubs NetServerEnum and NetServerEnumEx into a new file for the computer browser service interface code.

    • -43
    • +0
    /trunk/reactos/dll/win32/netapi32/netapi32.c
    • -0
    • +61
    /trunk/reactos/dll/win32/netapi32/browser.c
[NETAPI32]

Implement NetGetJoinableOUs and NetValidateName. These functions call their counterparts in the workstation service.

    • -0
    • +82
    /trunk/reactos/dll/win32/netapi32/wksta_new.c
    • -2
    • +2
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
[NETAPI32]

Implement NetAddAlternateComputerName, NetJoinDomain, NetRemoveAlternateComputerName, NetRenameMachineInDomain, NetSetPrimaryComputerName and NetUnjoinDomain. These functions call their counterparts in the workstation service.

    • -6
    • +6
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
    • -1
    • +241
    /trunk/reactos/dll/win32/netapi32/wksta_new.c
[NTOSKRNL]

NtAccessCheck: Call SePrivilegePolicyCheck to get the list of required privileges and return it to the caller.

This fixes the ERROR_INSUFFICIENT_BUFFER failures in the advapi32 security winetest.

    • -2
    • +75
    /trunk/reactos/ntoskrnl/se/accesschk.c
[SCHEDSVC]

Add a loop at the end of SchedServiceMain that will run until a stop event is signaled. This loop will be used to run the schduled jobs.

    • -14
    • +43
    /trunk/reactos/base/services/schedsvc/schedsvc.c
[NETAPI32]

Add obsolete NetErrorLog and NetService functions.

    • -7
    • +7
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
    • -0
    • +102
    /trunk/reactos/dll/win32/netapi32/obsolete.c
[NETAPI32]

Add obsolete NetAudit and NetConfig functions.

    • -0
    • +84
    /trunk/reactos/dll/win32/netapi32/obsolete.c
    • -6
    • +6
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
[PSDK]

Fix NetAuditRead and NetAuditWrite prototypes (LPTSTR->LPCWSTR).

    • -2
    • +2
    /trunk/reactos/sdk/include/psdk/lmaudit.h
[NETAPI32]

Add obsolete NetAlert and NetMessage functions.

    • -0
    • +99
    /trunk/reactos/dll/win32/netapi32/obsolete.c
    • -7
    • +7
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
[NETAPI32]

Implement NetServerTransportAdd, NetServerTransportAddEx, NetServerTransportDel and NetServertransportEnum. These functions call their counterparts in the server service.

    • -0
    • +153
    /trunk/reactos/dll/win32/netapi32/srvsvc.c
    • -4
    • +4
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
[NETAPI32]

- Implement NetServerDiskEnum, NetServerGetInfo and NetServerSetInfo. These functions call their counterparts in the server service.

- The new NetServerGetInfo function is disabled because its server side (NetrServerGetInfo) must be implemented before we can replace the Wine implemenation without loss of functionality.

    • -18
    • +0
    /trunk/reactos/dll/win32/netapi32/netapi32.c
    • -1
    • +1
    /trunk/reactos/dll/win32/netapi32/netapi32.spec
    • -0
    • +120
    /trunk/reactos/dll/win32/netapi32/srvsvc.c
[SCHEDSVC]

Avoid JOBs overrunning in LoadJobs().

- Define JOB_NAME_LENGTH and use it instead of hardcoded values.

Based on a patch by Victor Martinez Calvo.

CORE-13389