Mark Jansen

[OLE32] Do not crash on an invalid / empty clipboard.

CORE-12302

  • More
  • CR-120
  • resumed reviewing
[SHIMENG] Enable the Application Compatibility framework by default.

- Also add disabled keys to configure the logging

- Demote a noisy print used in the shim engine.

At this point the shim engine should be functional enough to be used.

One thing that remains is creating more shims(fixes) to use, and implement more features for the already existing ones.

CORE-13284

    • -0
    • +2
    /trunk/reactos/boot/bootdata/hivesys.inf
    • -2
    • +2
    /trunk/reactos/boot/bootdata/hivesft.inf
[ACLAYERS] Add a compatibility shim + layer for the VMWare Horizon setup.

This fixes the setup trying to print some debug strings.

For now the shim has to be applied manually, however the setup does not complete yet.

Patch bits & fixes by Thomas.

CORE-13434

    • -0
    • +142
    /trunk/reactos/dll/appcompat/shims/layer/vmhorizon.c
[NTDLL_APITEST] Test unaligned pointers for NtOpenKey

CORE-13689

    • -0
    • +2
    /trunk/rostests/apitests/ntdll/testlist.c
    • -0
    • +58
    /trunk/rostests/apitests/ntdll/NtOpenKey.c
[ADVAPI32_APITEST] Addendum to 75585, use void pointers to work around gcc ignoring pshpack1.
    • -24
    • +11
    /trunk/rostests/apitests/advapi32/RegOpenKeyExW.c
[ADVAPI32_APITEST] Test unaligned pointers for RegOpenKeyExW.
    • -0
    • +59
    /trunk/rostests/apitests/advapi32/RegOpenKeyExW.c
[ACPPAGE] Do not allow shims to be applied to files in System32/WinSxs.

CORE-13618

[ATL] Use the AtlThrow helper so we can disable exceptions by defining _ATL_NO_EXCEPTIONS
    • -5
    • +9
    /trunk/reactos/sdk/lib/atl/atlsimpstr.h
[SHIMENG] Filter shims based on the include/exclude node specified, as well as their presence in certain directories.

- Shims are not allowed on files from System32 / WinSxs.

- Individual shims can override this per module with includes/excludes.

- Shims can specify additional dlls to ignore or include.

- Specify a default list of dlls to be included from system32.

CORE-13618

[RAPPS] Delete uTorrent until CORE-13666 is cleared up.
    • -64
    • +0
    /trunk/reactos/media/rapps/utorrent.txt
[UNATTEND] Show how to enable the lautus theme in unattended mode.
[FONTSUB] Russian translation by Sergey Stopkin.

ROSAPPS-339 #resolve #comment Thanks!

    • -0
    • +106
    /trunk/rosapps/applications/sysutils/fontsub/lang/ru-RU.rc
[WIN32SS] Improve GetFontResourceInfoW. Patch by Katayama Hirofumi MZ & Doug Lyons.

CORE-13365 #resolve #comment Thanks!

    • -23
    • +54
    /trunk/reactos/win32ss/gdi/ntgdi/freetype.c
[APPHELP][XML2SDB] Code cleanup + add assertions

- Always used pdb or hsdb, no more 'db'

- Add property to an PDB that describes if it's opened for read/write, and assert on this

- Add comments

    • -4
    • +4
    /trunk/reactos/sdk/tools/xml2sdb/xml2sdb.cpp
    • -23
    • +26
    /trunk/reactos/sdk/tools/xml2sdb/main.cpp
[RAPPS] Remove Burnaware free. CORE-12194 #resolve
    • -39
    • +0
    /trunk/reactos/media/rapps/burnawarefree.txt
[REGEDIT] Fix the search dialog not opening when the root node is selected. Patch by Joachim Henze (reactosfanboy).

Small changes by me.

CORE-13071 #resolve #comment Thanks!

[SDK][XML2SDB] Simplify include / exclude node specification.
    • -19
    • +20
    /trunk/reactos/sdk/tools/xml2sdb/xml2sdb.cpp
    • -0
    • +90
    /trunk/reactos/media/sdb/sysmain.xml
    • -6
    • +5
    /trunk/reactos/sdk/tools/xml2sdb/main.cpp
[SHIMENG] Partial rewrite to make the code easier to maintain.

- Protect ARRAY access with macro's / helper functions.

- Do not store objects in the ARRAY data, but store pointers to the objects.

- Rewrite import hooking to use an ARRAY instead of single linked lists.

    • -143
    • +152
    /trunk/reactos/dll/appcompat/apphelp/shimeng.c
[ACPPAGE] Fix the shell extension asking to add an empty layer.
[APPHELP] Various cleanup tasks

- Move debug heap functionality to a separate file

- Clean includes

- Remove msvcrt dependency

- Clean up string usage

- Remove some higher level functions in favor of their ntdll counterparts (wip).

    • -0
    • +177
    /trunk/reactos/dll/appcompat/apphelp/dbgheap.c
[APPHELP] Use DbgPrint instead of OutputDebugString + fix SDBAPI_DEBUG_ALLOC
[SHORTCUTS.INF] Move the shortcut creation for screenshot.exe to the new rosapps_shortcuts.inf. Patch by Joachim Henze (reactosfanboy)

CORE-13426 #resolve #comment Thanks!

    • -0
    • +47
    /trunk/rosapps/rosapps_shortcuts.inf
    • -47
    • +0
    /trunk/reactos/media/inf/shortcuts.inf
[WIN32SS][SHELL32] Fix the location and repaint of the version info shown on the desktop. Patch by Katayama Hirofumi MZ.

CORE-13567 #resolve #comment Thanks!

    • -0
    • +5
    /trunk/reactos/win32ss/user/ntuser/desktop.c
[SYSSETUP][SHORTCUTS.INF] Add FontSub program shortcut to Start Menu. Patch by Katayama Hirofumi MZ.

CORE-13428 #resolve #comment Thanks!

    • -0
    • +294
    /trunk/rosapps/rosapps_shortcuts.inf
    • -0
    • +14
    /trunk/reactos/dll/win32/syssetup/install.c
[SHIMENG] Pass shim commandline to shims. CORE-11329
[SHIMLIB] Add debug print functionality for shims. CORE-11329
[ACPPAGE] Usability: Convert the edit box to a combobox, ask the user if they want to add the layer when closing the dialog.
  1. … 10 more files in changeset.
[SHELL32] Do not dereference a nullpointer for logging. CORE-13552